Polish "Simplify some code"

See gh-17860
This commit is contained in:
Stephane Nicoll 2019-08-14 08:55:20 +02:00
parent 4bb842343a
commit 6f28f41774
1 changed files with 5 additions and 2 deletions

View File

@ -97,8 +97,11 @@ public class HealthWebEndpointResponseMapper {
}
private boolean canSeeDetails(SecurityContext securityContext, ShowDetails showDetails) {
return showDetails != ShowDetails.NEVER && (showDetails != ShowDetails.WHEN_AUTHORIZED
|| (securityContext.getPrincipal() != null && isUserInRole(securityContext)));
if (showDetails == ShowDetails.NEVER || (showDetails == ShowDetails.WHEN_AUTHORIZED
&& (securityContext.getPrincipal() == null || !isUserInRole(securityContext)))) {
return false;
}
return true;
}
private boolean isUserInRole(SecurityContext securityContext) {