Merge branch '1.4.x' into 1.5.x

spring-boot-test/src/main/java/org/springframework/boot/test/context/SpringBootTestContextCustomizer.java

@@ -62,7 +62,7 @@ class SpringBootTestContextCustomizer implements ContextCustomizer {
 
 	private void registerTestRestTemplate(ConfigurableApplicationContext context,
 			BeanDefinitionRegistry registry) {
-		registry.registerBeanDefinition("testRestTemplate",
+		registry.registerBeanDefinition(TestRestTemplate.class.getName(),
 				new RootBeanDefinition(TestRestTemplateFactory.class));
 	}
 

spring-boot-test/src/test/java/org/springframework/boot/test/context/AbstractSpringBootTestEmbeddedWebEnvironmentTests.java

@@ -60,6 +60,10 @@ public abstract class AbstractSpringBootTestEmbeddedWebEnvironmentTests {
 	@Autowired
 	private TestRestTemplate restTemplate;
 
+	public WebApplicationContext getContext() {
+		return this.context;
+	}
+
 	public TestRestTemplate getRestTemplate() {
 		return this.restTemplate;
 	}

spring-boot-test/src/test/java/org/springframework/boot/test/context/SpringBootTestTestRestTemplateDefinedByUser.java

@@ -0,0 +1,65 @@
+/*
+ * Copyright 2012-2016 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.boot.test.context;
+
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.test.annotation.DirtiesContext;
+import org.springframework.test.context.junit4.SpringRunner;
+import org.springframework.web.bind.annotation.RestController;
+import org.springframework.web.client.RestTemplate;
+import org.springframework.web.servlet.config.annotation.EnableWebMvc;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * Tests for {@link SpringBootTest} configured with {@link WebEnvironment#RANDOM_PORT}.
+ *
+ * @author Phillip Webb
+ * @author Andy Wilkinson
+ */
+@RunWith(SpringRunner.class)
+@DirtiesContext
+@SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT, properties = { "value=123" })
+public class SpringBootTestTestRestTemplateDefinedByUser
+		extends AbstractSpringBootTestEmbeddedWebEnvironmentTests {
+
+	@Test
+	public void restTemplateIsUserDefined() throws Exception {
+		assertThat(getContext().getBean("testRestTemplate"))
+				.isInstanceOf(RestTemplate.class);
+	}
+
+	// gh-7711
+
+	@Configuration
+	@EnableWebMvc
+	@RestController
+	protected static class Config extends AbstractConfig {
+
+		@Bean
+		public RestTemplate testRestTemplate() {
+			return new RestTemplate();
+		}
+
+	}
+
+}

spring-boot/src/main/java/org/springframework/boot/bind/RelaxedPropertyResolver.java

@@ -19,7 +19,9 @@ package org.springframework.boot.bind;
 import java.util.Map;
 
 import org.springframework.core.env.ConfigurableEnvironment;
+import org.springframework.core.env.Environment;
 import org.springframework.core.env.PropertyResolver;
+import org.springframework.core.env.PropertySourcesPropertyResolver;
 import org.springframework.util.Assert;
 
 /**
@@ -145,4 +147,25 @@ public class RelaxedPropertyResolver implements PropertyResolver {
 				keyPrefix);
 	}
 
+	/**
+	 * Return a property resolver for the environment, preferring one that ignores
+	 * unresolvable nested placeholders.
+	 * @param environment the source environment
+	 * @param prefix the prefix
+	 * @return a property resolver for the environment
+	 * @since 1.4.3
+	 */
+	public static RelaxedPropertyResolver ignoringUnresolvableNestedPlaceholders(
+			Environment environment, String prefix) {
+		Assert.notNull(environment, "Environment must not be null");
+		PropertyResolver resolver = environment;
+		if (environment instanceof ConfigurableEnvironment) {
+			resolver = new PropertySourcesPropertyResolver(
+					((ConfigurableEnvironment) environment).getPropertySources());
+			((PropertySourcesPropertyResolver) resolver)
+					.setIgnoreUnresolvableNestedPlaceholders(true);
+		}
+		return new RelaxedPropertyResolver(resolver, prefix);
+	}
+
 }

spring-boot/src/main/java/org/springframework/boot/logging/LoggingSystemProperties.java

@@ -49,8 +49,8 @@ class LoggingSystemProperties {
 	}
 
 	public void apply(LogFile logFile) {
-		RelaxedPropertyResolver propertyResolver = new RelaxedPropertyResolver(
+		RelaxedPropertyResolver propertyResolver = RelaxedPropertyResolver
-				this.environment, "logging.");
+				.ignoringUnresolvableNestedPlaceholders(this.environment, "logging.");
 		setSystemProperty(propertyResolver, EXCEPTION_CONVERSION_WORD,
 				"exception-conversion-word");
 		setSystemProperty(propertyResolver, CONSOLE_LOG_PATTERN, "pattern.console");

spring-boot/src/main/java/org/springframework/boot/logging/logback/DefaultLogbackConfiguration.java

@@ -72,7 +72,8 @@ class DefaultLogbackConfiguration {
 		if (environment == null) {
 			return new PropertySourcesPropertyResolver(null);
 		}
-		return new RelaxedPropertyResolver(environment, "logging.pattern.");
+		return RelaxedPropertyResolver.ignoringUnresolvableNestedPlaceholders(environment,
+				"logging.pattern.");
 	}
 
 	public void apply(LogbackConfigurator config) {

spring-boot/src/test/java/org/springframework/boot/logging/LoggingApplicationListenerTests.java

@@ -469,6 +469,16 @@ public class LoggingApplicationListenerTests {
 		assertThat(System.getProperty("PID")).isNotNull();
 	}
 
+	@Test
+	public void environmentPropertiesIgnoreUnresolvablePlaceholders() {
+		// gh-7719
+		TestPropertySourceUtils.addInlinedPropertiesToEnvironment(this.context,
+				"logging.pattern.console=console ${pid}");
+		this.initializer.initialize(this.context.getEnvironment(),
+				this.context.getClassLoader());
+		assertThat(System.getProperty("CONSOLE_LOG_PATTERN")).isEqualTo("console ${pid}");
+	}
+
 	@Test
 	public void logFilePropertiesCanReferenceSystemProperties() {
 		TestPropertySourceUtils.addInlinedPropertiesToEnvironment(this.context,