diff --git a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceAutoConfiguration.java b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceAutoConfiguration.java index 0c442fb19d9..e1d89f0a196 100644 --- a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceAutoConfiguration.java +++ b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceAutoConfiguration.java @@ -56,8 +56,6 @@ import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseType; @Import(Registrar.class) public class DataSourceAutoConfiguration { - public static final String CONFIGURATION_PREFIX = "spring.datasource"; - /** * Determines if the {@code dataSource} being used by Spring was created from * {@link EmbeddedDataSourceConfiguration}. @@ -99,7 +97,7 @@ public class DataSourceAutoConfiguration { @Autowired private DataSourceProperties properties; - @ConfigurationProperties(prefix = DataSourceAutoConfiguration.CONFIGURATION_PREFIX) + @ConfigurationProperties(prefix = DataSourceProperties.PREFIX) @Bean public DataSource dataSource() { DataSourceBuilder factory = DataSourceBuilder diff --git a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceProperties.java b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceProperties.java index d42222a8481..67f648b54a9 100644 --- a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceProperties.java +++ b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceProperties.java @@ -31,9 +31,11 @@ import org.springframework.util.StringUtils; * @author Maciej Walkowiak * @since 1.1.0 */ -@ConfigurationProperties(prefix = DataSourceAutoConfiguration.CONFIGURATION_PREFIX) +@ConfigurationProperties(prefix = DataSourceProperties.PREFIX) public class DataSourceProperties implements BeanClassLoaderAware, InitializingBean { + public static final String PREFIX = "spring.datasource"; + private String driverClassName; private String url; @@ -199,7 +201,7 @@ public class DataSourceProperties implements BeanClassLoaderAware, InitializingB } public String getSqlScriptEncoding() { - return sqlScriptEncoding; + return this.sqlScriptEncoding; } public void setSqlScriptEncoding(String sqlScriptEncoding) { diff --git a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/CommonsDataSourceConfigurationTests.java b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/CommonsDataSourceConfigurationTests.java index ca5f32ef9b0..af1847fa48f 100644 --- a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/CommonsDataSourceConfigurationTests.java +++ b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/CommonsDataSourceConfigurationTests.java @@ -92,7 +92,7 @@ public class CommonsDataSourceConfigurationTests { protected static class CommonsDataSourceConfiguration { @Bean - @ConfigurationProperties(prefix = DataSourceAutoConfiguration.CONFIGURATION_PREFIX) + @ConfigurationProperties(prefix = DataSourceProperties.PREFIX) public DataSource dataSource() { return DataSourceBuilder.create().type(BasicDataSource.class).build(); } diff --git a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/HikariDataSourceConfigurationTests.java b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/HikariDataSourceConfigurationTests.java index 25dd30c3897..a9da2b94f7c 100644 --- a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/HikariDataSourceConfigurationTests.java +++ b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/HikariDataSourceConfigurationTests.java @@ -103,7 +103,7 @@ public class HikariDataSourceConfigurationTests { protected static class HikariDataSourceConfiguration { @Bean - @ConfigurationProperties(prefix = DataSourceAutoConfiguration.CONFIGURATION_PREFIX) + @ConfigurationProperties(prefix = DataSourceProperties.PREFIX) public DataSource dataSource() { return DataSourceBuilder.create().type(HikariDataSource.class).build(); } diff --git a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/TomcatDataSourceConfigurationTests.java b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/TomcatDataSourceConfigurationTests.java index 4710f524c59..2c7d1f24fd8 100644 --- a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/TomcatDataSourceConfigurationTests.java +++ b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/TomcatDataSourceConfigurationTests.java @@ -135,7 +135,7 @@ public class TomcatDataSourceConfigurationTests { protected static class TomcatDataSourceConfiguration { @Bean - @ConfigurationProperties(prefix = DataSourceAutoConfiguration.CONFIGURATION_PREFIX) + @ConfigurationProperties(prefix = DataSourceProperties.PREFIX) public DataSource dataSource() { return DataSourceBuilder.create() .type(org.apache.tomcat.jdbc.pool.DataSource.class).build();