From 784c8d2df4837f7902bc07ebf72d9cb576f256fd Mon Sep 17 00:00:00 2001 From: Andy Wilkinson Date: Thu, 11 Jul 2024 12:17:25 +0100 Subject: [PATCH] Avoid duplicate junit-platform.properties files caused by Kafka Gradle doesn't support excluding a dependency that's declared with a classifier. Instead, this commit replaces the test-qualified kafka-server-common dependency with the plain dependency. The plain dependency was already present so this is equivalent to excluding the test-qualified dependency. Closes gh-41446 --- .../spring-boot-autoconfigure/build.gradle | 10 ++++++++++ spring-boot-project/spring-boot-docs/build.gradle | 9 +++++++++ .../spring-boot-smoke-test-kafka/build.gradle | 10 ++++++++++ 3 files changed, 29 insertions(+) diff --git a/spring-boot-project/spring-boot-autoconfigure/build.gradle b/spring-boot-project/spring-boot-autoconfigure/build.gradle index d18e136eeb1..02f4ab53780 100644 --- a/spring-boot-project/spring-boot-autoconfigure/build.gradle +++ b/spring-boot-project/spring-boot-autoconfigure/build.gradle @@ -10,6 +10,16 @@ plugins { description = "Spring Boot AutoConfigure" +configurations.all { + resolutionStrategy.eachDependency { DependencyResolveDetails details -> + if (details.requested.module.group == "org.apache.kafka" && details.requested.module.name == "kafka-server-common") { + details.artifactSelection { + selectArtifact(DependencyArtifact.DEFAULT_TYPE, null, null) + } + } + } +} + dependencies { api(project(":spring-boot-project:spring-boot")) diff --git a/spring-boot-project/spring-boot-docs/build.gradle b/spring-boot-project/spring-boot-docs/build.gradle index ade35c5c56d..7427db3e4ed 100644 --- a/spring-boot-project/spring-boot-docs/build.gradle +++ b/spring-boot-project/spring-boot-docs/build.gradle @@ -15,6 +15,15 @@ configurations { springApplicationExample testSlices antoraContent + all { + resolutionStrategy.eachDependency { DependencyResolveDetails details -> + if (details.requested.module.group == "org.apache.kafka" && details.requested.module.name == "kafka-server-common") { + details.artifactSelection { + selectArtifact(DependencyArtifact.DEFAULT_TYPE, null, null) + } + } + } + } } jar { diff --git a/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-kafka/build.gradle b/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-kafka/build.gradle index e524a450adb..bb5d0fe2a4f 100644 --- a/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-kafka/build.gradle +++ b/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-kafka/build.gradle @@ -6,6 +6,16 @@ plugins { description = "Spring Boot Kafka smoke test" +configurations.all { + resolutionStrategy.eachDependency { DependencyResolveDetails details -> + if (details.requested.module.group == "org.apache.kafka" && details.requested.module.name == "kafka-server-common") { + details.artifactSelection { + selectArtifact(DependencyArtifact.DEFAULT_TYPE, null, null) + } + } + } +} + dependencies { dockerTestImplementation(project(":spring-boot-project:spring-boot-starters:spring-boot-starter-test")) dockerTestImplementation(project(":spring-boot-project:spring-boot-tools:spring-boot-test-support-docker"))