root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 15 Packages Projects Releases Wiki Activity

Update computation of ehcache statistics 

Previously, the ehcache statistics were computed on the activity of the
last minute which gives a "live" overview. All others cache managers,
including JCache, provides a "cumulative" metrics (i.e. the hit/miss
ratio since the creation of the cache or the last time it got cleared).

Ths commit aligns the ehcache statistics to provide a similar semantics
as the other cache managers. The side effect is that the metrics are now
available, even if there is no cache activity at all at the moment.

Closes gh-4891
This commit is contained in:
Stephane Nicoll 2016-03-05 09:21:11 +01:00
parent d6bc3f0bc6
commit 830c4c996f
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/cache/EhCacheStatisticsProvider.java vendored
View File

@ -1,5 +1,5 @@
/*
* Copyright 2012-2015 the original author or authors.
* Copyright 2012-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -35,7 +35,7 @@ public class EhCacheStatisticsProvider implements CacheStatisticsProvider<EhCach
DefaultCacheStatistics statistics = new DefaultCacheStatistics();
StatisticsGateway ehCacheStatistics = cache.getNativeCache().getStatistics();
statistics.setSize(ehCacheStatistics.getSize());
Double hitRatio = ehCacheStatistics.cacheHitRatio();
Double hitRatio = cacheHitRatio(ehCacheStatistics);
if (!hitRatio.isNaN()) {
// ratio is calculated 'racily' and can drift marginally above unity,
// so we cap it here
@ -46,4 +46,10 @@ public class EhCacheStatisticsProvider implements CacheStatisticsProvider<EhCach
return statistics;
}
private static Double cacheHitRatio(StatisticsGateway stats) {
long hitCount = stats.cacheHitCount();
long cacheMissCount = stats.cacheMissCount();
return ((double) hitCount) / (hitCount + cacheMissCount);
}
}