From 84da5a26a78bef7da170f1d5c2783d58d5adfd93 Mon Sep 17 00:00:00 2001 From: Craig Andrews Date: Wed, 9 Sep 2015 21:08:44 -0400 Subject: [PATCH] Add `git.properties` to default devtools excludes Update `DevToolsProperties` to exclude `git.properties` files. Prior to this commit any application configured to write `git.properties` could trigger unexpected application restarts. The problem is particularly prevalent when using Eclipse M2E in combination with the `git-commit-id-plugin`. Closes gh-3938 --- .../boot/devtools/autoconfigure/DevToolsProperties.java | 2 +- .../boot/devtools/autoconfigure/DevToolsPropertiesTests.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/autoconfigure/DevToolsProperties.java b/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/autoconfigure/DevToolsProperties.java index 112627afe5d..afeb9ea51aa 100644 --- a/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/autoconfigure/DevToolsProperties.java +++ b/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/autoconfigure/DevToolsProperties.java @@ -60,7 +60,7 @@ public class DevToolsProperties { private static final String DEFAULT_RESTART_EXCLUDES = "META-INF/maven/**," + "META-INF/resources/**,resources/**,static/**,public/**,templates/**," - + "**/*Test.class,**/*Tests.class"; + + "**/*Test.class,**/*Tests.class,git.properties"; private static final long DEFAULT_RESTART_POLL_INTERVAL = 1000; diff --git a/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/autoconfigure/DevToolsPropertiesTests.java b/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/autoconfigure/DevToolsPropertiesTests.java index 72d68e0bf55..fa50316407d 100644 --- a/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/autoconfigure/DevToolsPropertiesTests.java +++ b/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/autoconfigure/DevToolsPropertiesTests.java @@ -38,7 +38,8 @@ public class DevToolsPropertiesTests { restart.getAllExclude(), arrayContaining("META-INF/maven/**", "META-INF/resources/**", "resources/**", "static/**", "public/**", "templates/**", - "**/*Test.class", "**/*Tests.class", "foo/**", "bar/**")); + "**/*Test.class", "**/*Tests.class", "git.properties", "foo/**", + "bar/**")); } @Test