diff --git a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/resource/AuthoritiesExtractor.java b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/resource/AuthoritiesExtractor.java index 4db5c9e9f14..44f8866e079 100644 --- a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/resource/AuthoritiesExtractor.java +++ b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/resource/AuthoritiesExtractor.java @@ -32,7 +32,6 @@ public interface AuthoritiesExtractor { /** * Extract the authorities from the resource server's response. - * * @param map the response * @return the extracted authorities */ diff --git a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/resource/FixedAuthoritiesExtractor.java b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/resource/FixedAuthoritiesExtractor.java index 3d3045fd5d5..ff6afb65973 100644 --- a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/resource/FixedAuthoritiesExtractor.java +++ b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/resource/FixedAuthoritiesExtractor.java @@ -41,19 +41,19 @@ public class FixedAuthoritiesExtractor implements AuthoritiesExtractor { public List extractAuthorities(Map map) { String authorities = "ROLE_USER"; if (map.containsKey(AUTHORITIES)) { - Object object = map.get(AUTHORITIES); - if (object instanceof Collection) { - authorities = StringUtils - .collectionToCommaDelimitedString((Collection) object); - } - else if (ObjectUtils.isArray(object)) { - authorities = StringUtils.arrayToCommaDelimitedString((Object[]) object); - } - else if (object != null) { - authorities = object.toString(); - } + authorities = asAuthorities(map.get(AUTHORITIES)); } return AuthorityUtils.commaSeparatedStringToAuthorityList(authorities); } + private String asAuthorities(Object object) { + if (object instanceof Collection) { + return StringUtils.collectionToCommaDelimitedString((Collection) object); + } + if (ObjectUtils.isArray(object)) { + return StringUtils.arrayToCommaDelimitedString((Object[]) object); + } + return object.toString(); + } + } diff --git a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/resource/FixedAuthoritiesExtractorTests.java b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/resource/FixedAuthoritiesExtractorTests.java index d3b5a09a1a0..c1272fc2e84 100644 --- a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/resource/FixedAuthoritiesExtractorTests.java +++ b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/resource/FixedAuthoritiesExtractorTests.java @@ -25,6 +25,8 @@ import org.junit.Test; import static org.junit.Assert.assertEquals; /** + * Tests for {@link FixedAuthoritiesExtractor}. + * * @author Dave Syer */ public class FixedAuthoritiesExtractorTests { diff --git a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/resource/ResourceServerTokenServicesConfigurationTests.java b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/resource/ResourceServerTokenServicesConfigurationTests.java index df97746b553..a526d116c22 100644 --- a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/resource/ResourceServerTokenServicesConfigurationTests.java +++ b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/resource/ResourceServerTokenServicesConfigurationTests.java @@ -204,8 +204,10 @@ public class ResourceServerTokenServicesConfigurationTests { return AuthorityUtils .commaSeparatedStringToAuthorityList("ROLE_ADMIN"); } + }; } + } @Import({ OAuth2RestOperationsConfiguration.class }) diff --git a/spring-boot/src/main/java/org/springframework/boot/logging/LoggingSystem.java b/spring-boot/src/main/java/org/springframework/boot/logging/LoggingSystem.java index 03e331c5dfe..8b634066a5e 100644 --- a/spring-boot/src/main/java/org/springframework/boot/logging/LoggingSystem.java +++ b/spring-boot/src/main/java/org/springframework/boot/logging/LoggingSystem.java @@ -96,7 +96,6 @@ public abstract class LoggingSystem { * Returns a {@link Runnable} that can handle shutdown of this logging system when the * JVM exits. The default implementation returns {@code null}, indicating that no * shutdown is required. - * * @return the shutdown handler, or {@code null} */ public Runnable getShutdownHandler() { diff --git a/spring-boot/src/test/java/org/springframework/boot/logging/LoggingApplicationListenerTests.java b/spring-boot/src/test/java/org/springframework/boot/logging/LoggingApplicationListenerTests.java index d681efb22ba..25f65210928 100644 --- a/spring-boot/src/test/java/org/springframework/boot/logging/LoggingApplicationListenerTests.java +++ b/spring-boot/src/test/java/org/springframework/boot/logging/LoggingApplicationListenerTests.java @@ -414,4 +414,5 @@ public class LoggingApplicationListenerTests { } } + }