root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #34319 from izeye 

* pr/34319:
  Polish "Add missing Micrometer PropertiesConfigAdapterTests"

Closes gh-34319
This commit is contained in:
Moritz Halbritter 2023-03-01 12:46:32 +01:00
parent 36a7428827 956a579bc9
commit 891dc913d5
4 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/graphite/GraphitePropertiesConfigAdapterTests.java
View File

@ -55,8 +55,8 @@ class GraphitePropertiesConfigAdapterTests {
@Test @Test
void whenPropertiesDurationUnitsIsSetAdapterDurationUnitsReturnsIt() { void whenPropertiesDurationUnitsIsSetAdapterDurationUnitsReturnsIt() {
GraphiteProperties properties = new GraphiteProperties(); GraphiteProperties properties = new GraphiteProperties();
properties.setRateUnits(TimeUnit.MINUTES); properties.setDurationUnits(TimeUnit.MINUTES);
assertThat(new GraphitePropertiesConfigAdapter(properties).rateUnits()).isEqualTo(TimeUnit.MINUTES); assertThat(new GraphitePropertiesConfigAdapter(properties).durationUnits()).isEqualTo(TimeUnit.MINUTES);
} }
@Test @Test

2
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/newrelic/NewRelicPropertiesConfigAdapterTests.java
View File

@ -63,7 +63,7 @@ class NewRelicPropertiesConfigAdapterTests
} }
@Test @Test
void whenPropertiesApikeyIsSetAdapterApikeyReturnsIt() { void whenPropertiesApiKeyIsSetAdapterApiKeyReturnsIt() {
NewRelicProperties properties = createProperties(); NewRelicProperties properties = createProperties();
properties.setApiKey("my-key"); properties.setApiKey("my-key");
assertThat(createConfigAdapter(properties).apiKey()).isEqualTo("my-key"); assertThat(createConfigAdapter(properties).apiKey()).isEqualTo("my-key");

2
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/signalfx/SignalFXPropertiesConfigAdapterTests.java → spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/signalfx/SignalFxPropertiesConfigAdapterTests.java
View File

@ -27,7 +27,7 @@ import static org.assertj.core.api.Assertions.assertThat;
* *
* @author Mirko Sobeck * @author Mirko Sobeck
*/ */
class SignalFXPropertiesConfigAdapterTests class SignalFxPropertiesConfigAdapterTests
extends StepRegistryPropertiesConfigAdapterTests<SignalFxProperties, SignalFxPropertiesConfigAdapter> { extends StepRegistryPropertiesConfigAdapterTests<SignalFxProperties, SignalFxPropertiesConfigAdapter> {
@Override @Override

6
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/simple/SimplePropertiesConfigAdapterTests.java
View File

@ -21,12 +21,10 @@ import java.time.Duration;
import io.micrometer.core.instrument.simple.CountingMode; import io.micrometer.core.instrument.simple.CountingMode;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.springframework.boot.actuate.autoconfigure.metrics.export.signalfx.SignalFxPropertiesConfigAdapter;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
/** /**
* Tests for {@link SignalFxPropertiesConfigAdapter}. * Tests for {@link SimplePropertiesConfigAdapter}.
* *
* @author Mirko Sobeck * @author Mirko Sobeck
*/ */
@ -40,7 +38,7 @@ class SimplePropertiesConfigAdapterTests {
} }
@Test @Test
void whenPropertiesAccessTokenIsSetAdapterAccessTokenReturnsIt() { void whenPropertiesModeIsSetAdapterModeReturnsIt() {
SimpleProperties properties = new SimpleProperties(); SimpleProperties properties = new SimpleProperties();
properties.setMode(CountingMode.STEP); properties.setMode(CountingMode.STEP);
assertThat(new SimplePropertiesConfigAdapter(properties).mode()).isEqualTo(CountingMode.STEP); assertThat(new SimplePropertiesConfigAdapter(properties).mode()).isEqualTo(CountingMode.STEP);