root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Fix list property to be mutable 

Closes gh-7068
This commit is contained in:
Stephane Nicoll 2016-10-03 10:40:46 +02:00
parent 4dfdce5a49
commit 8c1b736bb0
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/ManagementServerProperties.java
View File

@ -17,6 +17,7 @@
package org.springframework.boot.actuate.autoconfigure; package org.springframework.boot.actuate.autoconfigure;
import java.net.InetAddress; import java.net.InetAddress;
import java.util.ArrayList;
import java.util.Collections; import java.util.Collections;
import java.util.List; import java.util.List;
@ -178,7 +179,7 @@ public class ManagementServerProperties implements SecurityPrerequisite {
/** /**
* Comma-separated list of roles that can access the management endpoint. * Comma-separated list of roles that can access the management endpoint.
*/ */
private List<String> roles = Collections.singletonList("ADMIN"); private List<String> roles = new ArrayList<String>(Collections.singletonList("ADMIN"));
/** /**
* Session creating policy to use (always, never, if_required, stateless). * Session creating policy to use (always, never, if_required, stateless).
@ -199,7 +200,7 @@ public class ManagementServerProperties implements SecurityPrerequisite {
@Deprecated @Deprecated
public void setRole(String role) { public void setRole(String role) {
this.roles = Collections.singletonList(role); this.roles = new ArrayList<String>(Collections.singletonList(role));
} }
public List<String> getRoles() { public List<String> getRoles() {

7
spring-boot-actuator/src/test/java/org/springframework/boot/actuate/autoconfigure/ManagementServerPropertiesAutoConfigurationTests.java
View File

@ -80,6 +80,13 @@ public class ManagementServerPropertiesAutoConfigurationTests {
assertThat(properties.getSecurity().getRoles()).containsOnly("FOO"); assertThat(properties.getSecurity().getRoles()).containsOnly("FOO");
} }
@Test
public void managementRolesAllowsIndexedAccess() {
ManagementServerProperties properties = load(
"management.security.roles[0]=FOO");
assertThat(properties.getSecurity().getRoles()).containsOnly("FOO");
}
@Test @Test
public void managementRolesSetMultipleRoles() { public void managementRolesSetMultipleRoles() {
ManagementServerProperties properties = load( ManagementServerProperties properties = load(