diff --git a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2ClientPropertiesRegistrationAdapterTests.java b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2ClientPropertiesRegistrationAdapterTests.java index cd75a88cff0..d0f42274267 100644 --- a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2ClientPropertiesRegistrationAdapterTests.java +++ b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2ClientPropertiesRegistrationAdapterTests.java @@ -110,7 +110,7 @@ public class OAuth2ClientPropertiesRegistrationAdapterTests { assertThat(adapted.getAuthorizationGrantType()).isEqualTo( org.springframework.security.oauth2.core.AuthorizationGrantType.AUTHORIZATION_CODE); assertThat(adapted.getRedirectUri()).isEqualTo( - "{scheme}://{serverName}:{serverPort}{contextPath}/oauth2/authorize/code/{clientAlias}"); + "{scheme}://{serverName}:{serverPort}{contextPath}/oauth2/authorize/code/{registrationId}"); assertThat(adapted.getScope()).containsExactly("openid", "profile", "email", "address", "phone"); assertThat(adapted.getClientName()).isEqualTo("Google"); diff --git a/spring-boot-samples/spring-boot-sample-oauth2-client/src/main/resources/application.yml b/spring-boot-samples/spring-boot-sample-oauth2-client/src/main/resources/application.yml index 5ee1883be1d..17daa597b24 100644 --- a/spring-boot-samples/spring-boot-sample-oauth2-client/src/main/resources/application.yml +++ b/spring-boot-samples/spring-boot-sample-oauth2-client/src/main/resources/application.yml @@ -4,15 +4,15 @@ spring: client: registration: github-client-1: - client-id: 1b4c6c2d23a2dbec8959 - client-secret: 8bdb4047d98f37e1c6aeba9ffd2017bc31682e1b + client-id: ${APP-CLIENT-ID} + client-secret: ${APP-CLIENT-SECRET} client-name: Github user provider: github scope: user redirect_uri: http://localhost:8080/oauth2/authorize/code/github github-client-2: - client-id: 1b4c6c2d23a2dbec8959 - client-secret: 8bdb4047d98f37e1c6aeba9ffd2017bc31682e1b + client-id: ${APP-CLIENT-ID} + client-secret: ${APP-CLIENT-SECRET} client-name: Github email provider: github scope: user:email diff --git a/spring-boot-samples/spring-boot-sample-oauth2-client/src/test/main/java/sample/oauth2/client/SampleOAuth2ClientApplicationTests.java b/spring-boot-samples/spring-boot-sample-oauth2-client/src/test/main/java/sample/oauth2/client/SampleOAuth2ClientApplicationTests.java index 62a3bc8af2a..3c376bcbbf7 100644 --- a/spring-boot-samples/spring-boot-sample-oauth2-client/src/test/main/java/sample/oauth2/client/SampleOAuth2ClientApplicationTests.java +++ b/spring-boot-samples/spring-boot-sample-oauth2-client/src/test/main/java/sample/oauth2/client/SampleOAuth2ClientApplicationTests.java @@ -22,7 +22,8 @@ import static org.assertj.core.api.Assertions.assertThat; * @author Madhura Bhave */ @RunWith(SpringRunner.class) -@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) +@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT, properties = { + "APP-CLIENT-ID=my-client-id", "APP-CLIENT-SECRET=my-client-secret" }) @DirtiesContext public class SampleOAuth2ClientApplicationTests {