Merge pull request #3235 from izeye/ehcache

* ehcache:
  Polish
  Fix EhCache hit/miss ratio
This commit is contained in:
Stephane Nicoll 2015-06-16 10:31:32 +02:00
commit a33deee9f3
1 changed files with 4 additions and 2 deletions

View File

@ -37,8 +37,10 @@ public class EhCacheStatisticsProvider implements CacheStatisticsProvider<EhCach
statistics.setSize(ehCacheStatistics.getSize()); statistics.setSize(ehCacheStatistics.getSize());
Double hitRatio = ehCacheStatistics.cacheHitRatio(); Double hitRatio = ehCacheStatistics.cacheHitRatio();
if (!hitRatio.isNaN()) { if (!hitRatio.isNaN()) {
statistics.setHitRatio(hitRatio); // ratio is calculated 'racily' and can drift marginally above unity, so we cap it here
statistics.setMissRatio(1 - hitRatio); double sanitizedHitRatio = hitRatio > 1 ? 1 : hitRatio;
statistics.setHitRatio(sanitizedHitRatio);
statistics.setMissRatio(1 - sanitizedHitRatio);
} }
return statistics; return statistics;
} }