Merge pull request #39395 from BenchmarkingBuffalo
* pr/39395: Add nameIdFormat to Properties Closes gh-39395
This commit is contained in:
		
						commit
						ac2acc6115
					
				| 
						 | 
				
			
			@ -31,6 +31,7 @@ import org.springframework.security.saml2.provider.service.registration.Saml2Mes
 | 
			
		|||
 * @author Madhura Bhave
 | 
			
		||||
 * @author Phillip Webb
 | 
			
		||||
 * @author Moritz Halbritter
 | 
			
		||||
 * @author Lasse Wulff
 | 
			
		||||
 * @since 2.2.0
 | 
			
		||||
 */
 | 
			
		||||
@ConfigurationProperties("spring.security.saml2.relyingparty")
 | 
			
		||||
| 
						 | 
				
			
			@ -72,6 +73,8 @@ public class Saml2RelyingPartyProperties {
 | 
			
		|||
		 */
 | 
			
		||||
		private final AssertingParty assertingparty = new AssertingParty();
 | 
			
		||||
 | 
			
		||||
		private String nameIdFormat;
 | 
			
		||||
 | 
			
		||||
		public String getEntityId() {
 | 
			
		||||
			return this.entityId;
 | 
			
		||||
		}
 | 
			
		||||
| 
						 | 
				
			
			@ -92,12 +95,20 @@ public class Saml2RelyingPartyProperties {
 | 
			
		|||
			return this.decryption;
 | 
			
		||||
		}
 | 
			
		||||
 | 
			
		||||
		public Singlelogout getSinglelogout() {
 | 
			
		||||
			return this.singlelogout;
 | 
			
		||||
		}
 | 
			
		||||
 | 
			
		||||
		public AssertingParty getAssertingparty() {
 | 
			
		||||
			return this.assertingparty;
 | 
			
		||||
		}
 | 
			
		||||
 | 
			
		||||
		public Singlelogout getSinglelogout() {
 | 
			
		||||
			return this.singlelogout;
 | 
			
		||||
		public String getNameIdFormat() {
 | 
			
		||||
			return this.nameIdFormat;
 | 
			
		||||
		}
 | 
			
		||||
 | 
			
		||||
		public void setNameIdFormat(String nameIdFormat) {
 | 
			
		||||
			this.nameIdFormat = nameIdFormat;
 | 
			
		||||
		}
 | 
			
		||||
 | 
			
		||||
		public static class Acs {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -56,6 +56,7 @@ import org.springframework.util.StringUtils;
 | 
			
		|||
 * @author Phillip Webb
 | 
			
		||||
 * @author Moritz Halbritter
 | 
			
		||||
 * @author Lasse Lindqvist
 | 
			
		||||
 * @author Lasse Wulff
 | 
			
		||||
 */
 | 
			
		||||
@Configuration(proxyBeanMethods = false)
 | 
			
		||||
@Conditional(RegistrationConfiguredCondition.class)
 | 
			
		||||
| 
						 | 
				
			
			@ -104,6 +105,7 @@ class Saml2RelyingPartyRegistrationConfiguration {
 | 
			
		|||
		builder.singleLogoutServiceResponseLocation(properties.getSinglelogout().getResponseUrl());
 | 
			
		||||
		builder.singleLogoutServiceBinding(properties.getSinglelogout().getBinding());
 | 
			
		||||
		builder.entityId(properties.getEntityId());
 | 
			
		||||
		builder.nameIdFormat(properties.getNameIdFormat());
 | 
			
		||||
		RelyingPartyRegistration registration = builder.build();
 | 
			
		||||
		boolean signRequest = registration.getAssertingPartyDetails().getWantAuthnRequestsSigned();
 | 
			
		||||
		validateSigningCredentials(properties, signRequest);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -34,6 +34,7 @@ import static org.assertj.core.api.Assertions.assertThat;
 | 
			
		|||
 * Tests for {@link Saml2RelyingPartyProperties}.
 | 
			
		||||
 *
 | 
			
		||||
 * @author Madhura Bhave
 | 
			
		||||
 * @author Lasse Wulff
 | 
			
		||||
 */
 | 
			
		||||
class Saml2RelyingPartyPropertiesTests {
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -102,6 +103,13 @@ class Saml2RelyingPartyPropertiesTests {
 | 
			
		|||
			.getSignRequest()).isNull();
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	@Test
 | 
			
		||||
	void customizeNameIdFormat() {
 | 
			
		||||
		bind("spring.security.saml2.relyingparty.registration.simplesamlphp.name-id-format", "sampleNameIdFormat");
 | 
			
		||||
		assertThat(this.properties.getRegistration().get("simplesamlphp").getNameIdFormat())
 | 
			
		||||
			.isEqualTo("sampleNameIdFormat");
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	private void bind(String name, String value) {
 | 
			
		||||
		bind(Collections.singletonMap(name, value));
 | 
			
		||||
	}
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue