root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 15 Packages Projects Releases Wiki Activity

Remove unnecessary test for GraphQL Connection 

This commit removes an unnecessary test that checks for the pagination
and Connection support in Spring for GraphQL. After a change in
spring-projects/spring-graphql#707, we no longer can test this in
isolation, nor does it make sense to test this integration that
deeply.

See gh-35449
This commit is contained in:
Brian Clozel 2023-05-16 19:23:39 +02:00 committed by Andy Wilkinson
parent 705b2cd830
commit b26115711f
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/graphql/GraphQlAutoConfigurationTests.java
View File

@ -21,12 +21,9 @@ import java.nio.charset.StandardCharsets;
import graphql.GraphQL; import graphql.GraphQL;
import graphql.execution.instrumentation.ChainedInstrumentation; import graphql.execution.instrumentation.ChainedInstrumentation;
import graphql.execution.instrumentation.Instrumentation; import graphql.execution.instrumentation.Instrumentation;
import graphql.schema.FieldCoordinates;
import graphql.schema.GraphQLFieldDefinition;
import graphql.schema.GraphQLObjectType; import graphql.schema.GraphQLObjectType;
import graphql.schema.GraphQLOutputType; import graphql.schema.GraphQLOutputType;
import graphql.schema.GraphQLSchema; import graphql.schema.GraphQLSchema;
import graphql.schema.PropertyDataFetcher;
import graphql.schema.idl.RuntimeWiring; import graphql.schema.idl.RuntimeWiring;
import graphql.schema.visibility.DefaultGraphqlFieldVisibility; import graphql.schema.visibility.DefaultGraphqlFieldVisibility;
import graphql.schema.visibility.NoIntrospectionGraphqlFieldVisibility; import graphql.schema.visibility.NoIntrospectionGraphqlFieldVisibility;
@ -212,17 +209,6 @@ class GraphQlAutoConfigurationTests {
}); });
} }
@Test
void shouldContributeConnectionDataFetcher() {
this.contextRunner.withUserConfiguration(CustomGraphQlBuilderConfiguration.class).run((context) -> {
GraphQlSource graphQlSource = context.getBean(GraphQlSource.class);
GraphQLFieldDefinition books = graphQlSource.schema().getQueryType().getField("books");
FieldCoordinates booksCoordinates = FieldCoordinates.coordinates("Query", "books");
assertThat(graphQlSource.schema().getCodeRegistry().getDataFetcher(booksCoordinates, books))
.isNotInstanceOf(PropertyDataFetcher.class);
});
}
@Configuration(proxyBeanMethods = false) @Configuration(proxyBeanMethods = false)
static class CustomGraphQlBuilderConfiguration { static class CustomGraphQlBuilderConfiguration {