root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Guard instantiation of Tomcat's ErrorPage 

Closes gh-4839
This commit is contained in:
Stephane Nicoll 2015-12-28 14:35:35 +01:00
parent 12cefd2c2b
commit b94c7c6a1d
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
spring-boot/src/main/java/org/springframework/boot/context/embedded/tomcat/TomcatEmbeddedServletContainerFactory.java
View File

@ -599,6 +599,10 @@ public class TomcatEmbeddedServletContainerFactory
private static class TomcatErrorPage {
private static final String ERROR_PAGE_TOMCAT7 = "org.apache.catalina.deploy.ErrorPage";
private static final String ERROR_PAGE_TOMCAT = "org.apache.tomcat.util.descriptor.web.ErrorPage";
private final String location;
private final String exceptionType;
@ -617,14 +621,13 @@ public class TomcatEmbeddedServletContainerFactory
private Object createNativePage(ErrorPage errorPage) {
Object nativePage = null;
try {
if (ClassUtils.isPresent(
"org.apache.tomcat.util.descriptor.web.ErrorPage", null)) {
nativePage = new org.apache.tomcat.util.descriptor.web.ErrorPage();
}
else if (ClassUtils.isPresent("org.apache.catalina.deploy.ErrorPage",
null)) {
if (ClassUtils.isPresent(ERROR_PAGE_TOMCAT, null)) {
nativePage = BeanUtils.instantiate(ClassUtils
.forName("org.apache.catalina.deploy.ErrorPage", null));
.forName(ERROR_PAGE_TOMCAT, null));
}
else if (ClassUtils.isPresent(ERROR_PAGE_TOMCAT7, null)) {
nativePage = BeanUtils.instantiate(ClassUtils
.forName(ERROR_PAGE_TOMCAT7, null));
}
}
catch (ClassNotFoundException ex) {
@ -639,8 +642,7 @@ public class TomcatEmbeddedServletContainerFactory
public void addToContext(Context context) {
Assert.state(this.nativePage != null,
"Neither Tomcat 7 nor 8 detected so no native error page exists");
if (ClassUtils.isPresent("org.apache.tomcat.util.descriptor.web.ErrorPage",
null)) {
if (ClassUtils.isPresent(ERROR_PAGE_TOMCAT, null)) {
org.apache.tomcat.util.descriptor.web.ErrorPage errorPage = (org.apache.tomcat.util.descriptor.web.ErrorPage) this.nativePage;
errorPage.setLocation(this.location);
errorPage.setErrorCode(this.errorCode);