Merge pull request #46533 from academey
* pr/46533: Polish "Exclude spring-boot-devtools from AOT processing with Maven" Exclude spring-boot-devtools from AOT processing with Maven Closes gh-46533
This commit is contained in:
commit
bdbbcec6fa
|
@ -166,6 +166,17 @@ class AotTests {
|
|||
});
|
||||
}
|
||||
|
||||
@TestTemplate
|
||||
void whenAotRunsWithDevtoolsInClasspathItIsExcluded(MavenBuild mavenBuild) {
|
||||
mavenBuild.project("aot-exclude-devtools").goals("package").execute((project) -> {
|
||||
Path aotDirectory = project.toPath().resolve("target/spring-aot/main");
|
||||
assertThat(aotDirectory).exists();
|
||||
Path sourcesDirectory = aotDirectory.resolve("sources");
|
||||
assertThat(sourcesDirectory).exists();
|
||||
assertThat(collectRelativePaths(sourcesDirectory)).isNotEmpty();
|
||||
});
|
||||
}
|
||||
|
||||
@TestTemplate
|
||||
void whenAotTestRunsSourcesAndResourcesAreGenerated(MavenBuild mavenBuild) {
|
||||
mavenBuild.project("aot-test").goals("test").execute((project) -> {
|
||||
|
@ -180,6 +191,17 @@ class AotTests {
|
|||
});
|
||||
}
|
||||
|
||||
@TestTemplate
|
||||
void whenTestAotRunsWithDevtoolsInClasspathItIsExcluded(MavenBuild mavenBuild) {
|
||||
mavenBuild.project("aot-test-exclude-devtools").goals("process-test-classes").execute((project) -> {
|
||||
Path aotDirectory = project.toPath().resolve("target/spring-aot/test");
|
||||
assertThat(aotDirectory).exists();
|
||||
Path sourcesDirectory = aotDirectory.resolve("sources");
|
||||
assertThat(sourcesDirectory).exists();
|
||||
assertThat(collectRelativePaths(sourcesDirectory)).isNotEmpty();
|
||||
});
|
||||
}
|
||||
|
||||
List<Path> collectRelativePaths(Path sourceDirectory) {
|
||||
try (Stream<Path> pathStream = Files.walk(sourceDirectory)) {
|
||||
return pathStream.filter(Files::isRegularFile)
|
||||
|
|
|
@ -0,0 +1,42 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
|
||||
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
|
||||
<modelVersion>4.0.0</modelVersion>
|
||||
<groupId>org.springframework.boot.maven.it</groupId>
|
||||
<artifactId>aot-exclude-devtools</artifactId>
|
||||
<version>0.0.1.BUILD-SNAPSHOT</version>
|
||||
<properties>
|
||||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
|
||||
<maven.compiler.source>@java.version@</maven.compiler.source>
|
||||
<maven.compiler.target>@java.version@</maven.compiler.target>
|
||||
</properties>
|
||||
<build>
|
||||
<plugins>
|
||||
<plugin>
|
||||
<groupId>@project.groupId@</groupId>
|
||||
<artifactId>@project.artifactId@</artifactId>
|
||||
<version>@project.version@</version>
|
||||
<executions>
|
||||
<execution>
|
||||
<goals>
|
||||
<goal>process-aot</goal>
|
||||
</goals>
|
||||
</execution>
|
||||
</executions>
|
||||
</plugin>
|
||||
</plugins>
|
||||
</build>
|
||||
<dependencies>
|
||||
<dependency>
|
||||
<groupId>org.springframework.boot</groupId>
|
||||
<artifactId>spring-boot</artifactId>
|
||||
<version>@project.version@</version>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.springframework.boot</groupId>
|
||||
<artifactId>spring-boot-devtools</artifactId>
|
||||
<version>@project.version@</version>
|
||||
<optional>true</optional>
|
||||
</dependency>
|
||||
</dependencies>
|
||||
</project>
|
|
@ -0,0 +1,29 @@
|
|||
/*
|
||||
* Copyright 2012-present the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* https://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package org.test;
|
||||
|
||||
import org.springframework.boot.SpringApplication;
|
||||
import org.springframework.boot.autoconfigure.SpringBootApplication;
|
||||
|
||||
@SpringBootApplication
|
||||
public class SampleApplication {
|
||||
|
||||
public static void main(String[] args) {
|
||||
SpringApplication.run(SampleApplication.class, args);
|
||||
}
|
||||
|
||||
}
|
|
@ -0,0 +1,55 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
|
||||
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
|
||||
<modelVersion>4.0.0</modelVersion>
|
||||
<groupId>org.springframework.boot.maven.it</groupId>
|
||||
<artifactId>aot-test-exclude-devtools</artifactId>
|
||||
<version>0.0.1.BUILD-SNAPSHOT</version>
|
||||
<properties>
|
||||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
|
||||
<maven.compiler.source>@java.version@</maven.compiler.source>
|
||||
<maven.compiler.target>@java.version@</maven.compiler.target>
|
||||
</properties>
|
||||
<build>
|
||||
<plugins>
|
||||
<plugin>
|
||||
<groupId>@project.groupId@</groupId>
|
||||
<artifactId>@project.artifactId@</artifactId>
|
||||
<version>@project.version@</version>
|
||||
<executions>
|
||||
<execution>
|
||||
<goals>
|
||||
<goal>process-test-aot</goal>
|
||||
</goals>
|
||||
</execution>
|
||||
</executions>
|
||||
</plugin>
|
||||
</plugins>
|
||||
</build>
|
||||
<dependencies>
|
||||
<dependency>
|
||||
<groupId>org.springframework.boot</groupId>
|
||||
<artifactId>spring-boot</artifactId>
|
||||
<version>@project.version@</version>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.springframework.boot</groupId>
|
||||
<artifactId>spring-boot-devtools</artifactId>
|
||||
<version>@project.version@</version>
|
||||
<optional>true</optional>
|
||||
</dependency>
|
||||
|
||||
<dependency>
|
||||
<groupId>org.springframework.boot</groupId>
|
||||
<artifactId>spring-boot-test</artifactId>
|
||||
<version>@project.version@</version>
|
||||
<scope>test</scope>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>org.junit.jupiter</groupId>
|
||||
<artifactId>junit-jupiter</artifactId>
|
||||
<version>@junit-jupiter.version@</version>
|
||||
<scope>test</scope>
|
||||
</dependency>
|
||||
</dependencies>
|
||||
</project>
|
|
@ -0,0 +1,29 @@
|
|||
/*
|
||||
* Copyright 2012-present the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* https://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package org.test;
|
||||
|
||||
import org.springframework.boot.SpringApplication;
|
||||
import org.springframework.boot.autoconfigure.SpringBootApplication;
|
||||
|
||||
@SpringBootApplication
|
||||
public class SampleApplication {
|
||||
|
||||
public static void main(String[] args) {
|
||||
SpringApplication.run(SampleApplication.class, args);
|
||||
}
|
||||
|
||||
}
|
|
@ -0,0 +1,29 @@
|
|||
/*
|
||||
* Copyright 2012-present the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* https://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package org.test;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.springframework.boot.test.context.SpringBootTest;
|
||||
|
||||
@SpringBootTest
|
||||
class SampleApplicationTests {
|
||||
|
||||
@Test
|
||||
void contextLoads() {
|
||||
}
|
||||
|
||||
}
|
|
@ -130,7 +130,7 @@ public class ProcessAotMojo extends AbstractAotMojo {
|
|||
|
||||
private URL[] getClassPath() throws Exception {
|
||||
File[] directories = new File[] { this.classesDirectory, this.generatedClasses };
|
||||
return getClassPath(directories, new ExcludeTestScopeArtifactFilter());
|
||||
return getClassPath(directories, new ExcludeTestScopeArtifactFilter(), DEVTOOLS_EXCLUDE_FILTER);
|
||||
}
|
||||
|
||||
private RunArguments resolveArguments() {
|
||||
|
|
|
@ -154,7 +154,7 @@ public class ProcessTestAotMojo extends AbstractAotMojo {
|
|||
protected URL[] getClassPath(boolean includeJUnitPlatformLauncher) throws Exception {
|
||||
File[] directories = new File[] { this.testClassesDirectory, this.generatedTestClasses, this.classesDirectory,
|
||||
this.generatedClasses };
|
||||
URL[] classPath = getClassPath(directories);
|
||||
URL[] classPath = getClassPath(directories, DEVTOOLS_EXCLUDE_FILTER);
|
||||
if (!includeJUnitPlatformLauncher || this.project.getArtifactMap()
|
||||
.containsKey(JUNIT_PLATFORM_GROUP_ID + ":" + JUNIT_PLATFORM_LAUNCHER_ARTIFACT_ID)) {
|
||||
return classPath;
|
||||
|
|
|
@ -298,6 +298,12 @@ publishing.publications.withType(MavenPublication) {
|
|||
configuration {
|
||||
delegate.classesDirectory('${project.build.outputDirectory}')
|
||||
delegate.requiredVersion('22.3')
|
||||
exclusions {
|
||||
exclusion {
|
||||
delegate.groupId('org.springframework.boot')
|
||||
delegate.artifactId('spring-boot-devtools')
|
||||
}
|
||||
}
|
||||
}
|
||||
executions {
|
||||
execution {
|
||||
|
@ -342,6 +348,12 @@ publishing.publications.withType(MavenPublication) {
|
|||
configuration {
|
||||
delegate.classesDirectory('${project.build.outputDirectory}')
|
||||
delegate.requiredVersion('22.3')
|
||||
exclusions {
|
||||
exclusion {
|
||||
delegate.groupId('org.springframework.boot')
|
||||
delegate.artifactId('spring-boot-devtools')
|
||||
}
|
||||
}
|
||||
}
|
||||
executions {
|
||||
execution {
|
||||
|
|
Loading…
Reference in New Issue