From bb4a8cdc0e9942891169623f18a7985721fd0922 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edd=C3=BA=20Mel=C3=A9ndez?= Date: Sun, 10 Sep 2017 19:12:34 -0500 Subject: [PATCH 1/2] Provide dependency management for JUnit Jupiter Spring Framework 5 provides support for JUnit 5. This commit adds dependency management for JUnit 5 and an upgrade for spring-boot-sample-junit-jupiter sample. See gh-10240 --- spring-boot-dependencies/pom.xml | 17 +++++++++++++++++ .../spring-boot-sample-junit-jupiter/pom.xml | 18 ++++++++++-------- 2 files changed, 27 insertions(+), 8 deletions(-) diff --git a/spring-boot-dependencies/pom.xml b/spring-boot-dependencies/pom.xml index 476514eff3b..10f660c3574 100644 --- a/spring-boot-dependencies/pom.xml +++ b/spring-boot-dependencies/pom.xml @@ -124,6 +124,8 @@ 1.2 1.3.1 4.12 + 5.0.0 + 1.0.0 5.0.0.RC2 3.5.3 2.9.0 @@ -931,6 +933,21 @@ junit ${junit.version} + + org.junit.platform + junit-platform-launcher + ${junit.platform.version} + + + org.junit.jupiter + junit-jupiter-api + ${junit.jupiter.version} + + + org.junit.jupiter + junit-jupiter-engine + ${junit.jupiter.version} + mysql mysql-connector-java diff --git a/spring-boot-samples/spring-boot-sample-junit-jupiter/pom.xml b/spring-boot-samples/spring-boot-sample-junit-jupiter/pom.xml index 5c3a57bfe28..e20bbbe9058 100644 --- a/spring-boot-samples/spring-boot-sample-junit-jupiter/pom.xml +++ b/spring-boot-samples/spring-boot-sample-junit-jupiter/pom.xml @@ -19,8 +19,6 @@ ${basedir}/../.. - 5.0.0-M6 - 1.0.0-M6 @@ -40,10 +38,19 @@ + + org.junit.platform + junit-platform-launcher + test + org.junit.jupiter junit-jupiter-api - ${junit.jupiter.version} + test + + + org.junit.jupiter + junit-jupiter-engine test @@ -63,11 +70,6 @@ junit-platform-surefire-provider ${junit.platform.version} - - org.junit.jupiter - junit-jupiter-engine - ${junit.jupiter.version} - From 1dc08fdda2ec01ec00b40322fdff463a6478b849 Mon Sep 17 00:00:00 2001 From: Stephane Nicoll Date: Mon, 11 Sep 2017 20:21:21 +0200 Subject: [PATCH 2/2] Polish "Provide dependency management for JUnit Jupiter" Closes gh-10240 --- spring-boot-dependencies/pom.xml | 23 +++++++++++-------- .../spring-boot-sample-junit-jupiter/pom.xml | 2 +- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/spring-boot-dependencies/pom.xml b/spring-boot-dependencies/pom.xml index 10f660c3574..9e7a71f795c 100644 --- a/spring-boot-dependencies/pom.xml +++ b/spring-boot-dependencies/pom.xml @@ -124,8 +124,8 @@ 1.2 1.3.1 4.12 - 5.0.0 - 1.0.0 + 5.0.0 + 1.0.0 5.0.0.RC2 3.5.3 2.9.0 @@ -933,20 +933,25 @@ junit ${junit.version} - - org.junit.platform - junit-platform-launcher - ${junit.platform.version} - org.junit.jupiter junit-jupiter-api - ${junit.jupiter.version} + ${junit-jupiter.version} org.junit.jupiter junit-jupiter-engine - ${junit.jupiter.version} + ${junit-jupiter.version} + + + org.junit.platform + junit-platform-engine + ${junit-platform.version} + + + org.junit.platform + junit-platform-launcher + ${junit-platform.version} mysql diff --git a/spring-boot-samples/spring-boot-sample-junit-jupiter/pom.xml b/spring-boot-samples/spring-boot-sample-junit-jupiter/pom.xml index e20bbbe9058..77c84c3bd38 100644 --- a/spring-boot-samples/spring-boot-sample-junit-jupiter/pom.xml +++ b/spring-boot-samples/spring-boot-sample-junit-jupiter/pom.xml @@ -68,7 +68,7 @@ org.junit.platform junit-platform-surefire-provider - ${junit.platform.version} + ${junit-platform.version}