From c5088a3bd3c626449e96807a85e971f49cfc6e47 Mon Sep 17 00:00:00 2001 From: dreis2211 Date: Fri, 1 Oct 2021 11:28:23 +0200 Subject: [PATCH] Avoid explicit initialization of Atomics with their default values See gh-28162 --- .../metrics/web/client/MetricsRestTemplateCustomizerTests.java | 2 +- .../metrics/web/reactive/server/MetricsWebFilterTests.java | 2 +- .../actuate/metrics/web/servlet/FaultyWebMvcTagsProvider.java | 2 +- .../org/springframework/boot/SpringApplicationShutdownHook.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/client/MetricsRestTemplateCustomizerTests.java b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/client/MetricsRestTemplateCustomizerTests.java index 697f2a133a8..c833b0c99a6 100644 --- a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/client/MetricsRestTemplateCustomizerTests.java +++ b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/client/MetricsRestTemplateCustomizerTests.java @@ -157,7 +157,7 @@ class MetricsRestTemplateCustomizerTests { @Test void whenAutoTimingIsDisabledUriTemplateHandlerDoesNotCaptureUris() { - AtomicBoolean enabled = new AtomicBoolean(false); + AtomicBoolean enabled = new AtomicBoolean(); AutoTimer autoTimer = new AutoTimer() { @Override diff --git a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/reactive/server/MetricsWebFilterTests.java b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/reactive/server/MetricsWebFilterTests.java index c67954be72a..267279dcec9 100644 --- a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/reactive/server/MetricsWebFilterTests.java +++ b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/reactive/server/MetricsWebFilterTests.java @@ -260,7 +260,7 @@ class MetricsWebFilterTests { class FaultyWebFluxTagsProvider extends DefaultWebFluxTagsProvider { - private final AtomicBoolean fail = new AtomicBoolean(false); + private final AtomicBoolean fail = new AtomicBoolean(); FaultyWebFluxTagsProvider() { super(true); diff --git a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/FaultyWebMvcTagsProvider.java b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/FaultyWebMvcTagsProvider.java index 57701d27137..fab53800ed6 100644 --- a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/FaultyWebMvcTagsProvider.java +++ b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/web/servlet/FaultyWebMvcTagsProvider.java @@ -31,7 +31,7 @@ import io.micrometer.core.instrument.Tag; */ class FaultyWebMvcTagsProvider extends DefaultWebMvcTagsProvider { - private final AtomicBoolean fail = new AtomicBoolean(false); + private final AtomicBoolean fail = new AtomicBoolean(); FaultyWebMvcTagsProvider() { super(true); diff --git a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/SpringApplicationShutdownHook.java b/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/SpringApplicationShutdownHook.java index 128d0c6cfba..632688dd635 100644 --- a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/SpringApplicationShutdownHook.java +++ b/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/SpringApplicationShutdownHook.java @@ -60,7 +60,7 @@ class SpringApplicationShutdownHook implements Runnable { private final ApplicationContextClosedListener contextCloseListener = new ApplicationContextClosedListener(); - private final AtomicBoolean shutdownHookAdded = new AtomicBoolean(false); + private final AtomicBoolean shutdownHookAdded = new AtomicBoolean(); private boolean inProgress;