Polish "Retrieve javax.cache.CacheManager using Bean ClassLoader"

Closes gh-13338
This commit is contained in:
Stephane Nicoll 2018-06-04 14:08:41 +02:00
parent 76b9d0d243
commit c67aedd8bc
2 changed files with 16 additions and 6 deletions

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2012-2017 the original author or authors. * Copyright 2012-2018 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -88,6 +88,11 @@ class JCacheCacheConfiguration implements BeanClassLoaderAware {
this.cachePropertiesCustomizers = cachePropertiesCustomizers.getIfAvailable(); this.cachePropertiesCustomizers = cachePropertiesCustomizers.getIfAvailable();
} }
@Override
public void setBeanClassLoader(ClassLoader classLoader) {
this.beanClassLoader = classLoader;
}
@Bean @Bean
public JCacheCacheManager cacheManager(CacheManager jCacheCacheManager) { public JCacheCacheManager cacheManager(CacheManager jCacheCacheManager) {
JCacheCacheManager cacheManager = new JCacheCacheManager(jCacheCacheManager); JCacheCacheManager cacheManager = new JCacheCacheManager(jCacheCacheManager);
@ -154,11 +159,6 @@ class JCacheCacheConfiguration implements BeanClassLoaderAware {
} }
} }
@Override
public void setBeanClassLoader(ClassLoader classLoader) {
this.beanClassLoader = classLoader;
}
/** /**
* Determine if JCache is available. This either kicks in if a provider is available * Determine if JCache is available. This either kicks in if a provider is available
* as defined per {@link JCacheProviderAvailableCondition} or if a * as defined per {@link JCacheProviderAvailableCondition} or if a

View File

@ -374,6 +374,16 @@ public class CacheAutoConfigurationTests {
"spring.cache.jcache.config=" + configLocation); "spring.cache.jcache.config=" + configLocation);
} }
@Test
public void jCacheCacheUseBeanClassLoader() {
String cachingProviderFqn = MockCachingProvider.class.getName();
load(DefaultCacheConfiguration.class, "spring.cache.type=jcache",
"spring.cache.jcache.provider=" + cachingProviderFqn);
JCacheCacheManager cacheManager = validateCacheManager(JCacheCacheManager.class);
assertThat(cacheManager.getCacheManager().getClassLoader())
.isEqualTo(this.context.getClassLoader());
}
@Test @Test
public void ehcacheCacheWithCaches() { public void ehcacheCacheWithCaches() {
load(DefaultCacheConfiguration.class, "spring.cache.type=ehcache"); load(DefaultCacheConfiguration.class, "spring.cache.type=ehcache");