Polish

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/simple/SimpleProperties.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/info/Info.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/cache/CacheManagerCustomizers.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/reactive/PathRequest.java

@@ -20,7 +20,8 @@ import org.springframework.boot.autoconfigure.security.StaticResourceLocation;
 import org.springframework.security.web.server.util.matcher.ServerWebExchangeMatcher;
 
 /**
- * Factory that can be used to create a {@link ServerWebExchangeMatcher} for commonly used paths.
+ * Factory that can be used to create a {@link ServerWebExchangeMatcher} for commonly used
+ * paths.
  *
  * @author Madhura Bhave
  * @since 2.0.0
@@ -36,8 +37,7 @@ public final class PathRequest {
 	 * @return a {@link StaticResourceRequest}
 	 */
 	public static StaticResourceRequest toStaticResources() {
-		return StaticResourceRequest.get();
+		return StaticResourceRequest.INSTANCE;
 	}
 
 }
-

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/reactive/StaticResourceRequest.java

@@ -33,8 +33,8 @@ import org.springframework.util.Assert;
 import org.springframework.web.server.ServerWebExchange;
 
 /**
- * Used to create a {@link ServerWebExchangeMatcher} for static resources in
+ * Used to create a {@link ServerWebExchangeMatcher} for static resources in commonly used
- * commonly used locations. Returned by {@link PathRequest#toStaticResources()}.
+ * locations. Returned by {@link PathRequest#toStaticResources()}.
  *
  * @author Madhura Bhave
  * @since 2.0.0
@@ -42,7 +42,7 @@ import org.springframework.web.server.ServerWebExchange;
  */
 public final class StaticResourceRequest {
 
-	private static final StaticResourceRequest INSTANCE = new StaticResourceRequest();
+	static final StaticResourceRequest INSTANCE = new StaticResourceRequest();
 
 	private StaticResourceRequest() {
 	}
@@ -83,20 +83,11 @@ public final class StaticResourceRequest {
 	 * @param locations the locations to include
 	 * @return the configured {@link ServerWebExchangeMatcher}
 	 */
-	public StaticResourceServerWebExchange at(
+	public StaticResourceServerWebExchange at(Set<StaticResourceLocation> locations) {
-			Set<StaticResourceLocation> locations) {
 		Assert.notNull(locations, "Locations must not be null");
 		return new StaticResourceServerWebExchange(new LinkedHashSet<>(locations));
 	}
 
-	/**
-	 * Return the static resource request.
-	 * @return the static resource request
-	 */
-	static StaticResourceRequest get() {
-		return INSTANCE;
-	}
-
 	/**
 	 * The server web exchange matcher used to match against resource
 	 * {@link StaticResourceLocation Locations}.

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/servlet/PathRequest.java

@@ -42,11 +42,12 @@ public final class PathRequest {
 	 * @return a {@link StaticResourceRequest}
 	 */
 	public static StaticResourceRequest toStaticResources() {
-		return StaticResourceRequest.get();
+		return StaticResourceRequest.INSTANCE;
 	}
 
 	/**
-	 * Returns a matcher that includes the H2 console location. For example: <pre class="code">
+	 * Returns a matcher that includes the H2 console location. For example:
+	 * <pre class="code">
 	 * PathRequest.toH2Console()
 	 * </pre>
 	 * @return the configured {@link RequestMatcher}
@@ -73,7 +74,8 @@ public final class PathRequest {
 		}
 
 		@Override
-		protected boolean matches(HttpServletRequest request, H2ConsoleProperties context) {
+		protected boolean matches(HttpServletRequest request,
+				H2ConsoleProperties context) {
 			return this.delegate.matches(request);
 		}
 

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/servlet/StaticResourceRequest.java

@@ -34,8 +34,8 @@ import org.springframework.security.web.util.matcher.RequestMatcher;
 import org.springframework.util.Assert;
 
 /**
- * Used to create a {@link RequestMatcher} for static resources in
+ * Used to create a {@link RequestMatcher} for static resources in commonly used
- * commonly used locations. Returned by {@link PathRequest#toStaticResources()}.
+ * locations. Returned by {@link PathRequest#toStaticResources()}.
  *
  * @author Madhura Bhave
  * @author Phillip Webb
@@ -44,7 +44,7 @@ import org.springframework.util.Assert;
  */
 public final class StaticResourceRequest {
 
-	private static final StaticResourceRequest INSTANCE = new StaticResourceRequest();
+	static final StaticResourceRequest INSTANCE = new StaticResourceRequest();
 
 	private StaticResourceRequest() {
 	}
@@ -90,14 +90,6 @@ public final class StaticResourceRequest {
 		return new StaticResourceRequestMatcher(new LinkedHashSet<>(locations));
 	}
 
-	/**
-	 * Return the static resource request.
-	 * @return the static resource request
-	 */
-	static StaticResourceRequest get() {
-		return INSTANCE;
-	}
-
 	/**
 	 * The request matcher used to match against resource {@link StaticResourceLocation
 	 * Locations}.

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/transaction/TransactionManagerCustomizers.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/reactive/PathRequestTests.java

@@ -29,7 +29,8 @@ public class PathRequestTests {
 
 	@Test
 	public void toStaticResourcesShouldReturnStaticResourceRequest() {
-		assertThat(PathRequest.toStaticResources()).isInstanceOf(StaticResourceRequest.class);
+		assertThat(PathRequest.toStaticResources())
+				.isInstanceOf(StaticResourceRequest.class);
 	}
 
 }

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/reactive/StaticResourceRequestTests.java

@@ -44,7 +44,7 @@ import static org.mockito.Mockito.mock;
  */
 public class StaticResourceRequestTests {
 
-	private StaticResourceRequest resourceRequest = StaticResourceRequest.get();
+	private StaticResourceRequest resourceRequest = StaticResourceRequest.INSTANCE;
 
 	@Rule
 	public ExpectedException thrown = ExpectedException.none();

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/servlet/PathRequestTests.java

@@ -44,7 +44,8 @@ public class PathRequestTests {
 
 	@Test
 	public void toStaticResourcesShouldReturnStaticResourceRequest() {
-		assertThat(PathRequest.toStaticResources()).isInstanceOf(StaticResourceRequest.class);
+		assertThat(PathRequest.toStaticResources())
+				.isInstanceOf(StaticResourceRequest.class);
 	}
 
 	@Test

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/servlet/StaticResourceRequestTests.java

@@ -41,7 +41,7 @@ import static org.assertj.core.api.Assertions.assertThat;
  */
 public class StaticResourceRequestTests {
 
-	private StaticResourceRequest resourceRequest = StaticResourceRequest.get();
+	private StaticResourceRequest resourceRequest = StaticResourceRequest.INSTANCE;
 
 	@Rule
 	public ExpectedException thrown = ExpectedException.none();
@@ -92,8 +92,7 @@ public class StaticResourceRequestTests {
 	public void excludeFromSetWhenSetIsNullShouldThrowException() {
 		this.thrown.expect(IllegalArgumentException.class);
 		this.thrown.expectMessage("Locations must not be null");
-		this.resourceRequest.atCommonLocations()
+		this.resourceRequest.atCommonLocations().excluding(null);
-				.excluding(null);
 	}
 
 	private RequestMatcherAssert assertMatcher(RequestMatcher matcher) {

spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/DefaultCommandFactory.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/command/options/OptionHandler.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/compiler/AstUtils.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/compiler/GroovyCompiler.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/builder/SpringApplicationBuilder.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/util/LambdaSafe.java

@@ -81,7 +81,7 @@ public final class LambdaSafe {
 			Object... additionalArguments) {
 		Assert.notNull(callbackType, "CallbackType must not be null");
 		Assert.notNull(callbackInstances, "CallbackInstances must not be null");
-		return new Callbacks<C, A>(callbackType, callbackInstances, argument,
+		return new Callbacks<>(callbackType, callbackInstances, argument,
 				additionalArguments);
 	}
 
@@ -341,8 +341,7 @@ public final class LambdaSafe {
 	 */
 	public final static class InvocationResult<R> {
 
-		private static final InvocationResult<?> NONE = new InvocationResult<Object>(
+		private static final InvocationResult<?> NONE = new InvocationResult<>(null);
-				null);
 
 		private final R value;