Merge pull request #10469 from dreis2211:iterator-to-remove-if

* pr/10469:
  Replace some loops with removeIf()

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/http/HttpMessageConvertersTests.java

@@ -18,7 +18,6 @@ package org.springframework.boot.autoconfigure.http;
 
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Iterator;
 import java.util.List;
 
 import org.junit.Test;
@@ -114,13 +113,8 @@ public class HttpMessageConvertersTests {
 			@Override
 			protected List<HttpMessageConverter<?>> postProcessConverters(
 					List<HttpMessageConverter<?>> converters) {
-				for (Iterator<HttpMessageConverter<?>> iterator = converters
+				converters.removeIf(
-						.iterator(); iterator.hasNext();) {
+						converter -> converter instanceof MappingJackson2XmlHttpMessageConverter);
-					if (iterator
-							.next() instanceof MappingJackson2XmlHttpMessageConverter) {
-						iterator.remove();
-					}
-				}
 				return converters;
 			}
 		};
@@ -144,13 +138,8 @@ public class HttpMessageConvertersTests {
 			@Override
 			protected List<HttpMessageConverter<?>> postProcessPartConverters(
 					List<HttpMessageConverter<?>> converters) {
-				for (Iterator<HttpMessageConverter<?>> iterator = converters
+				converters.removeIf(
-						.iterator(); iterator.hasNext();) {
+						converter -> converter instanceof MappingJackson2XmlHttpMessageConverter);
-					if (iterator
-							.next() instanceof MappingJackson2XmlHttpMessageConverter) {
-						iterator.remove();
-					}
-				}
 				return converters;
 			}
 		};

spring-boot-test/src/main/java/org/springframework/boot/test/mock/mockito/MockitoPostProcessor.java

@@ -20,7 +20,6 @@ import java.beans.PropertyDescriptor;
 import java.lang.reflect.Field;
 import java.util.Arrays;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.LinkedHashMap;
 import java.util.LinkedHashSet;
 import java.util.Map;
@@ -280,11 +279,7 @@ public class MockitoPostProcessor extends InstantiationAwareBeanPostProcessorAda
 				beans.add(beanName);
 			}
 		}
-		for (Iterator<String> iterator = beans.iterator(); iterator.hasNext();) {
+		beans.removeIf(this::isScopedTarget);
-			if (isScopedTarget(iterator.next())) {
-				iterator.remove();
-			}
-		}
 		return beans.toArray(new String[beans.size()]);
 	}
 

spring-boot-test/src/main/java/org/springframework/boot/test/web/client/TestRestTemplate.java

@@ -22,7 +22,6 @@ import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashSet;
-import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -149,12 +148,8 @@ public class TestRestTemplate {
 			interceptors = Collections.emptyList();
 		}
 		interceptors = new ArrayList<>(interceptors);
-		Iterator<ClientHttpRequestInterceptor> iterator = interceptors.iterator();
+		interceptors.removeIf(
-		while (iterator.hasNext()) {
+				interceptor -> interceptor instanceof BasicAuthorizationInterceptor);
-			if (iterator.next() instanceof BasicAuthorizationInterceptor) {
-				iterator.remove();
-			}
-		}
 		interceptors.add(new BasicAuthorizationInterceptor(username, password));
 		restTemplate.setInterceptors(interceptors);
 	}

spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/metadata/ConfigurationMetadata.java

@@ -22,7 +22,6 @@ import java.util.Collections;
 import java.util.HashSet;
 import java.util.LinkedHashMap;
 import java.util.List;
-import java.util.ListIterator;
 import java.util.Map;
 import java.util.Set;
 
@@ -149,12 +148,7 @@ public class ConfigurationMetadata {
 		if (candidates == null || candidates.isEmpty()) {
 			return null;
 		}
-		ListIterator<ItemMetadata> it = candidates.listIterator();
+		candidates.removeIf(itemMetadata -> !itemMetadata.hasSameType(metadata));
-		while (it.hasNext()) {
-			if (!it.next().hasSameType(metadata)) {
-				it.remove();
-			}
-		}
 		if (candidates.size() == 1) {
 			return candidates.get(0);
 		}

spring-boot/src/main/java/org/springframework/boot/context/config/ConfigFileApplicationListener.java

@@ -20,7 +20,6 @@ import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
-import java.util.Iterator;
 import java.util.LinkedHashMap;
 import java.util.LinkedHashSet;
 import java.util.LinkedList;
@@ -530,12 +529,7 @@ public class ConfigFileApplicationListener
 		}
 
 		private void removeUnprocessedDefaultProfiles() {
-			for (Iterator<Profile> iterator = this.profiles.iterator(); iterator
+			this.profiles.removeIf(Profile::isDefaultProfile);
-					.hasNext();) {
-				if (iterator.next().isDefaultProfile()) {
-					iterator.remove();
-				}
-			}
 		}
 
 		private void addProfiles(Set<Profile> profiles) {