Detect JobRepository as depending on DB init
See gh-27221
This commit is contained in:
parent
b57edb942e
commit
cf69785393
|
@ -35,6 +35,7 @@ import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean
|
||||||
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
|
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
|
||||||
import org.springframework.boot.autoconfigure.orm.jpa.HibernateJpaAutoConfiguration;
|
import org.springframework.boot.autoconfigure.orm.jpa.HibernateJpaAutoConfiguration;
|
||||||
import org.springframework.boot.context.properties.EnableConfigurationProperties;
|
import org.springframework.boot.context.properties.EnableConfigurationProperties;
|
||||||
|
import org.springframework.boot.sql.init.dependency.DatabaseInitializationDependencyConfigurer;
|
||||||
import org.springframework.context.annotation.Bean;
|
import org.springframework.context.annotation.Bean;
|
||||||
import org.springframework.context.annotation.Configuration;
|
import org.springframework.context.annotation.Configuration;
|
||||||
import org.springframework.context.annotation.Import;
|
import org.springframework.context.annotation.Import;
|
||||||
|
@ -64,7 +65,7 @@ import org.springframework.util.StringUtils;
|
||||||
@AutoConfigureAfter(HibernateJpaAutoConfiguration.class)
|
@AutoConfigureAfter(HibernateJpaAutoConfiguration.class)
|
||||||
@ConditionalOnBean(JobLauncher.class)
|
@ConditionalOnBean(JobLauncher.class)
|
||||||
@EnableConfigurationProperties(BatchProperties.class)
|
@EnableConfigurationProperties(BatchProperties.class)
|
||||||
@Import(BatchConfigurerConfiguration.class)
|
@Import({ BatchConfigurerConfiguration.class, DatabaseInitializationDependencyConfigurer.class })
|
||||||
public class BatchAutoConfiguration {
|
public class BatchAutoConfiguration {
|
||||||
|
|
||||||
@Bean
|
@Bean
|
||||||
|
|
|
@ -0,0 +1,40 @@
|
||||||
|
/*
|
||||||
|
* Copyright 2021 the original author or authors.
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* https://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package org.springframework.boot.autoconfigure.batch;
|
||||||
|
|
||||||
|
import java.util.Collections;
|
||||||
|
import java.util.Set;
|
||||||
|
|
||||||
|
import org.springframework.batch.core.repository.JobRepository;
|
||||||
|
import org.springframework.boot.sql.init.dependency.AbstractBeansOfTypeDependsOnDatabaseInitializationDetector;
|
||||||
|
import org.springframework.boot.sql.init.dependency.DependsOnDatabaseInitializationDetector;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* {@link DependsOnDatabaseInitializationDetector} for Spring Batch's
|
||||||
|
* {@link JobRepository}.
|
||||||
|
*
|
||||||
|
* @author Henning Pöttker
|
||||||
|
*/
|
||||||
|
class JobRepositoryDependsOnDatabaseInitializationDetector
|
||||||
|
extends AbstractBeansOfTypeDependsOnDatabaseInitializationDetector {
|
||||||
|
|
||||||
|
@Override
|
||||||
|
protected Set<Class<?>> getDependsOnDatabaseInitializationBeanTypes() {
|
||||||
|
return Collections.singleton(JobRepository.class);
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
|
@ -176,3 +176,7 @@ org.springframework.boot.autoconfigure.web.servlet.JspTemplateAvailabilityProvid
|
||||||
# DataSource initializer detectors
|
# DataSource initializer detectors
|
||||||
org.springframework.boot.sql.init.dependency.DatabaseInitializerDetector=\
|
org.springframework.boot.sql.init.dependency.DatabaseInitializerDetector=\
|
||||||
org.springframework.boot.autoconfigure.flyway.FlywayMigrationInitializerDatabaseInitializerDetector
|
org.springframework.boot.autoconfigure.flyway.FlywayMigrationInitializerDatabaseInitializerDetector
|
||||||
|
|
||||||
|
# Depends on database initialization detectors
|
||||||
|
org.springframework.boot.sql.init.dependency.DependsOnDatabaseInitializationDetector=\
|
||||||
|
org.springframework.boot.autoconfigure.batch.JobRepositoryDependsOnDatabaseInitializationDetector
|
||||||
|
|
|
@ -41,6 +41,7 @@ import org.springframework.batch.core.repository.JobRepository;
|
||||||
import org.springframework.beans.factory.annotation.Autowired;
|
import org.springframework.beans.factory.annotation.Autowired;
|
||||||
import org.springframework.boot.CommandLineRunner;
|
import org.springframework.boot.CommandLineRunner;
|
||||||
import org.springframework.boot.DefaultApplicationArguments;
|
import org.springframework.boot.DefaultApplicationArguments;
|
||||||
|
import org.springframework.boot.LazyInitializationBeanFactoryPostProcessor;
|
||||||
import org.springframework.boot.autoconfigure.AutoConfigurations;
|
import org.springframework.boot.autoconfigure.AutoConfigurations;
|
||||||
import org.springframework.boot.autoconfigure.TestAutoConfigurationPackage;
|
import org.springframework.boot.autoconfigure.TestAutoConfigurationPackage;
|
||||||
import org.springframework.boot.autoconfigure.jdbc.EmbeddedDataSourceConfiguration;
|
import org.springframework.boot.autoconfigure.jdbc.EmbeddedDataSourceConfiguration;
|
||||||
|
@ -153,6 +154,21 @@ class BatchAutoConfigurationTests {
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void testDefinesAndLaunchesNamedJobWithLazyInitialization() {
|
||||||
|
this.contextRunner
|
||||||
|
.withUserConfiguration(NamedJobConfigurationWithRegisteredJob.class,
|
||||||
|
EmbeddedDataSourceConfiguration.class)
|
||||||
|
.withInitializer((context) -> context
|
||||||
|
.addBeanFactoryPostProcessor(new LazyInitializationBeanFactoryPostProcessor()))
|
||||||
|
.withPropertyValues("spring.batch.job.names:discreteRegisteredJob").run((context) -> {
|
||||||
|
assertThat(context).hasSingleBean(JobLauncher.class);
|
||||||
|
context.getBean(JobLauncherApplicationRunner.class).run();
|
||||||
|
assertThat(context.getBean(JobRepository.class).getLastJobExecution("discreteRegisteredJob",
|
||||||
|
new JobParameters())).isNotNull();
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
void testDefinesAndLaunchesLocalJob() {
|
void testDefinesAndLaunchesLocalJob() {
|
||||||
this.contextRunner
|
this.contextRunner
|
||||||
|
|
Loading…
Reference in New Issue