root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Reduce object creation in findMatchingItemMetadata() 

Closes gh-13473
This commit is contained in:
Johnny Lim 2018-06-15 05:29:19 +09:00 committed by Stephane Nicoll
parent 27bb4614a9
commit f34fb5f1ee
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/metadata/ConfigurationMetadata.java
View File

@ -145,10 +145,11 @@ public class ConfigurationMetadata {
} }
private ItemMetadata findMatchingItemMetadata(ItemMetadata metadata) { private ItemMetadata findMatchingItemMetadata(ItemMetadata metadata) {
List<ItemMetadata> candidates = getCandidates(metadata.getName()); List<ItemMetadata> candidates = this.items.get(metadata.getName());
if (candidates.isEmpty()) { if (candidates == null || candidates.isEmpty()) {
return null; return null;
} }
candidates = new ArrayList<>(candidates);
candidates.removeIf((itemMetadata) -> !itemMetadata.hasSameType(metadata)); candidates.removeIf((itemMetadata) -> !itemMetadata.hasSameType(metadata));
if (candidates.size() > 1 && metadata.getType() != null) { if (candidates.size() > 1 && metadata.getType() != null) {
candidates.removeIf( candidates.removeIf(
@ -165,11 +166,6 @@ public class ConfigurationMetadata {
return null; return null;
} }
private List<ItemMetadata> getCandidates(String name) {
List<ItemMetadata> candidates = this.items.get(name);
return (candidates != null ? new ArrayList<>(candidates) : new ArrayList<>());
}
private boolean nullSafeEquals(Object o1, Object o2) { private boolean nullSafeEquals(Object o1, Object o2) {
if (o1 == o2) { if (o1 == o2) {
return true; return true;