root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Merge branch '3.1.x' 

Closes gh-36635
This commit is contained in:
Andy Wilkinson 2023-07-28 12:22:48 +01:00
parent 0191943be2 65bc351847
commit f3d623bb1d
5 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/LoggerConfiguration.java
View File

@ -60,7 +60,7 @@ public final class LoggerConfiguration {
public LoggerConfiguration(String name, LevelConfiguration levelConfiguration, public LoggerConfiguration(String name, LevelConfiguration levelConfiguration,
LevelConfiguration inheritedLevelConfiguration) { LevelConfiguration inheritedLevelConfiguration) {
Assert.notNull(name, "Name must not be null"); Assert.notNull(name, "Name must not be null");
Assert.notNull(inheritedLevelConfiguration, "EffectiveLevelConfiguration must not be null"); Assert.notNull(inheritedLevelConfiguration, "InheritedLevelConfiguration must not be null");
this.name = name; this.name = name;
this.levelConfiguration = levelConfiguration; this.levelConfiguration = levelConfiguration;
this.inheritedLevelConfiguration = inheritedLevelConfiguration; this.inheritedLevelConfiguration = inheritedLevelConfiguration;
@ -140,15 +140,15 @@ public final class LoggerConfiguration {
} }
/** /**
* Supported logger configurations scopes. * Supported logger configuration scopes.
* *
* @since 2.7.13 * @since 2.7.13
*/ */
public enum ConfigurationScope { public enum ConfigurationScope {
/** /**
* Only return configuration that has been applied directly applied. Often * Only return configuration that has been applied directly. Often referred to as
* referred to as 'configured' or 'assigned' configuration. * 'configured' or 'assigned' configuration.
*/ */
DIRECT, DIRECT,

4
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/logging/LoggerConfigurationTests.java
View File

@ -53,10 +53,10 @@ class LoggerConfigurationTests {
} }
@Test @Test
void createWithLevelConfigurationWhenEffectiveLevelIsNullThrowsException() { void createWithLevelConfigurationWhenInheritedLevelConfigurationIsNullThrowsException() {
assertThatIllegalArgumentException() assertThatIllegalArgumentException()
.isThrownBy(() -> new LoggerConfiguration("test", null, (LevelConfiguration) null)) .isThrownBy(() -> new LoggerConfiguration("test", null, (LevelConfiguration) null))
.withMessage("EffectiveLevelConfiguration must not be null"); .withMessage("InheritedLevelConfiguration must not be null");
} }
@Test @Test

4
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/logging/java/JavaLoggingSystemTests.java
View File

@ -166,7 +166,7 @@ class JavaLoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfigurations() { void getLoggerConfigurations() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
this.loggingSystem.initialize(null, null, null); this.loggingSystem.initialize(null, null, null);
this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG); this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG);
@ -176,7 +176,7 @@ class JavaLoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfiguration() { void getLoggerConfiguration() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
this.loggingSystem.initialize(null, null, null); this.loggingSystem.initialize(null, null, null);
this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG); this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG);

16
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/logging/log4j2/Log4J2LoggingSystemTests.java
View File

@ -206,7 +206,7 @@ class Log4J2LoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfigurations() { void getLoggerConfigurations() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
this.loggingSystem.initialize(this.initializationContext, null, null); this.loggingSystem.initialize(this.initializationContext, null, null);
this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG); this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG);
@ -216,7 +216,7 @@ class Log4J2LoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfigurationsShouldReturnAllLoggers() { void getLoggerConfigurationsShouldReturnAllLoggers() {
LogManager.getLogger("org.springframework.boot.logging.log4j2.Log4J2LoggingSystemTests$Nested"); LogManager.getLogger("org.springframework.boot.logging.log4j2.Log4J2LoggingSystemTests$Nested");
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
this.loggingSystem.initialize(this.initializationContext, null, null); this.loggingSystem.initialize(this.initializationContext, null, null);
@ -233,7 +233,7 @@ class Log4J2LoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test // gh-35227 @Test // gh-35227
void getLoggingConfigurationsWhenHasCustomLevel() { void getLoggerConfigurationWhenHasCustomLevel() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
this.loggingSystem.initialize(this.initializationContext, null, null); this.loggingSystem.initialize(this.initializationContext, null, null);
LoggerContext loggerContext = (LoggerContext) LogManager.getContext(false); LoggerContext loggerContext = (LoggerContext) LogManager.getContext(false);
@ -250,7 +250,7 @@ class Log4J2LoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfiguration() { void getLoggerConfiguration() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
this.loggingSystem.initialize(this.initializationContext, null, null); this.loggingSystem.initialize(this.initializationContext, null, null);
this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG); this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG);
@ -260,7 +260,7 @@ class Log4J2LoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfigurationShouldReturnLoggerWithNullConfiguredLevel() { void getLoggerConfigurationShouldReturnLoggerWithNullConfiguredLevel() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
this.loggingSystem.initialize(this.initializationContext, null, null); this.loggingSystem.initialize(this.initializationContext, null, null);
this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG); this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG);
@ -269,7 +269,7 @@ class Log4J2LoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfigurationForNonExistentLoggerShouldReturnNull() { void getLoggerConfigurationForNonExistentLoggerShouldReturnNull() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
this.loggingSystem.initialize(this.initializationContext, null, null); this.loggingSystem.initialize(this.initializationContext, null, null);
this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG); this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG);
@ -404,7 +404,7 @@ class Log4J2LoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfigurationWithResetLevelReturnsNull() { void getLoggerConfigurationWithResetLevelReturnsNull() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
this.loggingSystem.initialize(this.initializationContext, null, null); this.loggingSystem.initialize(this.initializationContext, null, null);
this.loggingSystem.setLogLevel("com.example", LogLevel.WARN); this.loggingSystem.setLogLevel("com.example", LogLevel.WARN);
@ -418,7 +418,7 @@ class Log4J2LoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfigurationWithResetLevelWhenAlreadyConfiguredReturnsParentConfiguredLevel() { void getLoggerConfigurationWithResetLevelWhenAlreadyConfiguredReturnsParentConfiguredLevel() {
LoggerContext loggerContext = (LoggerContext) LogManager.getContext(false); LoggerContext loggerContext = (LoggerContext) LogManager.getContext(false);
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
this.loggingSystem.initialize(this.initializationContext, null, null); this.loggingSystem.initialize(this.initializationContext, null, null);

8
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/logging/logback/LogbackLoggingSystemTests.java
View File

@ -239,7 +239,7 @@ class LogbackLoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfigurations() { void getLoggerConfigurations() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
initialize(this.initializationContext, null, null); initialize(this.initializationContext, null, null);
this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG); this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG);
@ -249,7 +249,7 @@ class LogbackLoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfiguration() { void getLoggerConfiguration() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
initialize(this.initializationContext, null, null); initialize(this.initializationContext, null, null);
this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG); this.loggingSystem.setLogLevel(getClass().getName(), LogLevel.DEBUG);
@ -259,7 +259,7 @@ class LogbackLoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfigurationForLoggerThatDoesNotExistShouldReturnNull() { void getLoggerConfigurationForLoggerThatDoesNotExistShouldReturnNull() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
initialize(this.initializationContext, null, null); initialize(this.initializationContext, null, null);
LoggerConfiguration configuration = this.loggingSystem.getLoggerConfiguration("doesnotexist"); LoggerConfiguration configuration = this.loggingSystem.getLoggerConfiguration("doesnotexist");
@ -267,7 +267,7 @@ class LogbackLoggingSystemTests extends AbstractLoggingSystemTests {
} }
@Test @Test
void getLoggingConfigurationForALL() { void getLoggerConfigurationForALL() {
this.loggingSystem.beforeInitialize(); this.loggingSystem.beforeInitialize();
initialize(this.initializationContext, null, null); initialize(this.initializationContext, null, null);
Logger logger = (Logger) LoggerFactory.getILoggerFactory().getLogger(getClass().getName()); Logger logger = (Logger) LoggerFactory.getILoggerFactory().getLogger(getClass().getName());