Stephane Nicoll
fed145e195
Replace manual dependency management by Kotlin's bom
...
Closes gh-9486
2019-03-11 17:44:27 +01:00
Andy Wilkinson
aa2008bc5a
Merge branch '2.1.x'
2019-03-11 16:40:19 +00:00
Andy Wilkinson
f0ef693376
Merge branch '2.0.x' into 2.1.x
2019-03-11 16:28:29 +00:00
Andy Wilkinson
c2eeeb032c
Work around javac bug
2019-03-11 16:27:56 +00:00
Stephane Nicoll
09d51089ba
Polish
2019-03-11 17:24:52 +01:00
Stephane Nicoll
fd0a11b7a7
Reuse Kotlin parameter names if possible
...
This commit detects a Kotlin constructor so that it is not required to
transmit the parameter names information to the Java side.
See gh-8762
2019-03-11 17:23:45 +01:00
Andy Wilkinson
8c3cec8f13
Merge branch '2.0.x' into 2.1.x
2019-03-11 16:14:19 +00:00
Andy Wilkinson
361437f4e2
Merge branch '1.5.x' into 2.0.x
2019-03-11 15:53:34 +00:00
Stephane Nicoll
b34b217d1e
Upgrade to Kotlin 1.3.21
...
Closes gh-16195
2019-03-11 15:56:13 +01:00
Stephane Nicoll
341859b5fe
Start building against Spring Framework 5.2 snapshots
...
See gh-16173
2019-03-11 15:22:14 +01:00
Stephane Nicoll
c30f9815c1
Fix detection of Autowired constructor with Kotlin
...
Previously, the import selector wrongly assumed that we should not
use constructor injection with Kotlin. Rather than looking up for the
primary constructor, we retrieve available constructors on the Java
counter-part.
This commit applies the same logic as in the constructor parameter
binder and checks for the primary constructor for Kotlin types.
See gh-8762
2019-03-11 10:19:25 +01:00
Andy Wilkinson
7675802338
Merge branch '2.1.x'
2019-03-11 08:32:03 +00:00
Andy Wilkinson
f574213cc8
Mark log file endpoint as producing text/plain
...
Closes gh-16188
2019-03-11 08:30:31 +00:00
Andy Wilkinson
7d0317419d
Polish
2019-03-10 12:42:09 +00:00
Andy Wilkinson
89bb973745
Merge branch '2.1.x'
2019-03-09 20:02:05 +00:00
Andy Wilkinson
7153525ee2
Annotation @JsonTest with @ExtendWith(SpringExtension.class)
...
Closes gh-16183
2019-03-09 20:00:06 +00:00
Stephane Nicoll
d07a6ff0bb
Fix binding of bean with no bean definition
...
See gh-16180
2019-03-09 20:49:47 +01:00
Andy Wilkinson
f5eb853f26
Update web starter to depend on validator starter
...
Previously, the web starter declared direct dependencies on Hibernate Validator
and the Jakarta EE validation API. This meant that it required two exclusions to
exclude validation from a web application that did not need it.
This commit updates the web starter to get its validation dependencies via a
dependency on the validation starter. This allows validation to be excluded
using a single exclusion. The EL dependency from the validation starter has
been excluded to allow the EL implementation from the underlying container
starter (Tomcat, Jetty, or Undertow) to continue to be used instead.
Closes gh-16176
2019-03-08 17:54:03 +00:00
Stephane Nicoll
430571b37b
Perform binding at creation time if possible
...
Previously, environment binding always happened in a post processor once
the bean has been created. Constructor binding requires to perform the
binding at creating time so this commit performs binding at creation
time if possible.
When this happens, a special `ConfigurationPropertiesBeanDefinition` is
created with a supplier that invokes the binder. To avoid a case where
a bean is processed twice, the post-processor now ignores any bean that
has already been bound to the environment.
Closes gh-8762
Co-authored-by: Madhura Bhave <mbhave@pivotal.io>
2019-03-08 15:50:44 +01:00
Madhura Bhave
7ca589d43c
Add constructor based binding support
...
See gh-8762
Co-authored-by: Stephane Nicoll <snicoll@pivotal.io>
2019-03-08 15:50:44 +01:00
Andy Wilkinson
2bd3d19bee
Ensure that DevTools' beans use eager init even when app is lazy
...
Closes gh-15870
2019-03-08 10:05:40 +00:00
Andy Wilkinson
1431a0f585
Upgrade to Spring Data Moore-M2
...
Closes gh-15197
2019-03-08 08:21:06 +00:00
Brian Clozel
8325fce53e
Fix formatting
2019-03-07 21:02:41 +01:00
Brian Clozel
6586bae889
Guard Endpoint bean declarations with ConditionalOnExposedEndpoint
...
This commit adds the newly introduced `@ConditionalOnExposedEndpoint`
conditional annotation to all auto-configured `Endpoint` in Actuator.
With that change, `EndPoint` instances and related infrastructure will
only be created when they are meant to be exposed and used. This will
save CPU and memory resources when Actuator is present.
Closes gh-16093
2019-03-07 20:13:44 +01:00
Brian Clozel
4ffbe6c9e8
Add @ConditionalOnExposedEndpoint condition
...
Prior to this commit, Actuator `Endpoint` instantiations would be
guarded by `@ConditionalOnEnabledEnpoint` condition annotations. This
feature saves resources as disabled endpoints aren't unnecessarily
instantiated.
By default, only `"health"` and `"info"` endpoints are exposed over the
web and all endpoints are exposed over JMX.
As of gh-16090, JMX is now disabled by default. This is an opportunity
to avoid instantiating endpoints if they won't be exposed at all, which
is more likely due to the exposure defaults.
This commit adds a new `@ConditionalOnExposedEndpoint` conditional
annotation that checks the `Environment` for configuration properties
under `"management.endpoints.web.exposure.*"` and
`"management.endpoints.jmx.exposure.*"`. In the case of JMX, an
additional check is perfomed, checking that JMX is enabled first.
The rules implemented in the condition itself are following the ones
described in `ExposeExcludePropertyEndpointFilter`.
See gh-16093
2019-03-07 20:05:23 +01:00
Andy Wilkinson
b8dff5fe17
Merge branch '2.1.x'
2019-03-07 10:20:29 +00:00
Andy Wilkinson
9d06d22b99
Merge branch '2.0.x' into 2.1.x
2019-03-07 10:17:01 +00:00
Andy Wilkinson
affdbeef41
Polish
2019-03-07 10:08:39 +00:00
Andy Wilkinson
e1a7f1e085
Upgrade to Cassandra Driver 3.7.1
...
Closes gh-16163
2019-03-07 09:44:30 +00:00
Andy Wilkinson
c4756e9057
Merge branch '2.1.x'
2019-03-07 09:43:16 +00:00
Andy Wilkinson
f46894dfd3
Merge branch '2.0.x' into 2.1.x
2019-03-07 09:43:02 +00:00
Andy Wilkinson
17a1b2822c
Isolate LoggerContext state to each test
...
Closes gh-16162
2019-03-07 09:37:41 +00:00
Andy Wilkinson
3f3966adb0
Merge branch '2.1.x'
2019-03-07 09:25:45 +00:00
Andy Wilkinson
9963ed1249
Merge branch '2.0.x' into 2.1.x
2019-03-07 09:25:31 +00:00
Andy Wilkinson
83216c34e5
Merge branch '1.5.x' into 2.0.x
2019-03-07 09:25:17 +00:00
Andy Wilkinson
7c58d72734
Upgrade to Mongo Driver Reactivestreams 1.11.0
...
Closes gh-16159
2019-03-06 19:51:03 +00:00
Andy Wilkinson
36cbd00853
Disable AssertJ's bare-named property accessor discovery
...
AssertJ includes a change in 3.12 that means that, by default, it now incorrectly
identifies some of the builder methods on CacheControl as accessor methods for its fields.
This commit restores the behaviour of 3.11 so that a method is only considered to be a
property accessor if a matches the Java bean naming conventions.
Closes gh-16145
2019-03-06 19:42:38 +00:00
Andy Wilkinson
e667911f91
Merge branch '2.1.x'
2019-03-06 15:11:28 +00:00
Andy Wilkinson
80f2e2260e
Merge branch '2.0.x' into 2.1.x
2019-03-06 15:11:09 +00:00
Andy Wilkinson
e56580ddc6
Merge branch '1.5.x' into 2.0.x
2019-03-06 15:10:25 +00:00
Andy Wilkinson
87d696d697
Align with breaking API change in AssertJ 3.12
...
Closes gh-16145
2019-03-06 14:38:17 +00:00
Andy Wilkinson
c2e9f98655
Upgrade to Spring Plugin 2.0.0.M1
...
Closes gh-15940
2019-03-06 13:40:34 +00:00
Andy Wilkinson
7c568bb277
Upgrade to Spring HATEOAS 1.0.0.M1
...
Closes gh-15939
2019-03-06 13:40:04 +00:00
Andy Wilkinson
c6811d6427
Upgrade to Maven Javadoc Plugin 3.1.0
...
Closes gh-16157
2019-03-06 13:38:48 +00:00
Andy Wilkinson
12c1271bcb
Upgrade to Maven Invoker Plugin 3.2.0
...
Closes gh-16156
2019-03-06 13:38:46 +00:00
Andy Wilkinson
970f9abc9c
Upgrade to Snakeyaml 1.24
...
Closes gh-16155
2019-03-06 13:38:45 +00:00
Andy Wilkinson
85f42df77f
Upgrade to Webjars Locator Core 0.37
...
Closes gh-16154
2019-03-06 13:38:44 +00:00
Andy Wilkinson
3635885058
Upgrade to Selenium Htmlunit 2.34.0
...
Closes gh-16153
2019-03-06 13:38:43 +00:00
Andy Wilkinson
44bc3b0f7a
Upgrade to Mongodb 3.10.1
...
Closes gh-16152
2019-03-06 13:38:42 +00:00
Andy Wilkinson
cd68579851
Upgrade to Mockito 2.25.0
...
Closes gh-16151
2019-03-06 13:38:41 +00:00
Andy Wilkinson
22ef0285bd
Upgrade to Mariadb 2.4.0
...
Closes gh-16150
2019-03-06 13:38:40 +00:00
Andy Wilkinson
12e9160fff
Upgrade to Junit Jupiter 5.4.0
...
Closes gh-16149
2019-03-06 13:38:39 +00:00
Andy Wilkinson
d4d0db017e
Upgrade to Influxdb Java 2.15
...
Closes gh-16148
2019-03-06 13:38:38 +00:00
Andy Wilkinson
614931755c
Upgrade to Elasticsearch 6.6.1
...
Closes gh-16147
2019-03-06 13:38:37 +00:00
Andy Wilkinson
52a934faae
Upgrade to Ehcache3 3.7.0
...
Closes gh-16146
2019-03-06 13:38:36 +00:00
Andy Wilkinson
ad8f2fb409
Upgrade to Assertj 3.12.1
...
Closes gh-16145
2019-03-06 13:38:35 +00:00
Andy Wilkinson
419a1bd5b3
Upgrade to Kafka 2.1.1
...
Closes gh-16144
2019-03-06 13:38:33 +00:00
Andy Wilkinson
708551e9d5
Upgrade to Commons Dbcp2 2.6.0
...
Closes gh-16143
2019-03-06 13:38:32 +00:00
Andy Wilkinson
a491fd3d05
Upgrade to Htmlunit 2.34.1
...
Closes gh-16142
2019-03-06 13:38:31 +00:00
Andy Wilkinson
4fff84c65c
Upgrade to Rest Assured 3.3.0
...
Closes gh-16141
2019-03-06 13:38:30 +00:00
Andy Wilkinson
10c90a8845
Upgrade to Rxjava2 2.2.7
...
Closes gh-16140
2019-03-06 13:38:29 +00:00
Andy Wilkinson
d8e94f2b6e
Upgrade to Commons Codec 1.12
...
Closes gh-16139
2019-03-06 13:38:28 +00:00
Andy Wilkinson
35a2dc0133
Upgrade to Hikaricp 3.3.1
...
Closes gh-16138
2019-03-06 13:38:27 +00:00
Andy Wilkinson
2609e27f5f
Upgrade to Rabbit Amqp Client 5.6.0
...
Closes gh-16137
2019-03-06 13:38:26 +00:00
Andy Wilkinson
236cae5727
Upgrade to Hazelcast Hibernate5 1.3.2
...
Closes gh-16136
2019-03-06 13:38:25 +00:00
Andy Wilkinson
cd7eed92a9
Upgrade to Caffeine 2.7.0
...
Closes gh-16135
2019-03-06 13:38:24 +00:00
Andy Wilkinson
eaf055382b
Merge branch '2.1.x'
2019-03-06 13:35:31 +00:00
Andy Wilkinson
a09713ee30
Upgrade to Infinispan 9.4.8.Final
...
Closes gh-16134
2019-03-06 13:34:02 +00:00
Andy Wilkinson
de042114af
Upgrade to Jetty Reactive Httpclient 1.0.3
...
Closes gh-16133
2019-03-06 13:34:00 +00:00
Andy Wilkinson
c54ac68afa
Upgrade to Undertow 2.0.19.Final
...
Closes gh-16132
2019-03-06 13:33:59 +00:00
Andy Wilkinson
33fdc5b471
Upgrade to Rxjava2 2.2.7
...
Closes gh-16131
2019-03-06 13:33:58 +00:00
Andy Wilkinson
2568bd6a83
Upgrade to Netty Tcnative 2.0.22.Final
...
Closes gh-16130
2019-03-06 13:33:57 +00:00
Andy Wilkinson
4f5eff6fa4
Upgrade to Lettuce 5.1.5.RELEASE
...
Closes gh-16129
2019-03-06 13:33:56 +00:00
Andy Wilkinson
e01b76aa45
Upgrade to Hazelcast 3.11.2
...
Closes gh-16128
2019-03-06 13:33:56 +00:00
Andy Wilkinson
ff64e112c9
Merge branch '2.0.x' into 2.1.x
2019-03-06 13:33:00 +00:00
Andy Wilkinson
4cfc532890
Upgrade to Spring Ws 3.0.7.RELEASE
...
Closes gh-16127
2019-03-06 13:30:51 +00:00
Andy Wilkinson
51657e1ad0
Upgrade to Spring Integration 5.0.12.RELEASE
...
Closes gh-16126
2019-03-06 13:30:49 +00:00
Andy Wilkinson
ab05a07807
Upgrade to Neo4j Ogm 3.1.8
...
Closes gh-16125
2019-03-06 13:30:48 +00:00
Andy Wilkinson
7a26a092aa
Upgrade to Hibernate Validator 6.0.15.Final
...
Closes gh-16124
2019-03-06 13:30:46 +00:00
Andy Wilkinson
31892a3488
Upgrade to Elasticsearch 5.6.15
...
Closes gh-16123
2019-03-06 13:30:45 +00:00
Andy Wilkinson
5f35a1d089
Merge branch '1.5.x' into 2.0.x
2019-03-06 13:30:09 +00:00
Andy Wilkinson
acdbd18a7b
Merge branch '2.1.x'
2019-03-06 13:24:33 +00:00
Andy Wilkinson
31ed042190
Return 503 when component or instance is down with WebFlux
...
Closes gh-16109
2019-03-06 13:24:23 +00:00
Andy Wilkinson
0959698c32
Upgrade to Jersey 2.28
...
Closes gh-16114
2019-03-06 12:58:35 +00:00
Andy Wilkinson
d6a869fa98
Switch to Jakarta EE API dependencies where possible
...
Closes gh-16113
Closes gh-16112
Closes gh-16111
Closes gh-15916
Closes gh-15689
2019-03-06 11:20:51 +00:00
Brian Clozel
ce9626d00f
Disable JMX by default
...
This commit switches the default value for the `spring.jmx.enabled`
configuration property.
JMX is now disabled by default and can be enabled with
`spring.jmx.enabled=true`.
Closes gh-16090
2019-03-05 18:51:00 +01:00
Stephane Nicoll
4f029d6df9
Polish "Add loadOnStartup property to EndpointServlet"
...
Closes gh-16053
2019-03-05 10:59:18 +01:00
Gómez Díaz, Julio José
b99c05329f
Add loadOnStartup property to EndpointServlet
...
loadOnStartup property was missing from EndpointServlet and cannot be set
inside ServletEndpointRegistrar. Now it can be set and register a Servlet
with that integer property ready to act upon registration.
See gh-16053
2019-03-05 10:34:55 +01:00
Johnny Lim
4a738e3c49
Polish
...
Closes gh-16094
2019-03-05 08:19:29 +01:00
Stephane Nicoll
d83a614bd9
Merge branch '2.1.x'
2019-03-05 08:18:41 +01:00
Stephane Nicoll
8d033e73d1
Polish
...
See gh-16094
2019-03-05 08:18:14 +01:00
Andy Wilkinson
19851c98c9
Merge branch '2.1.x'
2019-03-04 15:21:16 +00:00
Andy Wilkinson
bdab9c4e31
Upgrade to Couchbase Client 2.7.4
...
Closes gh-15914
2019-03-04 15:21:09 +00:00
Stephane Nicoll
6b273279fb
Merge branch '2.1.x'
2019-03-04 15:58:35 +01:00
Stephane Nicoll
4eb73e0050
Recommend that DevTools is excluded with custom packaging arrangement
...
Closes gh-15382
2019-03-04 15:57:47 +01:00
Stephane Nicoll
4f2e788835
Fix import in docs
...
Closes gh-16017
2019-03-04 15:45:59 +01:00
Johnny Lim
f4786d7d2e
Polish
...
Closes gh-16083
2019-03-04 15:19:57 +01:00
Stephane Nicoll
1b55f0ccf9
Merge branch '2.1.x'
2019-03-04 15:19:35 +01:00
Johnny Lim
3242e89271
Polish
...
See gh-16083
2019-03-04 15:18:51 +01:00
Stephane Nicoll
3febf56e93
Merge branch '2.1.x'
2019-03-04 15:13:05 +01:00
Johnny Lim
907058d845
Rename Maven version property for PooledJMS
...
Closes gh-16086
2019-03-04 15:12:28 +01:00
Stephane Nicoll
f90bfff132
Merge branch '2.1.x'
2019-03-04 15:00:21 +01:00
Stephane Nicoll
2099093978
Merge branch '2.0.x' into 2.1.x
2019-03-04 15:00:00 +01:00
Stephane Nicoll
b8cbd0c17f
Merge branch '1.5.x' into 2.0.x
2019-03-04 14:55:10 +01:00
Stephane Nicoll
75c248dcba
Move setter attribute in PropertyDescriptor proper
2019-03-04 10:53:13 +01:00
Stephane Nicoll
a90c8d01a9
Polish
2019-03-04 10:53:08 +01:00
Stephane Nicoll
7b8563a877
Merge branch '2.1.x'
2019-03-04 09:29:13 +01:00
Stephane Nicoll
235fbfb4b6
Polish "Use AssertJ facilities for expected exceptions"
...
Closes gh-16066
2019-03-04 08:58:28 +01:00
dreis2211
be445f6346
Use AssertJ facilities for expected exceptions
...
See gh-16066
2019-03-04 08:45:42 +01:00
Madhura Bhave
64b7466d51
Remove secure flag from AutoConfigureMockMvc
...
Closes gh-13822
2019-02-28 13:15:00 -08:00
Stephane Nicoll
baa5a00d26
Merge branch '2.1.x'
2019-02-28 14:58:41 +01:00
Stephane Nicoll
c224eebef3
Polish "Fix NullPointerException with empty X-Forwarded-For header"
...
Closes gh-16046
2019-02-28 14:56:42 +01:00
Dmytro Nosan
64a74c3bbb
Fix NullPointerException with empty X-Forwarded-For header
...
See gh-16046
2019-02-28 14:51:25 +01:00
Stephane Nicoll
3bcd93bd35
Merge branch '2.1.x'
2019-02-28 14:44:27 +01:00
Stephane Nicoll
2a6791aa20
Polish "Add `jaxb-runtime` to TldSkipPatterns"
...
Closes gh-16027
2019-02-28 14:39:52 +01:00
Rupert Madden-Abbott
946ada62fb
Add `jaxb-runtime` to TldSkipPatterns
...
See gh-16027
2019-02-28 14:37:45 +01:00
Dmytro Nosan
c0a458e9d0
Remove unused constructor argument
...
Closes gh-16059
2019-02-28 14:09:34 +01:00
Stephane Nicoll
d5448eb124
Polish "Add failure analyzer for Flyway's bootstrap failure"
...
Closes gh-16015
2019-02-28 13:46:04 +01:00
anand
96315372ef
Add failure analyzer for Flyway's bootstrap failure
...
See gh-16015
2019-02-28 13:46:04 +01:00
Stephane Nicoll
2ad234b605
Adapt to breaking change in Spring Hateoas
2019-02-28 13:42:27 +01:00
Stephane Nicoll
ad6e58e489
Merge branch '2.1.x'
2019-02-28 09:37:30 +01:00
XYUU
7aedb0a33d
Fix a colon format
...
Closes gh-16054
2019-02-28 09:36:22 +01:00
Stephane Nicoll
c8e46f66e2
Merge branch '2.1.x'
2019-02-27 16:04:45 +01:00
Stephane Nicoll
ce17a923dd
Polish contribution
...
Closes gh-15978
2019-02-27 16:03:28 +01:00
Dmytro Nosan
cf89ebcf92
Add an example showing how to use Spring REST Docs with WebTestClient
...
See gh-15978
2019-02-27 16:03:15 +01:00
Stephane Nicoll
554bff6145
Merge branch '2.1.x'
2019-02-27 15:19:37 +01:00
Stephane Nicoll
eebd906c8a
Polish contribution
...
Closes gh-16047
2019-02-27 15:10:43 +01:00
Dan Zheng
2c4afb3bd8
Fix NamedParameterJdbcTemplate precedence with database migration tools
...
See gh-16047
2019-02-27 15:10:20 +01:00
Stephane Nicoll
7beb64043d
Fix build failure
2019-02-27 13:55:28 +01:00
Stephane Nicoll
7f817e339b
Merge branch '2.1.x'
2019-02-27 13:45:26 +01:00
Stephane Nicoll
978f80122b
Polish "Debug mode is not logging web and sql related loggers"
...
Closes gh-16018
2019-02-27 13:37:18 +01:00
Dmytro Nosan
c3430d5883
Debug mode is not logging web and sql related loggers
...
See gh-16018
2019-02-27 13:25:08 +01:00
Stephane Nicoll
715db153e3
Polish "Remove code deprecated in 2.1"
...
Closes gh-16013
2019-02-27 11:15:48 +01:00
Mehmed Baždar
246111cd84
Remove code deprecated in 2.1
...
See gh-16013
2019-02-27 10:08:48 +01:00
Stephane Nicoll
5e4418973e
Merge branch '2.1.x'
2019-02-26 16:59:32 +01:00
Stephane Nicoll
c47edd15af
Polish "Update instructions on how to use JAXB as XML renderer"
...
Closes gh-16005
2019-02-26 16:57:47 +01:00
Lars Grefer
221ff8d69f
Update instructions on how to use JAXB as XML renderer
...
See gh-16005
2019-02-26 16:50:30 +01:00
dreis2211
2ab4ce03db
Fix deprecations
...
Closes gh-16037
2019-02-26 16:49:13 +01:00
Stephane Nicoll
00a18c32ab
Restructure metadata generation
...
This commit restructures the annotation processor to off-load most of
its logic in a PropertyDescriptor abstraction that is consumed to
generate the relevant metadata.
This has the benefit to isolate the various way properties can be
identified (java bean and lombok for now).
Closes gh-16036
2019-02-26 10:10:33 +01:00
Stephane Nicoll
99c0b4561d
Polish test to request the type under test
2019-02-23 09:30:15 +01:00
Stephane Nicoll
c44a1e129d
Polish
2019-02-22 14:04:37 +01:00
Stephane Nicoll
8a064b0da2
Move main test annotation processor to test package
2019-02-22 14:04:29 +01:00
Stephane Nicoll
4bee913fb2
Add shared test processor
...
This commit adds a simple annotation processor that can be used to run
more fine grained assertions.
2019-02-22 14:04:22 +01:00
Madhura Bhave
adea7014a9
Add support to detect Kubernetes platform in CloudPlatform
...
Closes gh-15537
2019-02-21 15:27:23 -08:00
Andy Wilkinson
0f0adb4cd0
Polish formatting
2019-02-21 22:04:56 +00:00
Stephane Nicoll
7b0004d6c3
Fix formatting
2019-02-21 14:17:34 +01:00
Stephane Nicoll
8773a2fed3
Polish
2019-02-21 11:37:11 +01:00
Andy Wilkinson
f2e3e274a8
Merge branch '2.1.x'
2019-02-21 08:19:43 +00:00
Andy Wilkinson
53326695ea
Polish
2019-02-21 08:13:54 +00:00
Madhura Bhave
6f045d8891
Merge branch '2.1.x'
2019-02-20 16:13:20 -08:00