Commit Graph

1993 Commits

Author SHA1 Message Date
Spring Buildmaster b04710d744 Next development version 2019-01-11 15:59:00 +00:00
Andy Wilkinson aa9945c86c Upgrade to Jetty 9.4.14.v20181114
Closes gh-15239
2018-12-20 09:54:44 +00:00
Spring Buildmaster 9bb64a3493 Next Development Version 2018-11-29 09:52:39 +00:00
Andy Wilkinson 1d3a066f52 Polish 2018-11-23 20:15:13 +00:00
Andy Wilkinson 291522a261 Avoid duplicate scope registration
Closes gh-14990
2018-11-23 16:55:43 +00:00
Phillip Webb b60da5f85d Allow early ServletRequest Autowiring
Update `EmbeddedWebApplicationContext` so that Servlet related
resolvable dependencies are registered in `postProcessBeanFactory`.

This allows a `ServletReqest` to be autowired into an early initialized
bean and brings parity with WAR based deployments.

Closes gh-14990
2018-11-14 18:15:21 -08:00
Spring Buildmaster 4d24feb443 Next development version 2018-10-16 08:44:44 +00:00
Andy Wilkinson 8124ac2b79 Upgrade to Undertow 1.4.26.Final
Closes gh-13880
2018-10-10 12:58:09 +01:00
Andy Wilkinson 52361e6400 Honour SSL key and trust store providers when configuring Undertow
Closes gh-14713
2018-10-08 12:10:23 +01:00
Andy Wilkinson 5c1d22eed8 Polish "Clarify that RestTemplateBuilder overwrites default converters"
Closes gh-13714
2018-10-01 15:37:31 +01:00
Welton Rodrigo Torres Nascimento 3dbeff56e4 Clarify that RestTemplateBuilder overwrites default converters
See gh-13714
2018-10-01 15:37:12 +01:00
DevOrc 7daade21c4 Support escaped characters in BasicJsonParser
This commit adds the ability to have escaped characters, like the quote,
when using the BasicJsonParser. It also adds a short test for escaped
quotes.

Closes gh-14521
2018-09-20 10:24:24 +02:00
Spring Buildmaster 46df506b0a Next development version 2018-09-11 14:24:40 +00:00
Phillip Webb 9543fcf44d Upgrade to spring-javaformat 0.0.6 2018-08-30 15:59:27 -07:00
Phillip Webb 17de1571f5 Update copyright year 2018-08-30 15:52:58 -07:00
Phillip Webb a085541d26 Polish 2018-08-30 15:52:58 -07:00
Andy Wilkinson 37bd286985 Perform failure analysis of NoSuchMethodErrors
Closes gh-14040
2018-08-10 12:35:08 +01:00
Stephane Nicoll b6dddcced8 Include @ in javadoc links for annotations
See gh-13988
2018-08-03 09:35:30 +02:00
Spring Buildmaster 73bf744cb0 Next Development Version 2018-07-30 13:37:38 +00:00
Andy Wilkinson 56cb968b62 Make Jetty Server fail when its WebAppContext fails to start
Closes gh-13803
2018-07-18 11:10:48 +01:00
Andy Wilkinson 57ebdab2ab Delay property source initialization till LoggingSystem is initialized
Previously, the initialization of StandardServletEnvironment's
property sources in SpringBootServletInitializer led to debug logging
calls being made before the LoggingSystem had been initialized. As a
result, the system's default configuration was used and, in the case
of Logback at least, the debug logging was output to System.out
in a war deployment.

This commit updates SpringBootServletInitializer to delay the
initialization of StandardServletEnvironment's property sources until
after the LoggingSystem has been initialized, but still in time for
active profiles to be configured via servlet context parameters
(see gh-9972).

Closes gh-13736
2018-07-11 11:47:17 +01:00
Andy Wilkinson 8a0f0354df Disable Log4J2's shutdown hook by default
Log4J2 enables its shutdown hook by default. When the JVM is exiting,
this creates a race between logging that happens during the
application context being closed and Log4J2 being shut down such that
the logging is lost.

This commit updates SpringBootConfigurationFactory so that it
produces a custom sub-class of DefaultConfiguration that disables the
shutdown hook by default. In addition to solving the problem described
above, this also aligns the Log4J2 logging system with the
logging.register-shutdown-hook property which defaults to false.

Closes gh-11360
2018-06-21 11:35:20 +01:00
Andy Wilkinson 9f7106c778 Polish 2018-06-20 18:56:14 +01:00
Andy Wilkinson 6cc0968b8d Polish 2018-06-20 16:52:18 +01:00
Phillip Webb 2bb7a430cf Clean up access logging threads when Undertow is stopped
Closes gh-12742
2018-06-20 14:15:21 +01:00
Andy Wilkinson 92f62043d4 Fix placeholder support in <springProfile>'s name attribute
Closes gh-13450
2018-06-20 10:48:55 +01:00
Spring Buildmaster 36b8639853 Next Development Version 2018-06-14 10:05:31 +00:00
Phillip Webb 6c7289b822 Allow META-INF/resources in WAR classes folder
Update `TomcatResources` so that `META-INF/resources` folders in
`src/main/resources` no longer fail with a "URI is not hierarchical"
exception.

Closes gh-13265
2018-06-05 17:00:52 -07:00
Phillip Webb 5243adce22 Restore Java 1.6 compatibility 2018-05-30 18:23:17 -07:00
Phillip Webb 00b76490dc Remove error logging on ClientAbortException
Update `ErrorPageFilter` so that a Tomcat `ClientAbortException` no
longer causes "Cannot forward to error page for request" logging for
committed responses. Since a `ClientAbortException` indicates that the
client is no longer available it's of no consequence that the request
has been committed and the forward will fail.

Closes gh-13221
2018-05-30 14:00:55 -07:00
Phillip Webb 43071b9375 Polish formatting 2018-05-30 13:34:15 -07:00
Andy Wilkinson 64158ebaf5 Reinstate use of ConversionService for String -> File conversion
Prior to 3db5c70b, RelaxedDataBinder would use a ConversionService
to convert a String into a File via its ObjectToObjectConverter.
3db5c70b changed the configuration of the data binder such that a
FileEditor was registered. Property editors take precedence over any
conversion service so the FileEditor was used instead. This caused a
regression as the FileEditor uses slightly unusual logic for a String
to File conversion. Specifically, when given a value of ".", it will
locate a ClassPathResource for the root of the classpath and use the
result of calling getFile() on that resource. This fails when the
root of the classpath is in a jar file and also provides a different
result when the root of the classpath is not the current directory.

This commit updates RelaxedDataBinder to suppress the registration
of an editor for File. This restores the behaviour prior to 3db5c70b
by allowing the ConversionService to be used instead.

Closes gh-12786
2018-05-17 11:38:48 +01:00
Andy Wilkinson 339fd74810 Call ServletContextListener.contextDestroyed() when Undertow is stopped
Previously, when the embedded Undertow container was stopped, the
servlet deployment was stopped but it was not undeployed. This meant
that contextDestroyed() callback of any registered
ServletContextListeners was not called.

This commit updates UndertowEmbeddedServletContainer to call undeploy
on the deployment manager in addition to the existing call to stop.
Undeploying the servlet deployment calls Undertow to drive the
contextDestroyed callback on any registered ServletContextListeners.

Closes gh-13134
2018-05-14 19:56:08 +01:00
Andy Wilkinson 1fc2eba98b Polish "Suppress debug log output during Logback initialization"
See gh-12071
2018-05-14 18:01:12 +01:00
imgx64 8f44bb9d42 Suppress debug log output during Logback initialization
Closes gh-12071
2018-05-14 17:57:12 +01:00
Andy Wilkinson a9645a3d07 Polish 2018-05-11 13:29:04 +01:00
Andy Wilkinson 678e125720 Polish "Unwrap InvocationTargetException in isLogConfigurationMessage"
Closes gh-12958
2018-05-11 11:51:18 +01:00
Henri Tremblay 2953ed1dca Unwrap InvocationTargetException in isLogConfigurationMessage
See gh-12958
2018-05-11 11:51:02 +01:00
Andy Wilkinson c8b3cea200 Clarify that registration bean URL patterns use Servlet spec format
Closes gh-13080
2018-05-10 15:45:16 +01:00
Spring Buildmaster 010b4fccbd Next development version 2018-05-09 09:31:46 +00:00
Phillip Webb 99dad81e9a Update copyright header year for changed files 2018-05-04 12:15:13 -07:00
Phillip Webb 0a0247975c Formatting 2018-05-04 12:00:50 -07:00
Andy Wilkinson bea353962c Align Undertow tests with changes made to fix UNDERTOW-1260
Closes gh-13055
2018-05-04 13:45:01 +01:00
Phillip Webb 4e96587dc8 Polish modifier declaration ordering
Follow that Java language specification.
2018-05-03 09:46:15 -07:00
Phillip Webb 64930d4e5b Polish caught exception names
Prefer `ex` over `e`.
2018-05-03 09:46:15 -07:00
Phillip Webb 3ee777e142 Polish ternary expressions
Consistently format ternary expressions and always favor `!=` as the
the check.
2018-05-03 09:46:15 -07:00
Andy Wilkinson 06cf698387 Polish 2018-05-02 12:12:47 +01:00
Andy Wilkinson a29a70d2f4 Fix handling of static resource jar paths containing a +
Closes gh-12942
2018-05-02 10:23:42 +01:00
Andy Wilkinson c78bc0585c Make tests' detection of SSL handshake failures more robust
Closes gh-12961
2018-04-25 11:47:36 +01:00
Spring Buildmaster c10aad165f Next Development Version 2018-04-09 23:14:33 +00:00