Commit Graph

205 Commits

Author SHA1 Message Date
igor-suhorukov e2d05607f2 Fix modifiers order
See gh-11681
2018-01-19 11:30:06 +01:00
Johnny Lim 9d24186942 Use this() in EndpointRequests
Closes gh-11690
2018-01-19 11:15:42 +01:00
Phillip Webb 0b81f78a2a Revert "Create CloudFoundry-specific EndpointWebExtension"
This reverts commit 7189f426ed.
2018-01-18 23:21:51 -08:00
Phillip Webb f3379668ac Polish 2018-01-18 23:21:51 -08:00
Stephane Nicoll 8704cf1fe7 Harmonize metric property names
See gh-11667
2018-01-18 17:21:40 +01:00
Stephane Nicoll 6086bc714f Fix json structure 2018-01-18 17:04:37 +01:00
Stephane Nicoll 7002507304 Polish 2018-01-18 16:34:56 +01:00
Stephane Nicoll beaa49a2d6 Polish "Add auto-configuration for RabbitMQ metrics"
Closes gh-10887
2018-01-18 16:16:26 +01:00
Arnaud Cogoluègnes 58c8c4d56a Add auto-configuration for RabbitMQ metrics
See gh-10887
2018-01-18 16:11:50 +01:00
Stephane Nicoll 5cb6c086b6 Rename micrometer instrumentation flags
Closes gh-11667
2018-01-18 14:16:40 +01:00
Andy Wilkinson 849baa4c02 Do not require after in audit events endpoint
Closes gh-11605
2018-01-18 11:59:46 +00:00
Andy Wilkinson 54c0cf513b Polish 2018-01-17 19:03:23 +00:00
Andy Wilkinson 3cf1fb6763 Polish formatting in Actuator API documentation 2018-01-16 20:46:42 +00:00
Andy Wilkinson 67a299020b Rework mappings endpoint
Improve the structure of the response and include mappings from
WebFlux and Servlet and Filter registrations in addition to the
mappings from Spring MVC.

Closes gh-9979
2018-01-16 18:26:59 +00:00
Andy Wilkinson 5b8a2f9675 Improve context hierarchy handling in Actuator endpoints
Previously, a number of Actuator endpoints ignored a context hierarchy
or assumed that it would always be linear. This commit reworks the
affected endpoints so that the no longer assume a linear hierarchy.

A side-effect of a non-linear hierarchy is that there may be multiple
different beans with the same name (in a linear hierarchy, a bean
with the same name as one in an ancestor context, replaces that bean).
The affected endpoints have also been updated so that, when bean names
are used as keys, those keys are grouped by application context. This
prevents a bean in one context from accidentially overwriting a bean
in another context.

Closes gh-11019
2018-01-16 09:53:52 +00:00
Andy Wilkinson 23d8d608c4 Polish 2018-01-15 13:35:46 +00:00
Andy Wilkinson 2b99962a85 Replace use of Date with OffsetDateTime and Instant in Actuator
Closes gh-10976
2018-01-12 17:26:05 +00:00
Stephane Nicoll ae3cd75d1a Polish "Upgrade to Micrometer 1.0.0-rc.6"
Closes gh-11598
2018-01-11 18:35:31 +01:00
Jon Schneider ccc820f723 Upgrade to Micrometer 1.0.0-rc.6
See gh-11598
2018-01-11 18:35:31 +01:00
Brian Clozel 69d5b7a4e8 Add missing header expectations in tests
Fixes gh-11318
2018-01-11 14:44:50 +01:00
Stephane Nicoll 7189f426ed Create CloudFoundry-specific EndpointWebExtension
Closes gh-11428
2018-01-11 11:23:20 +01:00
Brian Clozel d264af8142 Apply server.tomcat.* config to reactive servers
This commit applies most `server.tomcat.*` configuration
properties to Tomcat when set up as a reactive web server.

Some Servlet-specific properties are not applied:

* server.tomcat.additional-tld-skip-patterns
* server.tomcat.redirect-context-root
* server.tomcat.use-relative-redirects

Fixes gh-11334
2018-01-11 11:15:02 +01:00
Madhura Bhave e57aafd63d Provide EndpointRequest for WebFlux-based Security
Closes gh-11022
2018-01-09 16:06:36 -08:00
Madhura Bhave fa8bca41f8 Fix javadoc 2018-01-09 14:47:32 -08:00
Madhura Bhave 8fedc29ed7 Update copyright year of changed files 2018-01-09 14:45:43 -08:00
Madhura Bhave 3d30c62162 Fix package tangle in cloudfoundry configuration
Fixes gh-11273
2018-01-09 14:42:28 -08:00
Phillip Webb b078698f20 Update copyright year of changed files 2018-01-09 12:13:27 -08:00
Johnny Lim 0f0c6e0729 Polish
Closes gh-11536
2018-01-09 09:28:56 +01:00
Phillip Webb cae02ce0b8 Make WebMvcMetricsFilter lazy
Update `WebMvcMetricsFilter` so that it no longer causes early
initialization of Spring MVC concerns.

Fixes gh-11571
2018-01-08 15:19:06 -08:00
Phillip Webb 25609c060e Polish 2018-01-08 15:19:06 -08:00
Stephane Nicoll ac004eabf3 Update copyright header
See gh-11510
2018-01-05 10:30:43 +01:00
Johnny Lim 37d8eedae3 Polish
Closes gh-11510
2018-01-05 10:29:22 +01:00
Phillip Webb bee5fa7fc6 Polish 2018-01-03 13:24:04 -08:00
Phillip Webb 6bac365a72 Polish micrometer cache metrics
Change `CacheMeterBinderProvider` to include a cache type
generic which helps to simplify implementations. Also move
and extract a few classes.

See gh-11221
2018-01-03 13:19:31 -08:00
Stephane Nicoll 0515ca0dd0 Auto configure micrometer cache metrics
Closes gh-11221
2018-01-03 15:22:08 +01:00
Johnny Lim 24b5a78e39 Polish
Closes gh-11448
2017-12-30 17:21:13 +01:00
Madhura Bhave 8102dc78cb Remove redundant throws declarations 2017-12-29 12:10:13 -08:00
Johnny Lim 8ae2be6043 Fix property names in MeterBindersConfiguration
Closes gh-11443
2017-12-29 14:36:56 +01:00
Madhura Bhave c29fe05708 Remove redundant property from tests 2017-12-28 12:45:51 -08:00
Stephane Nicoll 8d1bd7eb3c Polish 2017-12-28 14:57:49 +01:00
Stephane Nicoll 81af02fde7 Improve JVM metrics
This commit adds GC and thread jvm metrics to the existing memory
metrics. All three are now managed by a unique
management.metrics.binders.jvm.enabled property.

Closes gh-11425
2017-12-28 14:57:13 +01:00
Stephane Nicoll f0d94a46fd Polish 2017-12-28 12:09:27 +01:00
Stephane Nicoll afba8fed79 Harmonize management.server.context-path property
This commit moves management.server.context-path to
management.server.servlet.context-path to align with the configuration
key for the application's main context path.

Closes gh-11359
2017-12-28 12:08:51 +01:00
Stephane Nicoll 2738147947 Polish "Move CorsEndpointProperties to the parent package"
Closes gh-11439
2017-12-28 11:01:14 +01:00
Johnny Lim 8383b76138 Move CorsEndpointProperties to the parent package
`CorsEndpointProperties` lives in `endpoint.web.servlet` but is also used
in `endpoint.web.reactive`, so this PR moves it to its common parent
package.

This commit also extracts `CorsConfiguration` creation logic duplicated
in `WebMvcEndpointManagementContextConfiguration` and
`WebFluxEndpointManagementContextConfiguration` into
`CorsEndpointProperties`.

See gh-11439
2017-12-28 10:40:51 +01:00
Johnny Lim 3c5ccb1166 Polish
Closes gh-11418
2017-12-26 09:47:10 +01:00
Johnny Lim b35348b41d Remove org.flywaydb.core.internal.util.StringUtils import
Closes  gh-11396
2017-12-24 12:20:03 +01:00
Johnny Lim 3a276d2a87 Rename CloudFoundryHealthWebEndpointManagementContextConfiguration
Closes gh-11400
2017-12-23 14:23:24 +01:00
Johnny Lim 240aaadd83 Fix package name for InfluxDB
Closes gh-11364
2017-12-23 13:27:58 +01:00
Eddú Meléndez cc9b2a9786 Fix property key to enable influxdb health endpoint
Closes gh-11365
2017-12-23 12:51:24 +01:00
Phillip Webb 6cb331ed2c Cache endpoint enabled-by-default result
Update `OnEnabledEndpointCondition` so that the result of
`management.endpoints.enabled-by-default` is cached between calls.

Fixes gh-11407
2017-12-22 20:52:07 -08:00
Phillip Webb befdbaaaa9 Polish 2017-12-15 14:57:25 -08:00
Stephane Nicoll 2ed162a0be Fix outdated references to server.context-path
Closes gh-11358
2017-12-15 10:24:14 +01:00
Stephane Nicoll a33c3eec3f Polish "Add InfluxDb health indicator"
Closes gh-11159
2017-12-14 15:16:00 +01:00
Eddú Meléndez cdbdc1cb7f Add InfluxDb health indicator
See gh-11159
2017-12-14 15:15:08 +01:00
Stephane Nicoll ef78cb33b3 Move metrics properties to "management.metrics"
Closes gh-11340
2017-12-14 12:27:24 +01:00
Stephane Nicoll de8fe7550f Polish 2017-12-14 12:16:22 +01:00
Stephane Nicoll 41720ca93d Improve extension of Neo4jHealthIndicator
This commit makes it easier to extend `Neo4jHealthIndicator` for cases
where a custom cypher needs to be executed.

Closes gh-11120
2017-12-14 10:01:57 +01:00
Phillip Webb 3273859fde Polish 2017-12-13 14:32:55 -08:00
Stephane Nicoll 681fdb1ee8 Property detect Health web extension with management context
Previously, the Health web extension was defined in the management
context and, as a result, it wasn't found when a separate port was
required. The side effect is that anything that the health web extension
does was not active anymore in that case.

This commit makes sure that the extension is always defined as part of
the main context where operations are discovered and merged.

Closes gh-11285
2017-12-13 17:47:18 +01:00
Johnny Lim de72f2ae32 Polish
Closes gh-11327
2017-12-13 09:38:20 +01:00
Brian Clozel 175f451b0f Polish 2017-12-12 16:41:44 +01:00
Alessandro Ciccimarra e1def637ae Apply configurers on MeterRegistry before injection
MeterRegistryConfigurers are now applied within the Bean method
creating the CompositeMeterRegistry, instead of applying them
later in its lifecycle, when the bean itself could have been
injected somewhere.

Fixes gh-11319
2017-12-12 16:03:37 +01:00
Stephane Nicoll 23218add90 Polish 2017-12-12 11:57:30 +01:00
Brian Clozel 5f3c2bef50 Add CORS support to Actuator WebFlux
Closes gh-11308
2017-12-11 22:33:51 +01:00
Stephane Nicoll 5ef9364085 Polish 2017-12-11 17:55:12 +01:00
Johnny Lim 384819ab5f Add @Configuration to ScheduledTasksEndpointAutoConfiguration
Closes gh-11313
2017-12-11 17:46:16 +01:00
Johnny Lim 6d54072e04 Remove "final" keywords
Closes gh-11294
2017-12-08 11:13:07 -08:00
Andy Wilkinson c0e3ae9042 Polish 2017-12-07 18:27:52 +00:00
Johnny Lim d33c6773da Use volatile for ReactiveTokenValidator.cacheTokenKeys
Closes gh-11233
2017-12-06 15:10:01 +00:00
Johnny Lim ada4d13a4e Document spring.metrics.binders.*
Closes gh-11262
2017-12-05 15:57:46 -08:00
Stephane Nicoll a4913712cb Do not expose the composite ReactiveHealthIndicator as a bean
Previously, a `ReactiveHealthIndicator` bean was exposed to define the
health indicator to use for the reactive endpoint. Having it exposed as
a bean has the side effect that the regular `HealthIndicator` composite
is picked up and a "reactive" entry is added to the health details.

This commit creates such indicator internally as it should be.

Closes gh-11222
2017-12-02 08:29:07 +01:00
Stephane Nicoll 5dc28ec446 Merge branch '1.5.x' 2017-11-30 18:01:36 +01:00
Johnny Lim 44299bb980 Polish
Closes gh-11206
2017-11-29 09:37:36 -08:00
Johnny Lim 952224ef56 Polish
Closes gh-11193
2017-11-29 10:50:42 +01:00
Phillip Webb 2c959b8e2a Polish health indicators
Align reactive and non-reactive web extensions and update `showDetails`
so that it only applies to web exposure.

See gh-11113
See gh-11192
2017-11-28 21:19:53 -08:00
Madhura Bhave 9e95483645 Add cloudfoundry health extensions
Fixes gh-11192
2017-11-28 18:49:17 -08:00
Phillip Webb e1306c6228 Polish micrometer rc.5 upgrade
Closes gh-11071
2017-11-28 16:58:53 -08:00
Jon Schneider 2e0a915281 Upgrade to micrometer 1.0.0-rc.5
See gh-11071
2017-11-28 16:58:53 -08:00
Phillip Webb 960083bd33 Polish 2017-11-28 16:21:09 -08:00
Madhura Bhave 2319d01feb Prevent race condition in ReactiveTokenValidator 2017-11-28 14:24:22 -08:00
Andy Wilkinson 22a426fe39 Polish 2017-11-28 10:50:28 +00:00
Madhura Bhave 9f76832488 Optimize fetching tokenKeys for reactive actuators
Closes gh-10899
2017-11-27 12:32:21 -08:00
Johnny Lim 70d92037bd Use BeanIds.SPRING_SECURITY_FILTER_CHAIN
See gh-11162
2017-11-27 10:31:32 +01:00
Stephane Nicoll 480039f212 Fix default value of management.endpoints.web.expose 2017-11-24 15:22:57 +01:00
Stephane Nicoll a12bab453c Polish "Fix PropertiesConfigAdapter delegation logic"
Closes gh-11135
2017-11-24 13:48:06 +01:00
Nikolay Rybak 9163d65b0e Fix PropertiesConfigAdapter delegation logic
This change replaces fallback logic in PropertiesConfigAdapter and its
descendants such that instead of falling back to default "empty" config
it delegates to superinterface default implementation of the same class.

This allows default implementation to call back to other properties,
like DatadogConfig.uri() does.

See gh-11135
2017-11-24 13:31:00 +01:00
Stephane Nicoll 45e8c237de Polish 2017-11-24 11:16:46 +01:00
Johnny Lim 01a48412d2 Polish
Closes gh-11126
2017-11-23 16:00:55 +00:00
Stephane Nicoll 97bb70cd0c Polish 2017-11-23 16:28:00 +01:00
Stephane Nicoll 3a6a238ea9 Improve error metadata for Actuator 2017-11-23 15:59:51 +01:00
Vedran Pavic 63aef58d30 Fix references to management related properties
See gh-11091
2017-11-23 10:48:37 +01:00
Phillip Webb 07f71e889e Move `/application` to `/actuator`
Change the endpoint default path from `/application` to `/actuator`.

Fixes gh-10970
2017-11-22 23:18:22 -08:00
Phillip Webb 3e2ede51d6 Delete `status` documentation
See gh-11113
2017-11-22 23:18:21 -08:00
Phillip Webb 31025d9f6c Drop status endpoint
Drop the status endpoint and merge functionality back into the health
endpoint. The `management.endpoint.health.show-details` property can
be used to change if full details, or just the status is displayed.

Fixes gh-11113
2017-11-22 22:01:58 -08:00
Phillip Webb e82913dd5a Align appendix edits with source code
Port editing changes from append to java source files to ensure that
IDE meta-data also reflects the improvements.

Closes gh-10870
2017-11-20 15:47:49 -08:00
Phillip Webb 64c5e8b6ed Rename @DurationUnit -> @DefaultDurationUnit
Rename `@DurationUnit` to `@DefaultDurationUnit` to make it clearer
that it only changes the unit if one isn't specified by the user.

Closes gh-11078
2017-11-20 12:18:14 -08:00
Andy Wilkinson bc98b84013 Reduce excessive logging by disabling Statsd metrics export
Closes gh-11009
2017-11-20 15:27:01 +00:00
Phillip Webb 8f4bf233b4 Update configuration properties to use Duration
Update appropriate configuration properties to use the `Duration`
type, rather than an ad-hoc mix of milliseconds or seconds.

Configuration properties can now be defined in a consistent and readable
way. For example `server.session.timeout=5m`.

Properties that were previously declared using seconds are annotated
with `@DurationUnit` to ensure a smooth upgrade experience. For example
`server.session.timeout=20` continues to mean 20 seconds.

Fixes gh-11080
2017-11-19 21:52:57 -08:00
Johnny Lim 73c65286ea Polish 2017-11-18 10:07:30 -08:00