Commit Graph

5790 Commits

Author SHA1 Message Date
Phillip Webb af1a6d8649 Polish "Make it easier to set bufferRequestBody"
See gh-16972
2019-06-03 14:15:54 -07:00
kevinstrijbos 9f06514b89 Make it easier to set bufferRequestBody
Update `RestTemplateBuilder` to make it easier to set
the `bufferRequestBody` value on a underlying `ClientHttpRequestFactory`

See gh-16972
2019-06-03 14:14:34 -07:00
Phillip Webb 750d251ae8 Update JsonComponent documentation
See gh-16544
2019-06-03 13:08:07 -07:00
Brian Clozel c74badd4f2 Auto-configure Elasticsearch REST client in Spring Data
This commit auto-configures the Elasticsearch REST client support
as a template for Spring Data Elasticsearch. As of this commit,
using the transport client is still possible but developers
should migrate.

This commit also removes the deprecated annotation on the
Elasticsearch auto-configuration for the transport client, since
this deprecation notice is already present on the configuration
property.

Closes gh-17024
Closes gh-16542
2019-06-03 21:20:06 +02:00
Stephane Nicoll ae5b5be597 Reset flag after each test as well to avoid side effects 2019-06-03 13:29:35 +02:00
Stephane Nicoll f30e29a4ad Rename spring.reactor.stacktrace-mode.enabled property
Closes gh-16537
2019-06-03 12:18:07 +02:00
Stephane Nicoll 090cc05e7a Add missing metadata for "spring.profiles"
Closes gh-16107
2019-06-03 11:56:09 +02:00
Stephane Nicoll 8beb6c1bcb Document how to specify arguments on the command line with Maven
Closes gh-10926
2019-06-03 11:37:36 +02:00
Gary Russell 23cff6fb09 KafkaAutoConfigurationIntegrationTests to JUnit5
See gh-17034
2019-06-03 08:41:16 +02:00
Phillip Webb bf633fc575 Polish "Support JsonComponent key serializers/deserialzers"
See gh-16544
2019-06-02 20:46:17 -07:00
maly7 361efc7c11 Support JsonComponent key serializers/deserialzers
Update `@JsonComponent` so that it can also be used to register key
serializers and deserializers.

See gh-16544
2019-06-02 20:41:41 -07:00
Phillip Webb 063bb907a4 Merge pull request #16987 from dreis2211
* pr/16987:
  Polish "Avoid using deprecated NCSARequestLog"
  Avoid using deprecated NCSARequestLog

Closes gh-16987
2019-06-02 15:05:21 -07:00
Phillip Webb 14349518c9 Polish "Avoid using deprecated NCSARequestLog"
See gh-16987
2019-06-02 15:04:59 -07:00
dreis2211 4af3badbea Avoid using deprecated NCSARequestLog
See gh-16987
2019-06-02 10:52:16 -07:00
Stephane Nicoll 6a78995d61 Polish "Fix typo in javadoc"
See gh-17044
2019-06-02 09:54:30 +02:00
fidel 2ec0996a6f Fix typo in javadoc
See gh-17044
2019-06-02 09:54:11 +02:00
Phillip Webb 763d18ca68 Polish defaultElementEquals
See gh-16671
2019-06-01 13:33:17 -07:00
Johnny Lim a89e6ff67c Polish dashIgnoringElementEquals()
See gh-16671
2019-06-01 13:33:08 -07:00
Phillip Webb 114f9f9503 Polish "Replace anonymous class with lambdas"
See gh-17040
2019-06-01 13:14:17 -07:00
fidel 46677e30cf Replace anonymous class with lambdas
See gh-17040
2019-06-01 12:49:38 -07:00
Phillip Webb 0fcc561163 Update copyright header of changed files 2019-05-31 22:41:00 -07:00
Phillip Webb 76e075ddd0 Polish "Use request factory to support Basic Authentication"
Reduce the surface area of the public API by making the
`BasicAuthentication` and `BasicAuthenticationClientHttpRequestFactory`
class package private.

This commit also attempts to simplify `TestRestTemplate` by keeping
the `RestTemplateBuilder` and reusing it, rather than needing to deal
only with a `RestTemplate` instance.

See gh-17010
2019-05-31 22:35:36 -07:00
Dmytro Nosan 18a0a7a2e8 Use request factory to support Basic Authentication
Update `RestTemplateBuilder` to use a custom request factory to add
authentication headers rather than an interceptor.

Prior to this commit, the use of the `BasicAuthenticationInterceptor`
interceptor could cause `OutOfMemoryError` whenever a large file is
uploaded.

See gh-17010
2019-05-31 22:29:20 -07:00
Issam El-atif 4ac1407af1 Use new JettyClientHttpConnector constructor
Simplify `ClientHttpConnectorConfiguration`by using the recently
introduced `JettyClientHttpConnector` constructor.

See gh-17015
2019-05-31 15:31:41 -07:00
Madhura Bhave 898a903d2f Fix typos in javadoc 2019-05-31 15:18:29 -07:00
Phillip Webb 4b2fdee3fc Polish 2019-05-31 15:11:06 -07:00
Andy Wilkinson 0644a79401 Repackage output capture and always use extension declaratively
Closes gh-17029
2019-05-31 18:33:10 +01:00
Phillip Webb d11d5ceb29 Split up JUnit 5 OutputCapture class
Split the JUnit 5 `OutputCapture` class into separate `OutputExtension`
and `CapturedOutput` classes. The JUnit 5 callback methods are now
contained only in the `OutputExtension` class so no longer pollute the
public API that users will interact with.

The `CapturedOutput` class has also been updated to capture System.err
and System.out separately to allow distinct assertions if required.

Closes gh-17029
2019-05-30 23:44:35 -07:00
Phillip Webb 68a3fbd7a0 Extract AutoTimer interface for metrics
Refactor `Autotime` from a properties object to an interface and
change the existing metric recording implementations. The `AutoTimer`
interface is a general purpose callback that can be applied to a
`Timer.Builder` to configure it. Autotime properties are now located
in `spring-boot-actuator-autoconfigure` and have become an
implementation of the interface.

Closes gh-17026
2019-05-30 16:03:34 -07:00
Phillip Webb ad5e905bd7 Update copyright header of changed files 2019-05-30 11:30:43 -07:00
Phillip Webb 68aec8b6ee Polish 2019-05-30 11:30:27 -07:00
Dmytro Nosan 54061bd59f Polish CassandraDataAutoConfiguration
See gh-17004
2019-05-30 11:17:22 +02:00
Phillip Webb 791be953fe Merge branch 'spring-projects/2.1.x'
Closes gh-17018
2019-05-29 16:11:52 -07:00
Phillip Webb 8e268987ff Improve thread safety in property source cache
Update `SpringIterableConfigurationPropertySource` so that they cache
and cache key are not stored in different fields. Prior to this commit
it was possible that the an incorrect cache could be returned from
because the key and cache were out of sync.

This commit also allows more lenient handling of ConcurrentModification
exceptions if they are thrown during cache retrieval.

Closes gh-17017
See gh-17013
2019-05-29 16:05:24 -07:00
dreis2211 38c21f58b8 Add missing @Test annotation
See gh-17012
2019-05-29 14:41:22 -07:00
Phillip Webb c84c9409bd Polish 2019-05-29 14:41:01 -07:00
Phillip Webb 6509322bd8 Merge branch '2.1.x'
Closes gh-17016
2019-05-29 14:36:34 -07:00
Johnny Lim f52ab0040f Handle all getters first in JavaBeanBinder
Update `JavaBeanBinder.addProperties` to add both `get` and `is` methods
before `set`.

See gh-17005
2019-05-29 11:15:41 -07:00
Andy Wilkinson e481eccd57 Merge branch '2.1.x'
Closes gh-17006
2019-05-29 14:19:57 +01:00
Johnny Lim 765b66c599 Add a missing @Test in JavaBeanBinderTests
See gh-17002
2019-05-29 14:17:41 +01:00
Andy Wilkinson 880721557b Polish "Auto-configure Flyway and Liquibase when there's a URL but no DataSource"
See gh-16850
2019-05-29 11:01:37 +01:00
ilya.lukyanovich@dataart.com 3ca73bf00d Auto-configure Flyway and Liquibase when there's a URL but no DataSource
See gh-16850
2019-05-29 11:01:26 +01:00
Andy Wilkinson 69a298231c Polish "Configure FluentConfiguration to use ResourceLoader's ClassLoader"
See gh-16947
2019-05-29 10:11:24 +01:00
Alan Gomes cc5bd51343 Configure FluentConfiguration to use ResourceLoader's ClassLoader
See gh-16947
2019-05-29 10:02:56 +01:00
Andy Wilkinson 898b7918c0 Merge branch '2.1.x'
Closes gh-16914
2019-05-29 09:57:06 +01:00
Andy Wilkinson 6b199c84d7 Upgrade to Jackson 2.9.9
Closes gh-16910
2019-05-29 09:02:25 +01:00
Johnny Lim 0741e6470f Use MediaType.APPLICATION_CBOR constant
See https://github.com/spring-projects/spring-framework/pull/23042

Closes gh-16986
2019-05-29 09:21:15 +02:00
Andy Wilkinson ecf7c817a6 Build and test the Gradle plugin with Java 11 and 12
Closes gh-12333
2019-05-29 07:20:34 +01:00
Andy Wilkinson 86380ab8db Add missing package-info.java files 2019-05-29 07:20:34 +01:00
Phillip Webb eb38c3abb7 Fix test broken by additional customizer
See gh-16498
2019-05-28 18:18:25 -07:00
Phillip Webb 9a6415375d Polish 2019-05-28 17:00:25 -07:00
Phillip Webb 988f02d766 Merge branch '2.1.x'
Closes gh-16996
2019-05-28 16:46:09 -07:00
Phillip Webb f380ba63eb Exclude Groovy MetaClass from property meta-data
Update `TypeExcludeFilter` to exclude `groovy.lang.MetaClass`.

Closes gh-16981
2019-05-28 16:42:42 -07:00
Phillip Webb 6d413afecf Merge branch '2.1.x'
Closes gh-16995
2019-05-28 16:31:36 -07:00
Phillip Webb 09373622ca Polish "Allow Tomcat be destroyed regardless of exceptions"
See gh-16892
2019-05-28 16:15:26 -07:00
Joao Silva 2b33e31a7c Allow Tomcat be destroyed regardless of exceptions
Update `TomcatWebServer` so that lifecycle exceptions are silently
swallowed when attempting shutdown. Prior to this commit it was
possible that a Tomcat instance might not be properly destroyed and
could leave non daemon threads running, which prevent the JVM from
exiting.

Fixes gh-16892
2019-05-28 16:10:37 -07:00
Phillip Webb f96dc33c0f Merge branch '2.1.x' 2019-05-28 16:02:41 -07:00
Steve Crow e0e871c77b Add Nexmo to list of third-party starters
Closes gh-16944
2019-05-28 16:01:33 -07:00
Phillip Webb e86bb74074 Merge branch '2.1.x'
Closes gh-16993
2019-05-28 15:59:22 -07:00
Phillip Verheyden 2149ba4051 Use a regex that captures numbers and qualifiers
Fix the regular expression used in the devtools documentation to
include a version number pattern.

Closes gh-16946
2019-05-28 15:55:00 -07:00
Phillip Webb af1720aa2e Fix checkstyle issue 2019-05-28 15:52:00 -07:00
Phillip Webb 6e9f2e42af Merge branch '2.1.x'
Closes gh-16992
2019-05-28 15:06:16 -07:00
Phillip Webb 6913ea24b0 Polish "Fix NoClassDefFound when missing Spring Security"
See gh-16889
2019-05-28 14:56:58 -07:00
Vedran Pavic e9bd11ee83 Fix NoClassDefFound when missing Spring Security
Update Spring Session auto-configuration to ensure that the
`DefaultCookieSerializer` doesn't break when Spring Security is not
present on the classpath.

Closes gh-16889
2019-05-28 14:55:18 -07:00
Phillip Webb 5fc67c545c Work around Framework regression in handling of null model values
See https://github.com/spring-projects/spring-framework/issues/23038.
2019-05-28 14:33:08 -07:00
Phillip Webb df55d73bff Merge branch '2.1.x'
Closes gh-16990
2019-05-28 13:49:34 -07:00
Phillip Webb 278a0866cd Polish "Fix Spring Data Cassandra auto-configure condition"
See gh-16971
2019-05-28 13:47:45 -07:00
Dmytro Nosan be435130e6 Fix Spring Data Cassandra auto-configure condition
Update `CassandraDataAutoConfiguration` do that it's only applied when
a `Cluster` bean is found.

Fixes gh-16971
2019-05-28 13:47:40 -07:00
Phillip Webb 89f8e187d5 Merge branch '2.1.x'
Closes gh-16988
2019-05-28 13:26:14 -07:00
Phillip Webb 07ebfc036b Polish 2019-05-28 13:17:56 -07:00
Johnny Lim e2f69d040a Use actual resolvedType when checking Binder cache
Update `JavaBeanBinder` so that the `isOfDifferentType` method checks
both the actual type and the resolved type. Prior to this commit, it
was possible that when `canCallGetValue` is `true` the `resolvedType`
could be different from `type.resolve`.

Closes gh-16974
2019-05-28 13:13:08 -07:00
Andy Wilkinson 0eb6c0ddd3 Defer disabling registry until Tomcat server is being created
Closes gh-16498
2019-05-28 20:49:07 +01:00
dreis2211 e59d734098 Fix Gradle plugin code formatting
See gh-16984
2019-05-28 18:10:04 +01:00
Andy Wilkinson c80218064f Use sorted properties to make build info output repeatable
Closes gh-14494
2019-05-28 16:30:36 +01:00
Andy Wilkinson 6de14f71c6 Fail fast if config prop constructor binding cannot determine names
Previously, configuration property constructor binding relied on compilation
with -parameters to be able to discover the names of a constructor's
parameters, failing silently if the parameter names were not available. This
commit updates it to fail when the names could not be determined and switches
to using DefaultParameterNamesDiscoverer. This align configuration property
constructor binding with actuator endpoint operation invocation.

Closes gh-16928
2019-05-28 15:47:39 +01:00
Andy Wilkinson b603cd5d4b Disable Tomcat's MBean Registry by default
Closes gh-16498
2019-05-28 15:21:31 +01:00
Andy Wilkinson 080a2f5c3b Align with Framework’s removal of charset attribute from application/json
Closes gh-16979
2019-05-28 10:58:23 +01:00
Andy Wilkinson 892e517c21 Work around Framework regression in handling of null model values
See https://github.com/spring-projects/spring-framework/issues/23038.
2019-05-28 10:05:59 +01:00
Andy Wilkinson d21a091262 Avoid duplicate retrieval of @ConfigurationProperties in registrar
Closes gh-15802
2019-05-28 09:00:29 +01:00
Brian Clozel d46de7abc4 Polish "Set UTF-8 charset for whitelabel HTML error pages"
Closes gh-16611
2019-05-27 19:06:38 +02:00
qxo 64a8326989 Set UTF-8 charset for whitelabel HTML error pages
This commit changes the HTTP response Content-Type for whitelabel
error pages with Spring WebFlux.

See gh-16611
2019-05-27 17:48:01 +02:00
Stephane Nicoll 593bc22ecc Merge branch '2.1.x' 2019-05-27 16:59:32 +02:00
Stephane Nicoll 2c364ceb89 Fix wrong ApplicationContext import
Closes gh-16978
2019-05-27 16:59:12 +02:00
Brian Clozel 0b70862627 Fix RSocket websocket config with WebFlux
In the case of a WebFlux + RSocket over websocket setup, the RSocket
auto-configuration would not set up the required routes; only the
websocket endpoint for RSocket would be available, overriding the
handler configured for WebFlux.

This commit introduces `NettyRouteProvider`. Components implementing
that interface can contribute HTTP routes to the Reactor Netty server
being built.

* if none is provided, the regular handler setup is used
* if one or more routes are provided, routes are sorted and added before
the WebFlux handler (acting as a default)

Fixes gh-16826
2019-05-27 15:19:32 +02:00
Brian Clozel 45507c475b Configure String codecs in RSocket strategies
Closes gh-16924
2019-05-27 15:19:27 +02:00
Brian Clozel b2e395db7a Avoid codec auto-configuration when WebFlux is not present
This commit prevents the `CodecsAutoConfiguration` from being processed
if spring-webflux is not on classpath, since it is only useful for the
WebFlux server infrastructure or `WebClient`.

Closes gh-15690
2019-05-27 15:19:22 +02:00
Stephane Nicoll 4cdb5a8ecb Polish "Default to optimized launch of the JVM when using spring-boot:run"
Closes gh-16941
2019-05-25 12:22:00 +02:00
Dos Debug 569b850fe0 Default to optimized launch of the JVM when using spring-boot:run
See gh-16941
2019-05-25 12:21:37 +02:00
Johnny Lim d8e5169f5f Polish
Closes gh-16948
2019-05-25 11:28:23 +02:00
Andy Wilkinson 54b123028c Default to optimized launch of the JVM when using Gradle's bootRun
Closes gh-16222
2019-05-25 09:29:52 +01:00
Andy Wilkinson 7713a7f33a Fix inclusion of Gradle DSL snippets in plugin reference docs
Closes gh-16968
2019-05-25 09:21:10 +01:00
Andy Wilkinson f3ebd71b29 Merge branch '2.1.x'
Closes gh-16967
2019-05-25 08:11:10 +01:00
Robeatoz 9f248c6043 Correct name and description of spring-boot-project module
This commit corrects the Maven project name and description of spring-boot-project to
avoid the already used name "Spring Boot Build".

See gh-16938
2019-05-25 08:08:36 +01:00
Andy Wilkinson ead0cd91bf Start building against snapshots for Spring Session Corn-M2
See gh-16587
2019-05-25 08:04:32 +01:00
Andy Wilkinson a9089db9e7 Start building against snapshots for Spring Data Moore-RC1
See gh-16966
2019-05-25 08:03:44 +01:00
Andy Wilkinson 36ccfd9d1b Start building against snapshots for Spring Security 5.2.0.M3
See gh-16965
2019-05-25 08:02:50 +01:00
Andy Wilkinson 35568e4663 Start building against snapshots for Reactor Dysprosium-M2
See gh-16964
2019-05-25 07:59:16 +01:00
Andy Wilkinson b07a0193ec Start building against snapshots for Spring Framework 5.2.0.M3
See gh-16963
2019-05-25 07:57:45 +01:00
Andy Wilkinson d964357bfa Start building against snapshots for Reactor Californium-SR9
See gh-16962
2019-05-25 07:49:15 +01:00
Andy Wilkinson 636113823c Start building against Spring Framework 5.1.8 snapshots
See gh-16961
2019-05-25 07:48:19 +01:00