root
/
spring-boot
mirror of https://github.com/spring-projects/spring-boot.git
1
0
Fork 0
Code Issues Actions 15 Packages Projects Releases Wiki Activity
28,472 Commits 23 Branches 345 Tags 287 MiB
Commit Graph

295 Commits

Author SHA1 Message Date
Andy Wilkinson cffc870fd6 Fix test failures on Windows 
Since the move to JUnit 5, a number of tests were failing on Windows.
The majority were failing due to open file handles preventing the
clean up of the tests' temporary directory. This commit addresses
these failures by updating the tests to close JarFiles, InputStreams,
OutputStreams etc.

A change has also been made to CachingOperationInvokerTests to make
a flakey test more robust. Due to System.currentTimeMillis() being
less precise on Windows than it is on *nix platforms, the test could
fail as it would not sleep for long enough for the TTL period to have
expired.
 2019-06-13 09:24:31 +01:00
Andy Wilkinson 38552065e8 Merge branch '2.1.x' 
Closes gh-17114
 2019-06-12 11:37:05 +01:00
Andy Wilkinson 7103eab2e6 Close JarFiles when looking for Class-Path manifest entries 
Fixes gh-17095
 2019-06-12 11:36:34 +01:00
Andy Wilkinson c11f25bf8b Merge branch '2.1.x' 
Closes gh-17104
 2019-06-11 10:52:03 +01:00
Andy Wilkinson 95d0e26c35 Fix command DevTools uses to shut down in-memory Derby DB 
Closes gh-17099
 2019-06-11 10:29:09 +01:00
Phillip Webb 266d6334b2 Fix checkstyle RedundantModifier test violations 2019-06-07 20:46:33 -07:00
Andy Wilkinson b18fffaf14 Move tests to JUnit 5 wherever possible 2019-06-07 12:25:54 +01:00
Andy Wilkinson aef92b9295 Merge branch '2.1.x' 
Closes gh-17079
 2019-06-07 11:00:44 +01:00
Andy Wilkinson 24925c3dae Merge branch '2.0.x' into 2.1.x 
Closes gh-17078
 2019-06-07 10:50:34 +01:00
Andy Wilkinson c6c139d980 Merge branch '1.5.x' into 2.0.x 2019-06-07 10:46:31 +01:00
Phillip Webb d306b31ce9 Merge branch '2.1.x' 2019-06-04 02:08:00 -07:00
Phillip Webb ccfbd03482 Merge branch '2.0.x' into 2.1.x 2019-06-04 02:07:14 -07:00
Phillip Webb 5fba43aa31 Merge branch '1.5.x' into 2.0.x 2019-06-04 00:05:57 -07:00
Stephane Nicoll f30e29a4ad Rename spring.reactor.stacktrace-mode.enabled property 
Closes gh-16537
 2019-06-03 12:18:07 +02:00
Andy Wilkinson 0644a79401 Repackage output capture and always use extension declaratively 
Closes gh-17029
 2019-05-31 18:33:10 +01:00
Andy Wilkinson 3432044997 Use deferred logging to report Class-Path manifest attribute problems 
Closes gh-16883
 2019-05-23 11:20:15 +01:00
Johnny Lim 7aaad7e5f4 Fix assertion for outcomeWhenDevtoolsShouldBeEnabledIsTrueShouldMatch() 
Closes gh-16815
 2019-05-20 14:27:38 +02:00
Phillip Webb 3a9ca5fa30 Update copyright header of changed files 2019-05-14 21:05:53 -07:00
Brian Clozel 08cb8368ef Delete Devtools cache reset support for HATEOAS 
As of spring-projects/spring-hateoas#854, Spring HATEOAS is not relying
on Objenesis anymore and removed the cache that was being used for it.

This commit removes the support for clearing that cache when running an
application with Devtools enabled.

See gh-16833
 2019-05-13 22:20:42 +02:00
Andy Wilkinson ef11af8676 Polish "Remove unnecessary latches in tests" 
Closes gh-16733
 2019-05-09 12:12:23 +01:00
Johnny Lim 0baceb4aa4 Remove unnecessary latches in tests 
See gh-16733
 2019-05-09 12:09:54 +01:00
Johnny Lim 7c8bf48ebb Polish DevToolsEnablementDeducer and OnEnabledDevToolsCondition 
See gh-16732
 2019-05-09 12:01:33 +01:00
Phillip Webb 17aaf26590 Use consistent javadoc style for annotation links 
Closes gh-13920
 2019-04-24 19:37:59 -07:00
Madhura Bhave ac2b0093c7 Disable DevTools' post-processors and auto-config when running tests 
Closes gh-5307
 2019-04-16 11:07:33 -07:00
Madhura Bhave 3c203e9b0d Update devtools to use @Lazy(false) 
Fixes gh-16184
 2019-04-05 18:02:27 -07:00
Stephane Nicoll c432288ed1 Migrate ApplicationContext to common hierarchy 
This commit migrates `AnnotationConfigReactiveWebApplicationContext`
parent to the `GenericApplicationContext` abstraction. Any use of
`AnnotationConfigWebApplicationContext` is also removed as it also
inherits from the `AbstractRefreshableApplicationContext` outdated
hierarchy.

A new `AnnotationConfigServletWebApplicationContext` context is
introduced instead, extending from `GenericApplicationContext` and
providing the counter part of the reactive context for the Servlet-based
web app tests.

See gh-16096
 2019-04-05 14:17:41 +02:00
Phillip Webb 2376f973f4 Merge branch '2.1.x' 2019-04-02 13:46:36 -07:00
Phillip Webb 47c6bf741d Merge branch '2.0.x' into 2.1.x 2019-04-02 13:40:21 -07:00
Phillip Webb 07c000c5b7 Merge branch '1.5.x' into 2.0.x 2019-04-02 13:34:28 -07:00
Andy Wilkinson 878a635bfb Merge branch '2.1.x' 2019-03-28 11:48:47 +00:00
Andy Wilkinson 864942ad4f Merge branch '2.0.x' into 2.1.x 2019-03-28 09:35:53 +00:00
Spring Operator 1a4c6f2dac Use HTTPS for external links wherever possible 
See gh-16319
 2019-03-27 20:06:52 +00:00
Andy Wilkinson ba4671f0ab Merge branch '1.5.x' into 2.0.x 2019-03-27 19:59:36 +00:00
Andy Wilkinson 36c1c051b8 Merge branch '2.1.x' 2019-03-20 16:55:10 +00:00
Andy Wilkinson e23f72c8b0 Merge branch '2.0.x' into 2.1.x 2019-03-20 16:53:48 +00:00
Andy Wilkinson 9fbd38ab3c Merge branch '1.5.x' into 2.0.x 2019-03-20 16:45:26 +00:00
Andy Wilkinson b828b398b5 Merge branch '2.1.x' 2019-03-19 17:11:45 +00:00
Andy Wilkinson a36aa67b52 Merge branch '2.0.x' into 2.1.x 2019-03-19 17:04:41 +00:00
Spring Operator 3e2b6ac8ed Update build and setup configuration to use HTTPS 
See gh-16246
 2019-03-19 16:58:31 +00:00
Andy Wilkinson 68bfb020aa Reduce need for bean method proxying and disable where not needed 
Closes gh-9068
 2019-03-12 13:18:42 +00:00
Andy Wilkinson aa2008bc5a Merge branch '2.1.x' 2019-03-11 16:40:19 +00:00
Andy Wilkinson f0ef693376 Merge branch '2.0.x' into 2.1.x 2019-03-11 16:28:29 +00:00
Andy Wilkinson c2eeeb032c Work around javac bug 2019-03-11 16:27:56 +00:00
Andy Wilkinson 8c3cec8f13 Merge branch '2.0.x' into 2.1.x 2019-03-11 16:14:19 +00:00
Andy Wilkinson 361437f4e2 Merge branch '1.5.x' into 2.0.x 2019-03-11 15:53:34 +00:00
Andy Wilkinson 2bd3d19bee Ensure that DevTools' beans use eager init even when app is lazy 
Closes gh-15870
 2019-03-08 10:05:40 +00:00
Andy Wilkinson d6a869fa98 Switch to Jakarta EE API dependencies where possible 
Closes gh-16113
Closes gh-16112
Closes gh-16111
Closes gh-15916
Closes gh-15689
 2019-03-06 11:20:51 +00:00
Stephane Nicoll 2ad234b605 Adapt to breaking change in Spring Hateoas 2019-02-28 13:42:27 +01:00
Andy Wilkinson de0c065625 Inject single-use configuration dependencies into bean methods 
Closes gh-15751
 2019-02-20 17:02:43 +00:00
Johnny Lim 55f5f2f910 Polish 
Closes gh-15987
 2019-02-19 09:14:40 +01:00
Andy Wilkinson bd504e68fc Merge branch '2.1.x' 2019-02-14 15:21:30 +00:00
Andy Wilkinson 33b9321071 Track condition evaluation per-context when determining delta 
Closes gh-15766
 2019-02-14 15:11:18 +00:00
Andy Wilkinson be40d000ba Merge branch '2.1.x' 2019-02-14 14:46:59 +00:00
Andy Wilkinson 1be794fe65 Retry upload for any SocketException not just a ConnectException 
Previously, DevTools would retry the upload of the changes to an
application in the event of a ConnectException. If a different
network-level failure occurred, it would not be retried and would
cause the file watching thread to die.

This commit attempts to make things more robust by retrying all
SocketExceptions and not just ConnectExceptions. A warning is
logged when a failure occurs. A separate debug message that
includes the exception is also logged.

Closes gh-10317
 2019-02-14 14:46:52 +00:00
Andy Wilkinson d9ec48ef12 Merge branch '2.1.x' 2019-02-11 16:13:52 +00:00
Andy Wilkinson 3f32fbd0de Polish "Remove unwanted @Nullable annotations" 
See gh-15876
 2019-02-11 16:11:40 +00:00
wonwoo 2855321074 Remove unwanted @Nullable annotations 
See gh-15876
 2019-02-11 16:07:29 +00:00
Andy Wilkinson 45cc649c7d Merge branch '2.1.x' 2019-02-04 12:36:33 +00:00
Andy Wilkinson 82bc87560c Use AssertJ’s exception assertions rather than fail 
Closes gh-15761
 2019-02-04 11:48:26 +00:00
dreis2211 d4ab101223 Use Assertions.contentOf() where possible 
Closes gh-15793
 2019-01-28 10:08:57 +01:00
Stephane Nicoll dca6879d4e Polish "Remove an unused interface in RestarterTests" 
Closes gh-15666
 2019-01-10 13:25:34 +01:00
Johnny Lim d7f0c1d63c Remove an unused interface in RestarterTests 
See gh-15666
 2019-01-10 13:25:14 +01:00
Andy Wilkinson 61d04db0d7 Minimize and centralize assumptions about build output 
Closes gh-15471
 2018-12-14 17:50:20 +00:00
Andy Wilkinson db5ab1d14c Do not rely on test runner using static main method in RestarterTests 
Closes gh-15461
 2018-12-13 13:39:19 +00:00
igor-suhorukov a2ebba8db1 Replace explicit generic type with diamond operator 
See gh-15424
 2018-12-09 11:42:27 +01:00
igor-suhorukov 5c1813aef8 Replace this lambda with a method reference 
See gh-15401
 2018-12-07 11:01:42 +01:00
Phillip Webb 5e50f762a3 Revert DevTools polish 
It seems like we can't use constructor injection at the
moment.
 2018-10-29 18:37:58 -07:00
Phillip Webb f3fa20b2d1 Polish 2018-10-29 14:25:45 -07:00
Andy Wilkinson 743782de7e Revert reloadable message source support 
Closes gh-14882
See gh-14699
See gh-13377
 2018-10-29 16:24:59 +00:00
Andy Wilkinson 8ec9f23719 Polish "Add Log Output when DevTools restart is disabled" 
Closes gh-14807
 2018-10-29 12:38:43 +00:00
Marcus Eisele e76605ff75 Add Log Output when DevTools restart is disabled 
This covers the cases when:
  * An Java agent based reloader (e.g. JRebel) is being used
  * The reloader was disabled by using a system property

See gh-14807
 2018-10-29 12:38:21 +00:00
Phillip Webb c393f6262e Merge branch '2.0.x' 2018-10-26 16:36:02 -07:00
Phillip Webb 33c7a74bee Update copyright year for changed files 2018-10-26 16:35:28 -07:00
Madhura Bhave 5f24af6c3c Polish 
Closes gh-14915
 2018-10-23 13:51:13 -07:00
michal 7181e76135 Skip restarter for JUnit5 
See gh-14915
 2018-10-23 13:50:57 -07:00
Madhura Bhave 80bb7ea9d6 Merge branch '2.0.x' 2018-10-23 13:43:40 -07:00
Madhura Bhave bc58d4456f Rationalize DefaultRestartInitializerTests 
Closes gh-14927
 2018-10-23 13:43:11 -07:00
Stephane Nicoll 1a0d53dec0 Replace ReflectionTestUtils usage by hasFieldOrPropertyWithValue 
Closes gh-14696
 2018-10-15 08:25:10 +02:00
Phillip Webb 1d8e4a8f5c Make devtools set spring.messages.reloadable=true 
Update `DevToolsPropertyDefaultsPostProcessor` to automatically set
the recently introduced `spring.messages.reloadable` property to
`true`.

Closes gh-14699
 2018-10-05 13:59:26 -07:00
Johnny Lim 335775892b Polish 
See gh-14667
 2018-10-03 13:57:18 +02:00
Phillip Webb d76bba5e6f Migrate from ExpectedException rule to AssertJ 
Replace ExpectedException JUnit rules with AssertJ exception
assertions.

Closes gh-14336
 2018-10-02 10:55:28 -07:00
Johnny Lim 698bbd6a9e Polish 
Closes gh-14597
 2018-09-26 11:45:21 -04:00
Stephane Nicoll 19779951a1 Handle class not found 
See gh-14575
 2018-09-24 10:23:59 +02:00
Phillip Webb 84e72193b3 Remove automatic devtools web debug logging 
Rework `DevToolsPropertyDefaultsPostProcessor` so that web logging no
longer defaults to `DEBUG`. The post processor now logs an info hint
to suggest the user configure the logging themselves.

Closes gh-14575
 2018-09-23 08:44:34 -07:00
Andy Wilkinson 65295e0e14 Merge branch '2.0.x' 2018-09-19 19:52:19 +01:00
Andy Wilkinson bff93a67ce Fix remote DevTools restart when a previously added class is then changed 
Previously, if a class was added and then changed, a restart would be triggered
and things would behave as if the class had been deleted. This occurred
because, when looking for additional classes that were not on the original
classpath, only files that had been added were considered. The subsequent
change to the class was noticed as a modified rather than an addition,
resulting in the class being skipped.

This commit updates the resource resolver to only ignore deleted files and
consider both added files and modified files when looking for additional
resources.

Closes gh-14205
 2018-09-19 18:02:01 +01:00
Stephane Nicoll f42891489d Polish key description 
Closes gh-14450
 2018-09-19 10:31:01 +02:00
Phillip Webb d4b11c8fa6 Attempt to fix test failures on Java 9+ 
See gh-14453
 2018-09-12 18:31:50 -07:00
Phillip Webb cef635d86c Reinstate devtools debug logging with opt-out 
Reinstate `web` logging when devtools is in use, making use of the new
logging groups support. Devtools now also logs an `INFO` message
informing that properties defaults are offers an easy way to disable
them.

Closes gh-14450
 2018-09-12 16:25:14 -07:00
Phillip Webb c4caf2705a Defer devtools logging 
Defer logging from devtools classes until the context is prepared.

Closes gh-14453
 2018-09-12 16:25:14 -07:00
Phillip Webb aa2da0bb0d Remove logging level changes from devtools 
Update `DevToolsPropertyDefaultsPostProcessor` to remove custom logging
level configuration. Unfortunately it's not easy to back-off logging
overrides when the user has a custom logback/log4j configuration.

Closes gh-14310
 2018-09-11 15:07:34 -07:00
Phillip Webb 9d1b3a2b49 Merge branch '2.0.x' 2018-09-04 16:25:17 -07:00
Phillip Webb cafff43022 Update copyright header of changed files 2018-09-04 16:19:05 -07:00
Johnny Lim fe3fe0fa63 Polish 
Closes gh-14202
 2018-08-26 10:48:05 +02:00
Johnny Lim 9602a32a8d Polish 
Closes gh-14172
 2018-08-23 11:40:44 +02:00
Brian Clozel f2511b7fa3 Improve Web DEBUG logging output configuration 
Since SPR-16946, Spring Framework revisited the DEBUG logging output
developers get while working on Spring MVC and Spring WebFlux
applications.

This commit aligns to those changes where DEBUG output was produced
in Spring Boot (especially in `DefaultErrorWebExceptionHandler`).

This also enables DEBUG logging on the related packages when running an
application with Spring Boot Developer Tools, providing a better
development experience.

This is also adding the new `spring.insights.web.log-request-details`
configuration property, which logs additional information about the
incoming requests at the DEBUG and TRACE levels. Since that information
can be sensitive (e.g. credentials, tokens, etc.), this property is not
enabled by default nor activated by the Developer Tools.

Closes: gh-13511
 2018-08-16 18:19:38 +02:00
Stephane Nicoll 8f2ab952f5 Polish javadoc formatting 2018-08-16 17:19:25 +02:00
Andy Wilkinson 971caad6f8 Merge branch '2.0.x' 2018-08-16 10:19:05 +01:00
Andy Wilkinson 3e093035b4 Merge branch '1.5.x' into 2.0.x 2018-08-16 10:18:52 +01:00
Stephane Nicoll 0d04d7adf8 Migrate @EventListener to ApplicationListener 
Closes gh-14041
 2018-08-10 12:52:14 +02:00
Stephane Nicoll 624c1306fd Merge branch '2.0.x' 2018-08-03 18:25:24 +02:00
Stephane Nicoll 737b4a275b Polish 2018-08-03 18:24:59 +02:00
Stephane Nicoll d12a099a6d Merge branch '2.0.x' 2018-07-31 08:17:46 +02:00
Johnny Lim d4fba783fb Remove ex.printStackTrace() in tests 
Closes gh-13952
 2018-07-31 08:16:40 +02:00
Phillip Webb 4d86ac4713 Polish copyright date on changed files 2018-07-29 09:30:26 +01:00
Phillip Webb 1b91c0ceb7 Merge branch '2.0.x' 2018-07-29 09:29:57 +01:00
Phillip Webb 0ec22c8bf9 Polish copyright date on changed files 2018-07-29 09:29:29 +01:00
Phillip Webb 80da9cf5eb Merge branch '2.0.x' 2018-07-29 09:28:56 +01:00
Phillip Webb aeb885192e Polish ternary expressions 2018-07-29 09:24:46 +01:00
Phillip Webb a6c9c92f2e Merge branch '2.0.x' 2018-07-28 01:35:43 +01:00
Phillip Webb 63b609827e Fix checkstyle method order issues 
Fix checkstyle issues with method ordering following the
spring-javaformat upgrade.

See gh-13932
 2018-07-28 01:11:53 +01:00
Phillip Webb e6a68b39a3 Fix checkstyle javadoc issues 
Fix checkstyle issues in javadoc following the spring-javaformat
upgrade.

See gh-13932
 2018-07-28 01:11:52 +01:00
Phillip Webb 7fc455654a Fix checkstyle ternary issues 
Fix checkstyle issues with ternary expressions following the
spring-javaformat upgrade.

See gh-13932
 2018-07-28 01:11:52 +01:00
Stephane Nicoll ac01409332 Merge branch '2.0.x' 2018-07-17 08:22:58 +02:00
Stephane Nicoll ec2ebf52de Merge branch '1.5.x' into 2.0.x 2018-07-17 08:22:15 +02:00
Stephane Nicoll 48962718d1 Merge branch '2.0.x' 2018-07-16 10:37:43 +02:00
Johnny Lim 068e22d60b Polish 
See gh-13776
 2018-07-16 10:34:00 +02:00
Andy Wilkinson 87b72cc981 Polish DevTools auto-configuration tests to avoid bean overrides 
See gh-13609
 2018-07-10 16:31:11 +01:00
Andy Wilkinson de900e71a3 Merge branch '2.0.x' 2018-07-02 16:26:27 +01:00
Andy Wilkinson 032d5488cd Tolerate non-existent source folders in DevTools 
Closes gh-13620
 2018-07-02 16:26:19 +01:00
Madhura Bhave cb621024e4 Include error stacktrace by default when devtools is in use 
Fixes gh-828
 2018-06-06 15:25:52 -07:00
Johnny Lim 6b0ce46491 Polish 
Closes gh-13320
 2018-06-01 09:22:20 +02:00
Phillip Webb 5b3cb8a698 Update copyright header year for changed files 2018-05-04 15:59:26 -07:00
Phillip Webb 41efea51a7 Polish ternary expressions 
Consistently format ternary expressions and always favor `!=` as the
the check.
 2018-05-03 22:43:12 -07:00
Phillip Webb e125085993 Merge branch '1.5.x' into 2.0.x 2018-05-03 12:43:50 -07:00
Johnny Lim b941c5f1a6 Polish 
Closes gh-12981
 2018-04-27 09:29:16 +02:00
Stephane Nicoll 92d9479765 Gracefully handle exclusion of DataSourceAutoConfiguration 
This commit makes sure that an auto-configuration that requires
`DataSourceProperties` will not break if `DataSourceAutoConfiguration`
has been explicitly excluded.

Closes gh-12512
 2018-04-09 10:34:23 +02:00
Phillip Webb 685babc829 Polish "Use lambdas for map entry iteration where possible" 
Closes gh-12626
 2018-04-04 19:36:18 -07:00
igor-suhorukov 69bc19e0ca Use lambdas for map entry iteration where possible 
See gh-12626
 2018-04-04 19:36:10 -07:00
Phillip Webb 47a56616ae Merge branch '1.5.x' 2018-04-02 09:51:03 -07:00
Phillip Webb 98a2a91d16 Polish 2018-03-29 14:00:13 -07:00
Stephane Nicoll 553b184248 Polish "Use Supplier variants of Assert methods" 
Closes gh-12630
 2018-03-26 17:59:35 +02:00
dreis2211 3b0f6e7168 Use Supplier variants of Assert methods 
See gh-12630
 2018-03-26 17:58:17 +02:00
dreis2211 8626daf135 Replace Mockito.times(0) with Mockito.never() 
Closes gh-12475
 2018-03-14 15:12:20 -07:00
igor-suhorukov cca976eccd Remove redundant "close" call 
Closing the resource is handled automatically by the try-with-resources.

Closes gh-12453
 2018-03-13 08:48:13 +01:00
Stephane Nicoll ed05e1f7ca Polish "Reorder modifiers to comply with the JLS" 
Closes gh-12432
 2018-03-12 15:17:23 +01:00
igor-suhorukov aebb475bc5 Reorder modifiers to comply with the JLS 
See gh-12432
 2018-03-12 15:17:05 +01:00
Stephane Nicoll a55180aa1e Polish "Get rid of "magic" time constants" 
Closes gh-12411
 2018-03-09 16:37:18 +01:00
igor-suhorukov ce78a78231 Get rid of "magic" time constants 
See gh-12411
 2018-03-09 16:36:45 +01:00
Phillip Webb 29c3be3590 Polish 2018-02-26 10:26:02 -08:00
Johnny Lim d441a8a89a Polish 
Closes gh-12205
 2018-02-24 11:53:25 +01:00
Andy Wilkinson 73ad36d817 Merge branch '1.5.x' 2018-02-23 15:34:45 +00:00
Stephane Nicoll 09ff815f00 Harmonize metadata 
Closes gh-12177
 2018-02-23 11:02:28 +01:00
Phillip Webb 4b9c3c137e Polish Collection.toArray 
Consistently use `StringUtils.toStringArray`, `ClassUtils.toClassArray`
or zero length when converting collections to arrays.

Fixes gh-12160
 2018-02-22 21:11:30 -08:00
Phillip Webb cd5266ac03 Polish 2018-02-22 20:25:28 -08:00
Johnny Lim 2fe86da95b Use isTrue() and isFalse() for AssertJ 
Closes gh-12170
 2018-02-22 09:55:40 +01:00
Johnny Lim 87bf0b26df Polish modifier order 
See gh-12019
 2018-02-13 09:49:59 +01:00
Andy Wilkinson 5522174e96 Provide package info for all packages included in javadoc 2018-02-08 16:50:37 +00:00
Andy Wilkinson 76a450dfba Format with Eclipse Oxygen SR2 2018-02-08 10:53:53 +00:00
Phillip Webb 69234f8c08 Polish 2018-02-02 18:59:05 -08:00