Add missing @⁠Override annotations

... and suppress "serial" warnings
This commit is contained in:
Sam Brannen 2025-09-22 13:20:37 +02:00
parent f504d051ab
commit 0c61ac956b
42 changed files with 44 additions and 5 deletions

View File

@ -117,10 +117,11 @@ public class ExpressionException extends RuntimeException {
/**
* Return the exception message.
* As of Spring 4.0, this method returns the same result as {@link #toDetailedString()}.
* <p>This method returns the same result as {@link #toDetailedString()}.
* @see #getSimpleMessage()
* @see java.lang.Throwable#getMessage()
*/
@Override
public String getMessage() {
return toDetailedString();
}

View File

@ -70,10 +70,12 @@ class DefaultJmsClient implements JmsClient {
}
@Override
public OperationSpec destination(Destination destination) {
return new DefaultOperationSpec(destination);
}
@Override
public OperationSpec destination(String destinationName) {
return new DefaultOperationSpec(destinationName);
}

View File

@ -50,6 +50,7 @@ class MessageSendingTemplateTests {
private final TestMessagePostProcessor postProcessor = new TestMessagePostProcessor();
@SuppressWarnings("serial")
private final Map<String, Object> headers = new HashMap<>() {{
put("key", "value");
}};

View File

@ -284,6 +284,7 @@ public class LocalSessionFactoryBuilder extends Configuration {
* @see #addPackage
* @see #scanPackages
*/
@Override
public LocalSessionFactoryBuilder addPackages(String... annotatedPackages) {
for (String annotatedPackage : annotatedPackages) {
addPackage(annotatedPackage);

View File

@ -642,7 +642,7 @@ public class MockHttpServletResponse implements HttpServletResponse {
sendRedirect(url, HttpServletResponse.SC_MOVED_TEMPORARILY, true);
}
// @Override - on Servlet 6.1
@Override
public void sendRedirect(String url, int sc, boolean clearBuffer) throws IOException {
Assert.state(!isCommitted(), "Cannot send redirect - response is already committed");
Assert.notNull(url, "Redirect URL must not be null");

View File

@ -173,6 +173,7 @@ class DefaultRestTestClientBuilder<B extends RestTestClient.Builder<B>> implemen
this.mockMvcBuilder = mockMvcBuilder;
}
@Override
public <T extends S> T configureServer(Consumer<M> consumer) {
consumer.accept(this.mockMvcBuilder);
return self();

View File

@ -41,6 +41,7 @@ class FilterTests {
@Test
void filter() {
@SuppressWarnings("serial")
Filter filter = new HttpFilter() {
@Override
protected void doFilter(HttpServletRequest req, HttpServletResponse res, FilterChain chain) throws IOException {

View File

@ -370,6 +370,7 @@ public abstract class AbstractTransactionAspectTests {
protected void doTestRollbackOnException(
final Exception ex, final boolean shouldRollback, boolean rollbackException) throws Exception {
@SuppressWarnings("serial")
TransactionAttribute txatt = new DefaultTransactionAttribute() {
@Override
public boolean rollbackOn(Throwable t) {

View File

@ -23,7 +23,6 @@ import java.util.regex.Pattern;
import org.springframework.http.ResponseCookie;
/**
* Parser that delegates to {@link java.net.HttpCookie#parse(String)} for parsing,
* but also extracts and sets {@code sameSite}.
@ -39,6 +38,7 @@ final class JdkResponseCookieParser implements ResponseCookie.Parser {
/**
* Parse the given headers.
*/
@Override
public List<ResponseCookie> parse(String header) {
Matcher matcher = SAME_SITE_PATTERN.matcher(header);
String sameSite = (matcher.matches() ? matcher.group(1) : null);

View File

@ -163,6 +163,7 @@ public class DefaultApiVersionStrategy implements ApiVersionStrategy {
return this.versionParser.parseVersion(version);
}
@Override
public void validateVersion(@Nullable Comparable<?> requestVersion, HttpServletRequest request)
throws MissingApiVersionException, InvalidApiVersionException {

View File

@ -84,6 +84,7 @@ final class DefaultApiVersionInserterBuilder implements ApiVersionInserter.Build
return this;
}
@Override
public ApiVersionInserter build() {
return new DefaultApiVersionInserter(
this.header, this.queryParam, this.mediaTypeParam, this.pathSegmentIndex,

View File

@ -389,6 +389,7 @@ public class StandardServletAsyncWebRequest extends ServletWebRequest implements
}
}
@Override
public void write(byte[] buf, int offset, int len) throws IOException {
int level = this.response.obtainLockOrRaiseException();
try {

View File

@ -117,6 +117,7 @@ public class RestClientProxyRegistryIntegrationTests {
void beansAreCreatedUsingBeanClassLoader() {
ClassLoader beanClassLoader = new OverridingClassLoader(getClass().getClassLoader()) {
@Override
protected boolean isEligibleForOverriding(String className) {
return className.contains("EchoA");
};

View File

@ -137,6 +137,7 @@ class WebAsyncManagerTests {
}
@Test // gh-30232
@SuppressWarnings("serial")
void startCallableProcessingSubmitException() throws Exception {
RuntimeException ex = new RuntimeException();

View File

@ -50,6 +50,7 @@ class OncePerRequestFilterTests {
@BeforeEach
@SuppressWarnings("serial")
public void setup() throws Exception {
this.request = new MockHttpServletRequest();
this.request.setScheme("http");

View File

@ -642,7 +642,7 @@ public class MockHttpServletResponse implements HttpServletResponse {
sendRedirect(url, HttpServletResponse.SC_MOVED_TEMPORARILY, true);
}
// @Override - on Servlet 6.1
@Override
public void sendRedirect(String url, int sc, boolean clearBuffer) throws IOException {
Assert.state(!isCommitted(), "Cannot send redirect - response is already committed");
Assert.notNull(url, "Redirect URL must not be null");

View File

@ -164,6 +164,7 @@ public class DefaultApiVersionStrategy implements ApiVersionStrategy {
return this.versionParser.parseVersion(version);
}
@Override
public void validateVersion(@Nullable Comparable<?> requestVersion, ServerWebExchange exchange)
throws MissingApiVersionException, InvalidApiVersionException {

View File

@ -693,7 +693,7 @@ class DefaultServerRequest implements ServerRequest {
throw new UnsupportedOperationException();
}
// @Override - on Servlet 6.1
@Override
public void sendRedirect(String location, int sc, boolean clearBuffer) throws IOException {
throw new UnsupportedOperationException();
}

View File

@ -222,6 +222,7 @@ public class HandlerMappingIntrospector
* @throws NoHandlerFoundException if no handler matches the request
* @since 6.2
*/
@Override
public void handlePreFlight(HttpServletRequest request, HttpServletResponse response) throws Exception {
Assert.state(this.handlerMappings != null, "Not yet initialized via afterPropertiesSet.");
Assert.state(CorsUtils.isPreFlightRequest(request), "Not a pre-flight request.");

View File

@ -791,6 +791,7 @@ class DispatcherServletTests {
assertThat(servlet.getEnvironment()).isSameAs(env1);
assertThatIllegalArgumentException().isThrownBy(() -> servlet.setEnvironment(mock(Environment.class)));
class CustomServletEnvironment extends StandardServletEnvironment { }
@SuppressWarnings("serial")
DispatcherServlet custom = new DispatcherServlet() {
@Override
protected ConfigurableWebEnvironment createEnvironment() {

View File

@ -439,6 +439,7 @@ class WebMvcConfigurationSupportExtensionTests {
}
@Override
@SuppressWarnings("serial")
public MessageCodesResolver getMessageCodesResolver() {
return new DefaultMessageCodesResolver() {
@Override

View File

@ -80,6 +80,7 @@ class CglibProxyControllerTests {
}
@SuppressWarnings("serial")
private void initServlet(final Class<?> controllerClass) throws ServletException {
servlet = new DispatcherServlet() {
@Override

View File

@ -78,6 +78,7 @@ class JdkProxyControllerTests {
}
@SuppressWarnings("serial")
private void initServlet(final Class<?> controllerclass) throws ServletException {
servlet = new DispatcherServlet() {
@Override

View File

@ -67,6 +67,7 @@ public abstract class AbstractServletHandlerMethodTests {
return initDispatcherServlet(controllerClass, usePathPatterns, null);
}
@SuppressWarnings("serial")
WebApplicationContext initDispatcherServlet(
@Nullable Class<?> controllerClass, boolean usePathPatterns,
@Nullable ApplicationContextInitializer<GenericWebApplicationContext> initializer)

View File

@ -1004,6 +1004,7 @@ class BindTagTests extends AbstractTagTests {
binder.registerCustomEditor(Date.class, l);
pc.getRequest().setAttribute(BindingResult.MODEL_KEY_PREFIX + "tb", binder.getBindingResult());
@SuppressWarnings("serial")
FormTag formTag = new FormTag() {
@Override
protected TagWriter createTagWriter() {

View File

@ -31,6 +31,7 @@ import static org.assertj.core.api.Assertions.assertThat;
* @author Juergen Hoeller
* @author Alef Arendsen
*/
@SuppressWarnings("serial")
class HtmlEscapeTagTests extends AbstractTagTests {
@Test

View File

@ -39,6 +39,7 @@ import static org.assertj.core.api.Assertions.assertThat;
* @author Alef Arendsen
* @author Nicholas Williams
*/
@SuppressWarnings("serial")
class MessageTagTests extends AbstractTagTests {
@Test

View File

@ -85,6 +85,7 @@ class ButtonTagTests extends AbstractFormTagTests {
assertThat(output).as("Tag not opened properly").startsWith("<button ");
}
@SuppressWarnings("serial")
protected ButtonTag createTag(final Writer writer) {
return new ButtonTag() {
@Override

View File

@ -54,6 +54,7 @@ class CheckboxTagTests extends AbstractFormTagTests {
private TestBean bean;
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new CheckboxTag() {
@Override

View File

@ -62,6 +62,7 @@ public class CheckboxesTagTests extends AbstractFormTagTests {
private TestBean bean;
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new CheckboxesTag() {
@Override

View File

@ -54,6 +54,7 @@ public class ErrorsTagTests extends AbstractFormTagTests {
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new ErrorsTag() {
@Override

View File

@ -49,6 +49,7 @@ class FormTagTests extends AbstractHtmlElementTagTests {
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new FormTag() {
@Override

View File

@ -35,6 +35,7 @@ class HiddenInputTagTests extends AbstractFormTagTests {
private TestBean bean;
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new HiddenInputTag() {
@Override

View File

@ -395,6 +395,7 @@ class InputTagTests extends AbstractFormTagTests {
assertThat(output).as("Tag not opened properly").startsWith("<input ");
}
@SuppressWarnings("serial")
protected InputTag createTag(final Writer writer) {
return new InputTag() {
@Override

View File

@ -38,6 +38,7 @@ class LabelTagTests extends AbstractFormTagTests {
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new LabelTag() {
@Override

View File

@ -36,6 +36,7 @@ class OptionTagEnumTests extends AbstractHtmlElementTagTests {
private SelectTag parentTag;
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new OptionTag() {
@Override

View File

@ -57,6 +57,7 @@ class OptionTagTests extends AbstractHtmlElementTagTests {
private SelectTag parentTag;
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new OptionTag() {
@Override

View File

@ -60,6 +60,7 @@ class OptionsTagTests extends AbstractHtmlElementTagTests {
private OptionsTag tag;
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new OptionsTag() {
@Override

View File

@ -46,6 +46,7 @@ class RadioButtonTagTests extends AbstractFormTagTests {
private TestBean bean;
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new RadioButtonTag() {
@Override

View File

@ -58,6 +58,7 @@ public class RadioButtonsTagTests extends AbstractFormTagTests {
private TestBean bean;
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new RadioButtonsTag() {
@Override

View File

@ -67,6 +67,7 @@ public class SelectTagTests extends AbstractFormTagTests {
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new SelectTag() {
@Override

View File

@ -37,6 +37,7 @@ class TextareaTagTests extends AbstractFormTagTests {
private TestBean rob;
@Override
@SuppressWarnings("serial")
protected void onSetUp() {
this.tag = new TextareaTag() {
@Override