root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Fix lambda nullability in JdbcOperations extensions 

Closes gh-22682
This commit is contained in:
Sebastien Deleuze 2019-03-26 14:29:41 +01:00
parent fd6b64bfac
commit 0ca8428603
2 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spring-jdbc/src/main/kotlin/org/springframework/jdbc/core/JdbcOperationsExtensions.kt
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2017 the original author or authors * Copyright 2002-2019 the original author or authors
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -34,7 +34,7 @@ inline fun <reified T : Any> JdbcOperations.queryForObject(sql: String): T? =
* @author Mario Arias * @author Mario Arias
* @since 5.0 * @since 5.0
*/ */
fun <T : Any> JdbcOperations.queryForObject(sql: String, vararg args: Any, function: (ResultSet, Int) -> T): T? = fun <T : Any?> JdbcOperations.queryForObject(sql: String, vararg args: Any, function: (ResultSet, Int) -> T): T? =
queryForObject(sql, RowMapper { resultSet, i -> function(resultSet, i) }, *args) queryForObject(sql, RowMapper { resultSet, i -> function(resultSet, i) }, *args)
/** /**
@ -96,7 +96,7 @@ inline fun <reified T : Any> JdbcOperations.queryForList(sql: String, args: Arra
* @author Mario Arias * @author Mario Arias
* @since 5.0 * @since 5.0
*/ */
inline fun <reified T : Any> JdbcOperations.query(sql: String, vararg args: Any, inline fun <reified T : Any?> JdbcOperations.query(sql: String, vararg args: Any,
crossinline function: (ResultSet) -> T): T? = crossinline function: (ResultSet) -> T): T? =
query(sql, ResultSetExtractor { function(it) }, *args) query(sql, ResultSetExtractor { function(it) }, *args)

16
spring-jdbc/src/test/kotlin/org/springframework/jdbc/core/JdbcOperationsExtensionsTests.kt
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2017 the original author or authors * Copyright 2002-2019 the original author or authors
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -51,6 +51,13 @@ class JdbcOperationsExtensionsTests {
verify(template, times(1)).queryForObject(eq(sql), any<RowMapper<Int>>(), eq(3)) verify(template, times(1)).queryForObject(eq(sql), any<RowMapper<Int>>(), eq(3))
} }
@Test // gh-22682
fun `queryForObject with nullable RowMapper-like function`() {
val sql = "select age from customer where id = ?"
template.queryForObject(sql, 3) { _, _ -> null as Int? }
verify(template, times(1)).queryForObject(eq(sql), any<RowMapper<Int?>>(), eq(3))
}
@Test @Test
fun `queryForObject with reified type parameters and argTypes`() { fun `queryForObject with reified type parameters and argTypes`() {
val sql = "select age from customer where id = ?" val sql = "select age from customer where id = ?"
@ -102,6 +109,13 @@ class JdbcOperationsExtensionsTests {
verify(template, times(1)).query(eq(sql), any<ResultSetExtractor<Int>>(), eq(3)) verify(template, times(1)).query(eq(sql), any<ResultSetExtractor<Int>>(), eq(3))
} }
@Test // gh-22682
fun `query with nullable ResultSetExtractor-like function`() {
val sql = "select age from customer where id = ?"
template.query<Int?>(sql, 3) { _ -> null }
verify(template, times(1)).query(eq(sql), any<ResultSetExtractor<Int?>>(), eq(3))
}
@Test @Test
fun `query with RowCallbackHandler-like function`() { fun `query with RowCallbackHandler-like function`() {
val sql = "select age from customer where id = ?" val sql = "select age from customer where id = ?"