root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Polishing

This commit is contained in:
Juergen Hoeller 2022-04-13 00:24:23 +02:00
parent 949c3d450c
commit 0cf7f7bd89
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
spring-web/src/test/java/org/springframework/web/method/annotation/ModelAttributeMethodProcessorTests.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2020 the original author or authors. * Copyright 2002-2022 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -269,7 +269,7 @@ public class ModelAttributeMethodProcessorTests {
assertThat(this.container.getModel().get("testBean")).isSameAs(testBean); assertThat(this.container.getModel().get("testBean")).isSameAs(testBean);
} }
@Test // gh-25182 @Test // gh-25182
public void resolveConstructorListArgumentFromCommaSeparatedRequestParameter() throws Exception { public void resolveConstructorListArgumentFromCommaSeparatedRequestParameter() throws Exception {
MockHttpServletRequest mockRequest = new MockHttpServletRequest(); MockHttpServletRequest mockRequest = new MockHttpServletRequest();
mockRequest.addParameter("listOfStrings", "1,2"); mockRequest.addParameter("listOfStrings", "1,2");
@ -279,7 +279,6 @@ public class ModelAttributeMethodProcessorTests {
given(factory.createBinder(any(), any(), eq("testBeanWithConstructorArgs"))) given(factory.createBinder(any(), any(), eq("testBeanWithConstructorArgs")))
.willAnswer(invocation -> { .willAnswer(invocation -> {
WebRequestDataBinder binder = new WebRequestDataBinder(invocation.getArgument(1)); WebRequestDataBinder binder = new WebRequestDataBinder(invocation.getArgument(1));
// Add conversion service which will convert "1,2" to a list // Add conversion service which will convert "1,2" to a list
binder.setConversionService(new DefaultFormattingConversionService()); binder.setConversionService(new DefaultFormattingConversionService());
return binder; return binder;
@ -309,7 +308,6 @@ public class ModelAttributeMethodProcessorTests {
private boolean validateInvoked; private boolean validateInvoked;
public StubRequestDataBinder(Object target, String objectName) { public StubRequestDataBinder(Object target, String objectName) {
super(target, objectName); super(target, objectName);
} }
@ -345,7 +343,7 @@ public class ModelAttributeMethodProcessorTests {
} }
@SessionAttributes(types=TestBean.class) @SessionAttributes(types = TestBean.class)
private static class ModelAttributeHandler { private static class ModelAttributeHandler {
@SuppressWarnings("unused") @SuppressWarnings("unused")
@ -360,6 +358,7 @@ public class ModelAttributeMethodProcessorTests {
} }
} }
static class TestBeanWithConstructorArgs { static class TestBeanWithConstructorArgs {
final List<String> listOfStrings; final List<String> listOfStrings;
@ -367,15 +366,15 @@ public class ModelAttributeMethodProcessorTests {
public TestBeanWithConstructorArgs(List<String> listOfStrings) { public TestBeanWithConstructorArgs(List<String> listOfStrings) {
this.listOfStrings = listOfStrings; this.listOfStrings = listOfStrings;
} }
} }
@ModelAttribute("modelAttrName") @SuppressWarnings("unused")
@ModelAttribute("modelAttrName")
@SuppressWarnings("unused")
private String annotatedReturnValue() { private String annotatedReturnValue() {
return null; return null;
} }
@SuppressWarnings("unused") @SuppressWarnings("unused")
private TestBean notAnnotatedReturnValue() { private TestBean notAnnotatedReturnValue() {
return null; return null;

4
spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ServletAnnotationControllerHandlerMethodTests.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2021 the original author or authors. * Copyright 2002-2022 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -2236,6 +2236,7 @@ public class ServletAnnotationControllerHandlerMethodTests extends AbstractServl
assertThat(response.getContentAsString()).isEqualTo("foo-body"); assertThat(response.getContentAsString()).isEqualTo("foo-body");
} }
@Controller @Controller
static class ControllerWithEmptyValueMapping { static class ControllerWithEmptyValueMapping {
@ -3573,7 +3574,6 @@ public class ServletAnnotationControllerHandlerMethodTests extends AbstractServl
assertThat(headers.getContentType()).as("Invalid Content-Type").isEqualTo(new MediaType("text", "html")); assertThat(headers.getContentType()).as("Invalid Content-Type").isEqualTo(new MediaType("text", "html"));
multiValueMap(headers, writer); multiValueMap(headers, writer);
} }
} }
@Controller @Controller