root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Make QDox an implementation detail of spring-core-test 

Previously, com.thoughtworks.qdox:qdox was declared as an api
dependency of spring-core-test despite it only being used in the
module's internals. This resulted in it unnecessarily appearing on the
compile classpath of consuming projects.

This commit moves qdox to be an implementation dependency, removing it
from the compile classpath of consuming projects but ensuring that it's
still available at runtime.

Closes gh-29066
This commit is contained in:
Andy Wilkinson 2022-09-03 08:23:20 +01:00 committed by Sam Brannen
parent f50c301387
commit 0daaa1c38a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spring-core-test/spring-core-test.gradle
View File

@ -4,10 +4,10 @@ dependencies {
api(project(":spring-core")) api(project(":spring-core"))
api("org.junit.jupiter:junit-jupiter-api") api("org.junit.jupiter:junit-jupiter-api")
api("org.assertj:assertj-core") api("org.assertj:assertj-core")
api("com.thoughtworks.qdox:qdox")
compileOnly("org.junit.jupiter:junit-jupiter") compileOnly("org.junit.jupiter:junit-jupiter")
compileOnly("org.junit.platform:junit-platform-engine") compileOnly("org.junit.platform:junit-platform-engine")
compileOnly("org.junit.platform:junit-platform-launcher") compileOnly("org.junit.platform:junit-platform-launcher")
implementation("com.thoughtworks.qdox:qdox")
} }
jar { jar {