From 1259b7cb49d264bc789ea1111a13e433513c81f5 Mon Sep 17 00:00:00 2001 From: Sam Brannen Date: Wed, 5 Jun 2019 14:41:14 +0300 Subject: [PATCH] Polishing --- ...currentWebSocketSessionDecoratorTests.java | 28 +++++++------------ 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/spring-websocket/src/test/java/org/springframework/web/socket/handler/ConcurrentWebSocketSessionDecoratorTests.java b/spring-websocket/src/test/java/org/springframework/web/socket/handler/ConcurrentWebSocketSessionDecoratorTests.java index 9003d9f63e3..f3f76afb1ba 100644 --- a/spring-websocket/src/test/java/org/springframework/web/socket/handler/ConcurrentWebSocketSessionDecoratorTests.java +++ b/spring-websocket/src/test/java/org/springframework/web/socket/handler/ConcurrentWebSocketSessionDecoratorTests.java @@ -66,7 +66,7 @@ public class ConcurrentWebSocketSessionDecoratorTests { BlockingSession session = new BlockingSession(); session.setOpen(true); - final ConcurrentWebSocketSessionDecorator decorator = + ConcurrentWebSocketSessionDecorator decorator = new ConcurrentWebSocketSessionDecorator(session, 10 * 1000, 1024); sendBlockingMessage(decorator); @@ -91,7 +91,7 @@ public class ConcurrentWebSocketSessionDecoratorTests { session.setId("123"); session.setOpen(true); - final ConcurrentWebSocketSessionDecorator decorator = + ConcurrentWebSocketSessionDecorator decorator = new ConcurrentWebSocketSessionDecorator(session, 100, 1024); sendBlockingMessage(decorator); @@ -113,17 +113,13 @@ public class ConcurrentWebSocketSessionDecoratorTests { session.setId("123"); session.setOpen(true); - final ConcurrentWebSocketSessionDecorator decorator = + ConcurrentWebSocketSessionDecorator decorator = new ConcurrentWebSocketSessionDecorator(session, 10*1000, 1024); sendBlockingMessage(decorator); - StringBuilder sb = new StringBuilder(); - for (int i = 0 ; i < 1023; i++) { - sb.append("a"); - } - - TextMessage message = new TextMessage(sb.toString()); + String msg = String.format("%1023s", "a"); + TextMessage message = new TextMessage(msg); decorator.sendMessage(message); assertThat(decorator.getBufferSize()).isEqualTo(1023); @@ -142,24 +138,20 @@ public class ConcurrentWebSocketSessionDecoratorTests { session.setId("123"); session.setOpen(true); - final ConcurrentWebSocketSessionDecorator decorator = + ConcurrentWebSocketSessionDecorator decorator = new ConcurrentWebSocketSessionDecorator(session, 10*1000, 1024, OverflowStrategy.DROP); sendBlockingMessage(decorator); - StringBuilder sb = new StringBuilder(); - for (int i = 0 ; i < 1023; i++) { - sb.append("a"); - } + String msg = String.format("%1023s", "a"); - for (int i=0; i < 5; i++) { - TextMessage message = new TextMessage(sb.toString()); + for (int i = 0; i < 5; i++) { + TextMessage message = new TextMessage(msg); decorator.sendMessage(message); } assertThat(decorator.getBufferSize()).isEqualTo(1023); assertThat(session.isOpen()).isTrue(); - } @Test @@ -187,7 +179,7 @@ public class ConcurrentWebSocketSessionDecoratorTests { int sendTimeLimit = 100; int bufferSizeLimit = 1024; - final ConcurrentWebSocketSessionDecorator decorator = + ConcurrentWebSocketSessionDecorator decorator = new ConcurrentWebSocketSessionDecorator(session, sendTimeLimit, bufferSizeLimit); Executors.newSingleThreadExecutor().submit((Runnable) () -> {