root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 4 Packages Projects Releases Wiki Activity

[CRaC] Fix hangup after restoring 

Signed-off-by: Yasumasa Suenaga <yasuenag@gmail.com>
This commit is contained in:
Yasumasa Suenaga 2025-02-06 12:06:58 +09:00
parent e44a3eb39a
commit 13fbbd1020
1 changed files with 26 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
spring-context/src/main/java/org/springframework/context/support/DefaultLifecycleProcessor.java
View File

@ -589,22 +589,20 @@ public class DefaultLifecycleProcessor implements LifecycleProcessor, BeanFactor
*/
private class CracResourceAdapter implements org.crac.Resource {
private @Nullable CyclicBarrier barrier;
private CyclicBarrier stepToRestore = new CyclicBarrier(2);
private CyclicBarrier finishRestore = new CyclicBarrier(2);
private void preventShutdown() {
waitBarrier(this.stepToRestore);
// Checkpoint happens here
waitBarrier(this.finishRestore);
}
@Override
public void beforeCheckpoint(org.crac.Context<? extends org.crac.Resource> context) {
// A non-daemon thread for preventing an accidental JVM shutdown before the checkpoint
this.barrier = new CyclicBarrier(2);
Thread thread = new Thread(() -> {
awaitPreventShutdownBarrier();
// Checkpoint happens here
awaitPreventShutdownBarrier();
}, "prevent-shutdown");
Thread thread = new Thread(this::preventShutdown, "prevent-shutdown");
thread.setDaemon(false);
thread.start();
awaitPreventShutdownBarrier();
logger.debug("Stopping Spring-managed lifecycle beans before JVM checkpoint");
stopForRestart();
@ -612,11 +610,24 @@ public class DefaultLifecycleProcessor implements LifecycleProcessor, BeanFactor
@Override
public void afterRestore(org.crac.Context<? extends org.crac.Resource> context) {
// Unlock barrier for beforeCheckpoint
try {
this.stepToRestore.await();
}
catch (Exception ex) {
logger.trace("Exception from stepToRestore barrier", ex);
}
logger.info("Restarting Spring-managed lifecycle beans after JVM restore");
restartAfterStop();
// Barrier for prevent-shutdown thread not needed anymore
this.barrier = null;
// Unlock barrier for afterRestore to shutdown "prevent-shutdown" thread
try {
this.finishRestore.await();
}
catch (Exception ex) {
logger.trace("Exception from stepToRestore barrier", ex);
}
if (!checkpointOnRefresh) {
logger.info("Spring-managed lifecycle restart completed (restored JVM running for " +
@ -624,11 +635,9 @@ public class DefaultLifecycleProcessor implements LifecycleProcessor, BeanFactor
}
}
private void awaitPreventShutdownBarrier() {
private void waitBarrier(CyclicBarrier barrier) {
try {
if (this.barrier != null) {
this.barrier.await();
}
barrier.await();
}
catch (Exception ex) {
logger.trace("Exception from prevent-shutdown barrier", ex);