root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Added test for SpringProperties setFlag method 

Issue: SPR-9014
Issue: SPR-11297
This commit is contained in:
Juergen Hoeller 2014-01-24 17:48:40 +01:00
parent 341d645d09
commit 23249cda98
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spring-core/src/main/java/org/springframework/core/SpringProperties.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2013 the original author or authors. * Copyright 2002-2014 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -44,6 +44,8 @@ import org.apache.commons.logging.LogFactory;
*/ */
public abstract class SpringProperties { public abstract class SpringProperties {
private static final String PROPERTIES_RESOURCE_LOCATION = "spring.properties";
private static final Log logger = LogFactory.getLog(SpringProperties.class); private static final Log logger = LogFactory.getLog(SpringProperties.class);
private static final Properties localProperties = new Properties(); private static final Properties localProperties = new Properties();
@ -52,7 +54,7 @@ public abstract class SpringProperties {
static { static {
try { try {
ClassLoader cl = SpringProperties.class.getClassLoader(); ClassLoader cl = SpringProperties.class.getClassLoader();
URL url = cl.getResource("spring.properties"); URL url = cl.getResource(PROPERTIES_RESOURCE_LOCATION);
if (url != null) { if (url != null) {
logger.info("Found 'spring.properties' file in local classpath"); logger.info("Found 'spring.properties' file in local classpath");
InputStream is = url.openStream(); InputStream is = url.openStream();

9
spring-core/src/test/java/org/springframework/core/env/StandardEnvironmentTests.java vendored
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2013 the original author or authors. * Copyright 2002-2014 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -354,6 +354,13 @@ public class StandardEnvironmentTests {
SpringProperties.setProperty("spring.getenv.ignore", null); SpringProperties.setProperty("spring.getenv.ignore", null);
} }
@Test
public void suppressGetenvAccessThroughSpringFlag() {
SpringProperties.setFlag("spring.getenv.ignore");
assertTrue(environment.getSystemEnvironment().isEmpty());
SpringProperties.setProperty("spring.getenv.ignore", null);
}
@Test @Test
public void getSystemProperties_withAndWithoutSecurityManager() { public void getSystemProperties_withAndWithoutSecurityManager() {
System.setProperty(ALLOWED_PROPERTY_NAME, ALLOWED_PROPERTY_VALUE); System.setProperty(ALLOWED_PROPERTY_NAME, ALLOWED_PROPERTY_VALUE);