Polishing

This commit is contained in:
Juergen Hoeller 2025-07-13 16:33:37 +02:00
parent 4063cb5b9a
commit 2434bb1540
5 changed files with 23 additions and 12 deletions

View File

@ -128,6 +128,7 @@ final class ConfigurationClass {
* @param metadata the metadata for the underlying class to represent
* @param beanName name of the {@code @Configuration} class bean
* @param scanned whether the underlying class has been registered through a scan
* @since 6.2
*/
ConfigurationClass(AnnotationMetadata metadata, String beanName, boolean scanned) {
Assert.notNull(beanName, "Bean name must not be null");

View File

@ -18,10 +18,7 @@ package org.springframework.context.annotation;
import java.lang.reflect.Constructor;
import java.lang.reflect.Method;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
@ -194,13 +191,19 @@ class ConfigurationClassBeanDefinitionReader {
AnnotationAttributes bean = AnnotationConfigUtils.attributesFor(metadata, Bean.class);
Assert.state(bean != null, "No @Bean annotation attributes");
// Consider name and any aliases
List<String> names = new ArrayList<>(Arrays.asList(bean.getStringArray("name")));
String beanName = (!names.isEmpty() ? names.remove(0) : methodName);
// Register aliases even when overridden
for (String alias : names) {
this.registry.registerAlias(beanName, alias);
// Consider name and any aliases.
String[] explicitNames = bean.getStringArray("name");
String beanName;
if (explicitNames.length > 0) {
beanName = explicitNames[0];
// Register aliases even when overridden below.
for (int i = 1; i < explicitNames.length; i++) {
this.registry.registerAlias(beanName, explicitNames[i]);
}
}
else {
// Default bean name derived from method name.
beanName = methodName;
}
// Has this effectively been overridden before (for example, via XML)?

View File

@ -64,8 +64,7 @@ class ConfigurationBeanNameTests {
AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
ctx.setBeanNameGenerator(new AnnotationBeanNameGenerator() {
@Override
public String generateBeanName(
BeanDefinition definition, BeanDefinitionRegistry registry) {
public String generateBeanName(BeanDefinition definition, BeanDefinitionRegistry registry) {
return "custom-" + super.generateBeanName(definition, registry);
}
});
@ -78,17 +77,22 @@ class ConfigurationBeanNameTests {
ctx.close();
}
@Configuration("outer")
@Import(C.class)
static class A {
@Component("nested")
static class B {
@Bean public String nestedBean() { return ""; }
}
}
@Configuration("imported")
static class C {
@Bean public String s() { return "s"; }
}

View File

@ -20,4 +20,5 @@ import org.springframework.stereotype.Component;
@Component
public class ComponentForScanning {
}

View File

@ -22,8 +22,10 @@ import org.springframework.context.annotation.Configuration;
@Configuration
public class ConfigForScanning {
@Bean
public TestBean testBean() {
return new TestBean();
}
}