root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Remove flaky executesHugeScriptInReasonableTime() tests 

These tests often fail on the CI server and do not provide any
meaningful information when they fail, since only a proper benchmark
would suffice. Furthermore, the test method was introduced 10 years
ago to address deficiencies in JDK 7 which no longer exist.

See gh-14415
This commit is contained in:
Sam Brannen 2022-09-08 13:18:05 +02:00
parent f5bc182ba7
commit 261124f497
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
spring-jdbc/src/test/java/org/springframework/jdbc/datasource/init/AbstractDatabasePopulatorTests.java
View File

@ -1,5 +1,5 @@
/*
* Copyright 2002-2019 the original author or authors.
* Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -20,7 +20,6 @@ import java.sql.Connection;
import java.sql.SQLException;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.Timeout;
import org.springframework.jdbc.datasource.DataSourceUtils;
import org.springframework.transaction.support.TransactionSynchronizationManager;
@ -175,17 +174,6 @@ abstract class AbstractDatabasePopulatorTests extends AbstractDatabaseInitializa
verify(populator).populate(connection);
}
/**
* See SPR-9781
*/
@Test
@Timeout(1)
void executesHugeScriptInReasonableTime() throws SQLException {
databasePopulator.addScript(defaultSchema());
databasePopulator.addScript(resource("db-test-data-huge.sql"));
DatabasePopulatorUtils.execute(databasePopulator, db);
}
private void assertTestDatabaseCreated() {
assertTestDatabaseCreated("Keith");
}