From 2bee329d1e0ccab4083e1b4031fbea016b170f05 Mon Sep 17 00:00:00 2001 From: Sam Brannen Date: Mon, 28 Mar 2011 19:01:33 +0000 Subject: [PATCH] [SPR-8089] Added TODOs. git-svn-id: https://src.springframework.org/svn/spring-framework/trunk@4126 50f2f4bb-b051-0410-bef5-90022cba6387 --- .../jmx/access/MBeanClientInterceptorTests.java | 2 ++ .../jmx/access/RemoteMBeanClientInterceptorTests.java | 2 ++ .../jmx/support/ConnectorServerFactoryBeanTests.java | 2 ++ .../jmx/support/MBeanServerConnectionFactoryBeanTests.java | 4 ++++ 4 files changed, 10 insertions(+) diff --git a/org.springframework.context/src/test/java/org/springframework/jmx/access/MBeanClientInterceptorTests.java b/org.springframework.context/src/test/java/org/springframework/jmx/access/MBeanClientInterceptorTests.java index 14d4bb2bfd3..a6af50e1325 100644 --- a/org.springframework.context/src/test/java/org/springframework/jmx/access/MBeanClientInterceptorTests.java +++ b/org.springframework.context/src/test/java/org/springframework/jmx/access/MBeanClientInterceptorTests.java @@ -186,6 +186,8 @@ public class MBeanClientInterceptorTests extends AbstractMBeanServerTests { } } + // TODO [SPR-8089] Clean up ignored JMX tests. + // // @Ignore should have no effect for JUnit 3.8 tests; however, it appears // that tests on the CI server -- as well as those in Eclipse -- do in // fact get ignored. So we leave @Ignore here so that developers can diff --git a/org.springframework.context/src/test/java/org/springframework/jmx/access/RemoteMBeanClientInterceptorTests.java b/org.springframework.context/src/test/java/org/springframework/jmx/access/RemoteMBeanClientInterceptorTests.java index 53c82f96316..751884998a7 100644 --- a/org.springframework.context/src/test/java/org/springframework/jmx/access/RemoteMBeanClientInterceptorTests.java +++ b/org.springframework.context/src/test/java/org/springframework/jmx/access/RemoteMBeanClientInterceptorTests.java @@ -31,6 +31,8 @@ import org.junit.Ignore; /** * @author Rob Harrop */ +// TODO [SPR-8089] Clean up ignored JMX tests. +// // @Ignore should have no effect for JUnit 3.8 tests; however, it appears // that tests on the CI server -- as well as those in Eclipse -- do in // fact get ignored. So we leave @Ignore here so that developers can diff --git a/org.springframework.context/src/test/java/org/springframework/jmx/support/ConnectorServerFactoryBeanTests.java b/org.springframework.context/src/test/java/org/springframework/jmx/support/ConnectorServerFactoryBeanTests.java index 709a2771955..5d7cce5ed17 100644 --- a/org.springframework.context/src/test/java/org/springframework/jmx/support/ConnectorServerFactoryBeanTests.java +++ b/org.springframework.context/src/test/java/org/springframework/jmx/support/ConnectorServerFactoryBeanTests.java @@ -34,6 +34,8 @@ import org.springframework.jmx.AbstractMBeanServerTests; /** * @author Rob Harrop */ +// TODO [SPR-8089] Clean up ignored JMX tests. +// // @Ignore should have no effect for JUnit 3.8 tests; however, it appears // that tests on the CI server -- as well as those in Eclipse -- do in // fact get ignored. So we leave @Ignore here so that developers can diff --git a/org.springframework.context/src/test/java/org/springframework/jmx/support/MBeanServerConnectionFactoryBeanTests.java b/org.springframework.context/src/test/java/org/springframework/jmx/support/MBeanServerConnectionFactoryBeanTests.java index c7c1736ca2a..56244c74a4f 100644 --- a/org.springframework.context/src/test/java/org/springframework/jmx/support/MBeanServerConnectionFactoryBeanTests.java +++ b/org.springframework.context/src/test/java/org/springframework/jmx/support/MBeanServerConnectionFactoryBeanTests.java @@ -43,6 +43,8 @@ public class MBeanServerConnectionFactoryBeanTests extends AbstractMBeanServerTe return JMXConnectorServerFactory.newJMXConnectorServer(getServiceUrl(), null, getServer()); } + // TODO [SPR-8089] Clean up ignored JMX tests. + // // @Ignore should have no effect for JUnit 3.8 tests; however, it appears // that tests on the CI server -- as well as those in Eclipse -- do in // fact get ignored. So we leave @Ignore here so that developers can @@ -83,6 +85,8 @@ public class MBeanServerConnectionFactoryBeanTests extends AbstractMBeanServerTe } } + // TODO [SPR-8089] Clean up ignored JMX tests. + // // @Ignore should have no effect for JUnit 3.8 tests; however, it appears // that tests on the CI server -- as well as those in Eclipse -- do in // fact get ignored. So we leave @Ignore here so that developers can