root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Fix handling of @EnableLoadTimeWeaving AUTODETECT 

Issue: SPR-8643
This commit is contained in:
Chris Beams 2011-09-03 22:37:16 +00:00
parent 4e522c0cc3
commit 2e5f3559d3
2 changed files with 57 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
org.springframework.context/src/main/java/org/springframework/context/annotation/LoadTimeWeavingConfiguration.java
View File

@ -84,7 +84,7 @@ public class LoadTimeWeavingConfiguration implements ImportAware, BeanClassLoade
// AJ weaving is disabled -> do nothing // AJ weaving is disabled -> do nothing
break; break;
case AUTODETECT: case AUTODETECT:
if (this.beanClassLoader.getResource(ASPECTJ_AOP_XML_RESOURCE) != null) { if (this.beanClassLoader.getResource(ASPECTJ_AOP_XML_RESOURCE) == null) {
// No aop.xml present on the classpath -> treat as 'disabled' // No aop.xml present on the classpath -> treat as 'disabled'
break; break;
} }

63
org.springframework.context/src/test/java/org/springframework/context/annotation/EnableLoadTimeWeavingTests.java
View File

@ -16,10 +16,17 @@
package org.springframework.context.annotation; package org.springframework.context.annotation;
import static org.easymock.EasyMock.createMock;
import static org.easymock.EasyMock.expectLastCall;
import static org.easymock.EasyMock.isA;
import static org.easymock.EasyMock.replay;
import java.lang.instrument.ClassFileTransformer;
import org.junit.Test; import org.junit.Test;
import org.springframework.context.annotation.EnableLoadTimeWeaving.AspectJWeaving;
import org.springframework.context.support.GenericXmlApplicationContext; import org.springframework.context.support.GenericXmlApplicationContext;
import org.springframework.instrument.classloading.LoadTimeWeaver; import org.springframework.instrument.classloading.LoadTimeWeaver;
import org.springframework.instrument.classloading.SimpleLoadTimeWeaver;
/** /**
* Unit tests for @EnableLoadTimeWeaving * Unit tests for @EnableLoadTimeWeaving
@ -37,19 +44,61 @@ public class EnableLoadTimeWeavingTests {
} }
@Test @Test
public void test() { public void enableLTW_withAjWeavingDisabled() {
AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext(); AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
ctx.register(Config.class); ctx.register(EnableLTWConfig_withAjWeavingDisabled.class);
ctx.refresh();
ctx.getBean("loadTimeWeaver");
}
@Test
public void enableLTW_withAjWeavingAutodetect() {
AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
ctx.register(EnableLTWConfig_withAjWeavingAutodetect.class);
ctx.refresh();
ctx.getBean("loadTimeWeaver");
}
@Test
public void enableLTW_withAjWeavingEnabled() {
AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
ctx.register(EnableLTWConfig_withAjWeavingEnabled.class);
ctx.refresh(); ctx.refresh();
ctx.getBean("loadTimeWeaver"); ctx.getBean("loadTimeWeaver");
} }
@Configuration @Configuration
@EnableLoadTimeWeaving @EnableLoadTimeWeaving(aspectjWeaving=AspectJWeaving.DISABLED)
static class Config implements LoadTimeWeavingConfigurer { static class EnableLTWConfig_withAjWeavingDisabled implements LoadTimeWeavingConfigurer {
public LoadTimeWeaver getLoadTimeWeaver() { public LoadTimeWeaver getLoadTimeWeaver() {
return new SimpleLoadTimeWeaver(); LoadTimeWeaver mockLTW = createMock(LoadTimeWeaver.class);
// no expectations -> a class file transformer should NOT be added
replay(mockLTW);
return mockLTW;
}
}
@Configuration
@EnableLoadTimeWeaving(aspectjWeaving=AspectJWeaving.AUTODETECT)
static class EnableLTWConfig_withAjWeavingAutodetect implements LoadTimeWeavingConfigurer {
public LoadTimeWeaver getLoadTimeWeaver() {
LoadTimeWeaver mockLTW = createMock(LoadTimeWeaver.class);
// no expectations -> a class file transformer should NOT be added
// because no META-INF/aop.xml is present on the classpath
replay(mockLTW);
return mockLTW;
}
}
@Configuration
@EnableLoadTimeWeaving(aspectjWeaving=AspectJWeaving.ENABLED)
static class EnableLTWConfig_withAjWeavingEnabled implements LoadTimeWeavingConfigurer {
public LoadTimeWeaver getLoadTimeWeaver() {
LoadTimeWeaver mockLTW = createMock(LoadTimeWeaver.class);
mockLTW.addTransformer(isA(ClassFileTransformer.class));
expectLastCall();
replay(mockLTW);
return mockLTW;
} }
} }
} }