From 1b1ba479125ecd1051d14742d89f492376176130 Mon Sep 17 00:00:00 2001 From: izeye Date: Tue, 17 Nov 2020 12:59:42 +0900 Subject: [PATCH] Avoid char array creation in AbstractAspectJAdvice.isVariableName() See gh-26100 --- .../springframework/aop/aspectj/AbstractAspectJAdvice.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spring-aop/src/main/java/org/springframework/aop/aspectj/AbstractAspectJAdvice.java b/spring-aop/src/main/java/org/springframework/aop/aspectj/AbstractAspectJAdvice.java index 1eb0e274562..7515334928f 100644 --- a/spring-aop/src/main/java/org/springframework/aop/aspectj/AbstractAspectJAdvice.java +++ b/spring-aop/src/main/java/org/springframework/aop/aspectj/AbstractAspectJAdvice.java @@ -354,8 +354,8 @@ public abstract class AbstractAspectJAdvice implements Advice, AspectJPrecedence if (!Character.isJavaIdentifierStart(name.charAt(0))) { return false; } - for (char ch: name.toCharArray()) { - if (!Character.isJavaIdentifierPart(ch)) { + for (int i = 1; i < name.length(); i++) { + if (!Character.isJavaIdentifierPart(name.charAt(i))) { return false; } }