Polishing

This commit is contained in:
Juergen Hoeller 2014-03-18 22:30:32 +01:00
parent e0757e7ed6
commit 373f07b1ff
1 changed files with 22 additions and 21 deletions

View File

@ -48,8 +48,8 @@ import org.springframework.web.socket.server.HandshakeFailureException;
import org.springframework.web.socket.server.RequestUpgradeStrategy;
/**
* A base class for {@link RequestUpgradeStrategy} implementations that build on the
* standard WebSocket API for Java.
* A base class for {@link RequestUpgradeStrategy} implementations that build
* on the standard WebSocket API for Java (JSR-356).
*
* @author Rossen Stoyanchev
* @since 4.0
@ -61,15 +61,6 @@ public abstract class AbstractStandardUpgradeStrategy implements RequestUpgradeS
private volatile List<WebSocketExtension> extensions;
@Override
public List<WebSocketExtension> getSupportedExtensions(ServerHttpRequest request) {
if(this.extensions == null) {
HttpServletRequest servletRequest = ((ServletServerHttpRequest) request).getServletRequest();
this.extensions = getInstalledExtensions(getContainer(servletRequest));
}
return this.extensions;
}
protected ServerContainer getContainer(HttpServletRequest request) {
ServletContext servletContext = request.getServletContext();
String attrName = "javax.websocket.server.ServerContainer";
@ -79,6 +70,26 @@ public abstract class AbstractStandardUpgradeStrategy implements RequestUpgradeS
return container;
}
protected final HttpServletRequest getHttpServletRequest(ServerHttpRequest request) {
Assert.isTrue(request instanceof ServletServerHttpRequest);
return ((ServletServerHttpRequest) request).getServletRequest();
}
protected final HttpServletResponse getHttpServletResponse(ServerHttpResponse response) {
Assert.isTrue(response instanceof ServletServerHttpResponse);
return ((ServletServerHttpResponse) response).getServletResponse();
}
@Override
public List<WebSocketExtension> getSupportedExtensions(ServerHttpRequest request) {
if (this.extensions == null) {
HttpServletRequest servletRequest = ((ServletServerHttpRequest) request).getServletRequest();
this.extensions = getInstalledExtensions(getContainer(servletRequest));
}
return this.extensions;
}
protected List<WebSocketExtension> getInstalledExtensions(WebSocketContainer container) {
List<WebSocketExtension> result = new ArrayList<WebSocketExtension>();
for (Extension ext : container.getInstalledExtensions()) {
@ -87,15 +98,6 @@ public abstract class AbstractStandardUpgradeStrategy implements RequestUpgradeS
return result;
}
protected final HttpServletResponse getHttpServletResponse(ServerHttpResponse response) {
Assert.isTrue(response instanceof ServletServerHttpResponse);
return ((ServletServerHttpResponse) response).getServletResponse();
}
protected final HttpServletRequest getHttpServletRequest(ServerHttpRequest request) {
Assert.isTrue(request instanceof ServletServerHttpRequest);
return ((ServletServerHttpRequest) request).getServletRequest();
}
@Override
public void upgrade(ServerHttpRequest request, ServerHttpResponse response,
@ -103,7 +105,6 @@ public abstract class AbstractStandardUpgradeStrategy implements RequestUpgradeS
WebSocketHandler wsHandler, Map<String, Object> attrs) throws HandshakeFailureException {
HttpHeaders headers = request.getHeaders();
InetSocketAddress localAddr = request.getLocalAddress();
InetSocketAddress remoteAddr = request.getRemoteAddress();