Throw exception from user code in SpringFailOnTimeout even if a timeout occurs

Issue: SPR-16717
This commit is contained in:
Igor Suhorukov 2018-04-12 11:37:13 +03:00 committed by Sam Brannen
parent 697d2e326f
commit 3c34a1cb8c
2 changed files with 50 additions and 9 deletions

View File

@ -88,15 +88,11 @@ public class SpringFailOnTimeout extends Statement {
}
else {
long startTime = System.currentTimeMillis();
try {
this.next.evaluate();
}
finally {
long elapsed = System.currentTimeMillis() - startTime;
if (elapsed > this.timeout) {
throw new TimeoutException(
String.format("Test took %s ms; limit was %s ms.", elapsed, this.timeout));
}
this.next.evaluate();
long elapsed = System.currentTimeMillis() - startTime;
if (elapsed > this.timeout) {
throw new TimeoutException(
String.format("Test took %s ms; limit was %s ms.", elapsed, this.timeout));
}
}
}

View File

@ -0,0 +1,45 @@
package org.springframework.test.context.junit4.spr16716;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.model.Statement;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;
import org.mockito.stubbing.Answer;
import org.springframework.test.context.junit4.statements.SpringFailOnTimeout;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.doThrow;
/**
* Validate SpringFailOnTimeout contract
* <a href="https://jira.spring.io/browse/SPR-16716" target="_blank">SPR-16716</a>.
*
* @author Igor Suhorukov
* @since 5.0.6
*/
@RunWith(MockitoJUnitRunner.class)
public class SpringFailOnTimeoutExceptionTest {
@Mock
private Statement statement;
@Test(expected = IllegalArgumentException.class)
public void validateOriginalExceptionFromEvaluateMethod() throws Throwable {
IllegalArgumentException expectedException = new IllegalArgumentException();
doThrow(expectedException).when(statement).evaluate();
new SpringFailOnTimeout(statement, TimeUnit.SECONDS.toMillis(1)).evaluate();
}
@Test(expected = TimeoutException.class)
public void validateTimeoutException() throws Throwable {
doAnswer((Answer<Void>) invocation -> {
TimeUnit.MILLISECONDS.sleep(50);
return null;
}).when(statement).evaluate();
new SpringFailOnTimeout(statement, TimeUnit.MILLISECONDS.toMillis(1)).evaluate();
}
}