From 3c557bfbc36564af11805970c07a6d35b6d229f6 Mon Sep 17 00:00:00 2001
From: Juergen Hoeller <jhoeller@vmware.com>
Date: Wed, 26 Sep 2012 10:30:15 +0200
Subject: [PATCH] LiveBeansView produces a well-defined (and valid) JSON
 document now

Issue: SPR-9662
---
 .../context/support/LiveBeansView.java        | 45 +++++++++++++------
 1 file changed, 32 insertions(+), 13 deletions(-)

diff --git a/spring-context/src/main/java/org/springframework/context/support/LiveBeansView.java b/spring-context/src/main/java/org/springframework/context/support/LiveBeansView.java
index 6a6291cb334..77b6aab8251 100644
--- a/spring-context/src/main/java/org/springframework/context/support/LiveBeansView.java
+++ b/spring-context/src/main/java/org/springframework/context/support/LiveBeansView.java
@@ -18,6 +18,7 @@ package org.springframework.context.support;
 
 import java.lang.management.ManagementFactory;
 import java.util.Collections;
+import java.util.Iterator;
 import java.util.LinkedHashSet;
 import java.util.Set;
 import javax.management.MBeanServer;
@@ -116,40 +117,50 @@ public class LiveBeansView implements LiveBeansViewMBean, ApplicationContextAwar
 	}
 
 	/**
-	 * Actually generate a JSON snapshot of the beans in the given ApplicationContexts
+	 * Actually generate a JSON snapshot of the beans in the given ApplicationContexts.
+	 * <p>This implementation doesn't use any JSON parsing libraries in order to avoid
+	 * third-party library dependencies. It produces an array of context description
+	 * objects, each containing a context and parent attribute as well as a beans
+	 * attribute with nested bean description objects. Each bean object contains a
+	 * bean, scope, type and resource attribute, as well as a dependencies attribute
+	 * with a nested array of bean names that the present bean depends on.
 	 * @param contexts the set of ApplicationContexts
 	 * @return the JSON document
 	 */
 	protected String generateJson(Set<ConfigurableApplicationContext> contexts) {
-		StringBuilder result = new StringBuilder();
-		for (ConfigurableApplicationContext context : contexts) {
-			result.append("{\n\"context\": \"").append(context.getId()).append("\"\n");
+		StringBuilder result = new StringBuilder("[\n");
+		for (Iterator<ConfigurableApplicationContext> it = contexts.iterator(); it.hasNext();) {
+			ConfigurableApplicationContext context = it.next();
+			result.append("{\n\"context\": \"").append(context.getId()).append("\",\n");
 			if (context.getParent() != null) {
-				result.append("\"parent\": \"").append(context.getParent().getId()).append("\"\n");
+				result.append("\"parent\": \"").append(context.getParent().getId()).append("\",\n");
 			}
 			else {
-				result.append("\"parent\": null\n");
+				result.append("\"parent\": null,\n");
 			}
+			result.append("\"beans\": [\n");
 			ConfigurableListableBeanFactory bf = context.getBeanFactory();
 			String[] beanNames = bf.getBeanDefinitionNames();
-			for (String beanName : beanNames) {
+			for (int i = 0; i < beanNames.length; i++) {
+				String beanName = beanNames[i];
 				BeanDefinition bd = bf.getBeanDefinition(beanName);
 				if (bd.getRole() != BeanDefinition.ROLE_INFRASTRUCTURE &&
 						(!bd.isLazyInit() || bf.containsSingleton(beanName))) {
-					result.append("{\n\"bean\": \"").append(beanName).append("\"\n");
+					result.append("{\n\"bean\": \"").append(beanName).append("\",\n");
 					String scope = bd.getScope();
 					if (!StringUtils.hasText(scope)) {
 						scope = BeanDefinition.SCOPE_SINGLETON;
 					}
-					result.append("\"scope\": \"").append(scope).append("\"\n");
+					result.append("\"scope\": \"").append(scope).append("\",\n");
 					Class beanType = bf.getType(beanName);
 					if (beanType != null) {
-						result.append("\"type\": \"").append(beanType.getName()).append("\"\n");
+						result.append("\"type\": \"").append(beanType.getName()).append("\",\n");
 					}
 					else {
-						result.append("\"type\": null\n");
+						result.append("\"type\": null,\n");
 					}
-					result.append("\"resource\": \"").append(bd.getResourceDescription()).append("\"\n");
+					String resource = StringUtils.replace(bd.getResourceDescription(), "\\", "/");
+					result.append("\"resource\": \"").append(resource).append("\",\n");
 					result.append("\"dependencies\": [");
 					String[] dependencies = bf.getDependenciesForBean(beanName);
 					if (dependencies.length > 0) {
@@ -159,11 +170,19 @@ public class LiveBeansView implements LiveBeansViewMBean, ApplicationContextAwar
 					if (dependencies.length > 0) {
 						result.append("\"");
 					}
-					result.append("]\n}\n");
+					result.append("]\n}");
+					if (i < beanNames.length - 1) {
+						result.append(",\n");
+					}
 				}
 			}
+			result.append("]\n");
 			result.append("}");
+			if (it.hasNext()) {
+				result.append(",\n");
+			}
 		}
+		result.append("]");
 		return result.toString();
 	}