root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Deprecate streaming mode in DefaultPartHttpMessageReader 

This commit deprecates the streaming mode of
DefaultPartHttpMessageReader, in favor of PartEvent and
PartEventHttpMessageReader.

Closes gh-29293
This commit is contained in:
Arjen Poutsma 2022-10-10 11:48:30 +02:00
parent be70b675c6
commit 3e33912624
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spring-web/src/main/java/org/springframework/http/codec/multipart/DefaultPartHttpMessageReader.java
View File

@ -49,9 +49,6 @@ import org.springframework.util.Assert;
* {@link #setMaxInMemorySize(int) maxInMemorySize} in memory, and parts larger * {@link #setMaxInMemorySize(int) maxInMemorySize} in memory, and parts larger
* than that to a temporary file in * than that to a temporary file in
* {@link #setFileStorageDirectory(Path) fileStorageDirectory}. * {@link #setFileStorageDirectory(Path) fileStorageDirectory}.
* <p>In {@linkplain #setStreaming(boolean) streaming} mode, the contents of the
* part is streamed directly from the parsed input buffer stream, and not stored
* in memory nor file.
* *
* <p>This reader can be provided to {@link MultipartHttpMessageReader} in order * <p>This reader can be provided to {@link MultipartHttpMessageReader} in order
* to aggregate all parts into a Map. * to aggregate all parts into a Map.
@ -181,7 +178,10 @@ public class DefaultPartHttpMessageReader extends LoggingCodecSupport implements
* {@link #setMaxDiskUsagePerPart(long) maxDiskUsagePerPart}, * {@link #setMaxDiskUsagePerPart(long) maxDiskUsagePerPart},
* {@link #setFileStorageDirectory(Path) fileStorageDirectory}, and * {@link #setFileStorageDirectory(Path) fileStorageDirectory}, and
* {@link #setBlockingOperationScheduler(Scheduler) fileCreationScheduler}. * {@link #setBlockingOperationScheduler(Scheduler) fileCreationScheduler}.
* @deprecated as of 6.0, in favor of {@link PartEvent} and
* {@link PartEventHttpMessageReader}
*/ */
@Deprecated(since = "6.0", forRemoval = true)
public void setStreaming(boolean streaming) { public void setStreaming(boolean streaming) {
this.streaming = streaming; this.streaming = streaming;
} }

3
spring-web/src/test/java/org/springframework/http/codec/multipart/DefaultPartHttpMessageReaderTests.java
View File

@ -418,16 +418,15 @@ class DefaultPartHttpMessageReaderTests {
@interface ParameterizedDefaultPartHttpMessageReaderTest { @interface ParameterizedDefaultPartHttpMessageReaderTest {
} }
@SuppressWarnings("removal")
static Stream<Arguments> messageReaders() { static Stream<Arguments> messageReaders() {
DefaultPartHttpMessageReader streaming = new DefaultPartHttpMessageReader(); DefaultPartHttpMessageReader streaming = new DefaultPartHttpMessageReader();
streaming.setStreaming(true); streaming.setStreaming(true);
DefaultPartHttpMessageReader inMemory = new DefaultPartHttpMessageReader(); DefaultPartHttpMessageReader inMemory = new DefaultPartHttpMessageReader();
inMemory.setStreaming(false);
inMemory.setMaxInMemorySize(1000); inMemory.setMaxInMemorySize(1000);
DefaultPartHttpMessageReader onDisk = new DefaultPartHttpMessageReader(); DefaultPartHttpMessageReader onDisk = new DefaultPartHttpMessageReader();
onDisk.setStreaming(false);
onDisk.setMaxInMemorySize(100); onDisk.setMaxInMemorySize(100);
return Stream.of( return Stream.of(