Avoid NPE in case of @Lazy @Autowired(required=false)
Issue: SPR-13967
(cherry picked from commit b9fe6d8
)
This commit is contained in:
parent
99dc7769a6
commit
3f795e64c6
|
@ -1,5 +1,5 @@
|
||||||
/*
|
/*
|
||||||
* Copyright 2002-2013 the original author or authors.
|
* Copyright 2002-2016 the original author or authors.
|
||||||
*
|
*
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
* you may not use this file except in compliance with the License.
|
* you may not use this file except in compliance with the License.
|
||||||
|
@ -21,6 +21,7 @@ import java.lang.reflect.Method;
|
||||||
|
|
||||||
import org.springframework.aop.TargetSource;
|
import org.springframework.aop.TargetSource;
|
||||||
import org.springframework.aop.framework.ProxyFactory;
|
import org.springframework.aop.framework.ProxyFactory;
|
||||||
|
import org.springframework.beans.factory.NoSuchBeanDefinitionException;
|
||||||
import org.springframework.beans.factory.annotation.QualifierAnnotationAutowireCandidateResolver;
|
import org.springframework.beans.factory.annotation.QualifierAnnotationAutowireCandidateResolver;
|
||||||
import org.springframework.beans.factory.config.DependencyDescriptor;
|
import org.springframework.beans.factory.config.DependencyDescriptor;
|
||||||
import org.springframework.beans.factory.support.DefaultListableBeanFactory;
|
import org.springframework.beans.factory.support.DefaultListableBeanFactory;
|
||||||
|
@ -79,7 +80,12 @@ public class ContextAnnotationAutowireCandidateResolver extends QualifierAnnotat
|
||||||
}
|
}
|
||||||
@Override
|
@Override
|
||||||
public Object getTarget() {
|
public Object getTarget() {
|
||||||
return beanFactory.doResolveDependency(descriptor, beanName, null, null);
|
Object target = beanFactory.doResolveDependency(descriptor, beanName, null, null);
|
||||||
|
if (target == null) {
|
||||||
|
throw new NoSuchBeanDefinitionException(descriptor.getDependencyType(),
|
||||||
|
"Optional dependency not present for lazy injection point");
|
||||||
|
}
|
||||||
|
return target;
|
||||||
}
|
}
|
||||||
@Override
|
@Override
|
||||||
public void releaseTarget(Object target) {
|
public void releaseTarget(Object target) {
|
||||||
|
|
|
@ -1,5 +1,5 @@
|
||||||
/*
|
/*
|
||||||
* Copyright 2002-2013 the original author or authors.
|
* Copyright 2002-2016 the original author or authors.
|
||||||
*
|
*
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
* you may not use this file except in compliance with the License.
|
* you may not use this file except in compliance with the License.
|
||||||
|
@ -118,6 +118,28 @@ public class LazyAutowiredAnnotationBeanPostProcessorTests {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testLazyOptionalResourceInjectionWithNonExistingTarget() {
|
||||||
|
DefaultListableBeanFactory bf = new DefaultListableBeanFactory();
|
||||||
|
bf.setAutowireCandidateResolver(new ContextAnnotationAutowireCandidateResolver());
|
||||||
|
AutowiredAnnotationBeanPostProcessor bpp = new AutowiredAnnotationBeanPostProcessor();
|
||||||
|
bpp.setBeanFactory(bf);
|
||||||
|
bf.addBeanPostProcessor(bpp);
|
||||||
|
RootBeanDefinition bd = new RootBeanDefinition(OptionalFieldResourceInjectionBean.class);
|
||||||
|
bd.setScope(RootBeanDefinition.SCOPE_PROTOTYPE);
|
||||||
|
bf.registerBeanDefinition("annotatedBean", bd);
|
||||||
|
|
||||||
|
OptionalFieldResourceInjectionBean bean = (OptionalFieldResourceInjectionBean) bf.getBean("annotatedBean");
|
||||||
|
assertNotNull(bean.getTestBean());
|
||||||
|
try {
|
||||||
|
bean.getTestBean().getName();
|
||||||
|
fail("Should have thrown NoSuchBeanDefinitionException");
|
||||||
|
}
|
||||||
|
catch (NoSuchBeanDefinitionException ex) {
|
||||||
|
// expected;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
public interface TestBeanHolder {
|
public interface TestBeanHolder {
|
||||||
|
|
||||||
|
@ -136,6 +158,17 @@ public class LazyAutowiredAnnotationBeanPostProcessorTests {
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
public static class OptionalFieldResourceInjectionBean implements TestBeanHolder {
|
||||||
|
|
||||||
|
@Autowired(required = false) @Lazy
|
||||||
|
private TestBean testBean;
|
||||||
|
|
||||||
|
public TestBean getTestBean() {
|
||||||
|
return this.testBean;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
public static class FieldResourceInjectionBeanWithCompositeAnnotation implements TestBeanHolder {
|
public static class FieldResourceInjectionBeanWithCompositeAnnotation implements TestBeanHolder {
|
||||||
|
|
||||||
@LazyInject
|
@LazyInject
|
||||||
|
|
Loading…
Reference in New Issue