diff --git a/spring-context/src/main/java/org/springframework/context/annotation/Configuration.java b/spring-context/src/main/java/org/springframework/context/annotation/Configuration.java index 17633580bd8..5acfd2d2c16 100644 --- a/spring-context/src/main/java/org/springframework/context/annotation/Configuration.java +++ b/spring-context/src/main/java/org/springframework/context/annotation/Configuration.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2022 the original author or authors. + * Copyright 2002-2023 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -104,8 +104,8 @@ import org.springframework.stereotype.Component; * * } * - *

{@code @Configuration} classes may not only be bootstrapped using - * component scanning, but may also themselves configure component scanning using + *

{@code @Configuration} classes may not only be bootstrapped using component + * scanning, but may also themselves configure component scanning using * the {@link ComponentScan @ComponentScan} annotation: * *

diff --git a/spring-core/src/main/java/org/springframework/util/backoff/ExponentialBackOff.java b/spring-core/src/main/java/org/springframework/util/backoff/ExponentialBackOff.java
index 0331699a5b6..dceea17b91a 100644
--- a/spring-core/src/main/java/org/springframework/util/backoff/ExponentialBackOff.java
+++ b/spring-core/src/main/java/org/springframework/util/backoff/ExponentialBackOff.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,12 +20,12 @@ import org.springframework.util.Assert;
 
 /**
  * Implementation of {@link BackOff} that increases the back off period for each
- * retry attempt. When the interval has reached the {@link #setMaxInterval(long)
+ * retry attempt. When the interval has reached the {@linkplain #setMaxInterval
  * max interval}, it is no longer increased. Stops retrying once the
- * {@link #setMaxElapsedTime(long) max elapsed time} has been reached.
+ * {@linkplain #setMaxElapsedTime max elapsed time} has been reached.
  *
- * 

Example: The default interval is {@value #DEFAULT_INITIAL_INTERVAL} ms, - * the default multiplier is {@value #DEFAULT_MULTIPLIER}, and the default max + *

Example: The default interval is {@value #DEFAULT_INITIAL_INTERVAL} ms; + * the default multiplier is {@value #DEFAULT_MULTIPLIER}; and the default max * interval is {@value #DEFAULT_MAX_INTERVAL}. For 10 attempts the sequence will be * as follows: * @@ -44,10 +44,9 @@ import org.springframework.util.Assert; * 10 30000 *

* - *

Note that the default max elapsed time is {@link Long#MAX_VALUE}. Use - * {@link #setMaxElapsedTime(long)} to limit the maximum length of time - * that an instance should accumulate before returning - * {@link BackOffExecution#STOP}. + *

Note that the default max elapsed time is {@link Long#MAX_VALUE}. + * Use {@link #setMaxElapsedTime} to limit the maximum length of time that an + * instance should accumulate before returning {@link BackOffExecution#STOP}. * * @author Stephane Nicoll * @since 4.1 @@ -107,7 +106,7 @@ public class ExponentialBackOff implements BackOff { /** - * The initial interval in milliseconds. + * Set the initial interval in milliseconds. */ public void setInitialInterval(long initialInterval) { this.initialInterval = initialInterval; @@ -121,7 +120,7 @@ public class ExponentialBackOff implements BackOff { } /** - * The value to multiply the current interval by for each retry attempt. + * Set the value to multiply the current interval by for each retry attempt. */ public void setMultiplier(double multiplier) { checkMultiplier(multiplier); @@ -136,21 +135,21 @@ public class ExponentialBackOff implements BackOff { } /** - * The maximum back off time. + * Set the maximum back off time in milliseconds. */ public void setMaxInterval(long maxInterval) { this.maxInterval = maxInterval; } /** - * Return the maximum back off time. + * Return the maximum back off time in milliseconds. */ public long getMaxInterval() { return this.maxInterval; } /** - * The maximum elapsed time in milliseconds after which a call to + * Set the maximum elapsed time in milliseconds after which a call to * {@link BackOffExecution#nextBackOff()} returns {@link BackOffExecution#STOP}. */ public void setMaxElapsedTime(long maxElapsedTime) { @@ -184,10 +183,9 @@ public class ExponentialBackOff implements BackOff { @Override public long nextBackOff() { - if (this.currentElapsedTime >= maxElapsedTime) { + if (this.currentElapsedTime >= getMaxElapsedTime()) { return STOP; } - long nextInterval = computeNextInterval(); this.currentElapsedTime += nextInterval; return nextInterval; @@ -214,7 +212,6 @@ public class ExponentialBackOff implements BackOff { return Math.min(i, maxInterval); } - @Override public String toString() { StringBuilder sb = new StringBuilder("ExponentialBackOff{"); diff --git a/spring-orm/src/main/java/org/springframework/orm/jpa/vendor/HibernateJpaDialect.java b/spring-orm/src/main/java/org/springframework/orm/jpa/vendor/HibernateJpaDialect.java index 76f7304e308..ae1f787509f 100644 --- a/spring-orm/src/main/java/org/springframework/orm/jpa/vendor/HibernateJpaDialect.java +++ b/spring-orm/src/main/java/org/springframework/orm/jpa/vendor/HibernateJpaDialect.java @@ -252,24 +252,24 @@ public class HibernateJpaDialect extends DefaultJpaDialect { if (ex instanceof JDBCConnectionException) { return new DataAccessResourceFailureException(ex.getMessage(), ex); } - if (ex instanceof SQLGrammarException hibJdbcEx) { - return new InvalidDataAccessResourceUsageException(ex.getMessage() + "; SQL [" + hibJdbcEx.getSQL() + "]", ex); + if (ex instanceof SQLGrammarException hibEx) { + return new InvalidDataAccessResourceUsageException(ex.getMessage() + "; SQL [" + hibEx.getSQL() + "]", ex); } - if (ex instanceof QueryTimeoutException hibJdbcEx) { - return new org.springframework.dao.QueryTimeoutException(ex.getMessage() + "; SQL [" + hibJdbcEx.getSQL() + "]", ex); + if (ex instanceof QueryTimeoutException hibEx) { + return new org.springframework.dao.QueryTimeoutException(ex.getMessage() + "; SQL [" + hibEx.getSQL() + "]", ex); } - if (ex instanceof LockAcquisitionException hibJdbcEx) { - return new CannotAcquireLockException(ex.getMessage() + "; SQL [" + hibJdbcEx.getSQL() + "]", ex); + if (ex instanceof LockAcquisitionException hibEx) { + return new CannotAcquireLockException(ex.getMessage() + "; SQL [" + hibEx.getSQL() + "]", ex); } - if (ex instanceof PessimisticLockException hibJdbcEx) { - return new PessimisticLockingFailureException(ex.getMessage() + "; SQL [" + hibJdbcEx.getSQL() + "]", ex); + if (ex instanceof PessimisticLockException hibEx) { + return new PessimisticLockingFailureException(ex.getMessage() + "; SQL [" + hibEx.getSQL() + "]", ex); } - if (ex instanceof ConstraintViolationException hibJdbcEx) { - return new DataIntegrityViolationException(ex.getMessage() + "; SQL [" + hibJdbcEx.getSQL() + - "]; constraint [" + hibJdbcEx.getConstraintName() + "]", ex); + if (ex instanceof ConstraintViolationException hibEx) { + return new DataIntegrityViolationException(ex.getMessage() + "; SQL [" + hibEx.getSQL() + + "]; constraint [" + hibEx.getConstraintName() + "]", ex); } - if (ex instanceof DataException hibJdbcEx) { - return new DataIntegrityViolationException(ex.getMessage() + "; SQL [" + hibJdbcEx.getSQL() + "]", ex); + if (ex instanceof DataException hibEx) { + return new DataIntegrityViolationException(ex.getMessage() + "; SQL [" + hibEx.getSQL() + "]", ex); } // end of JDBCException subclass handling diff --git a/spring-r2dbc/src/main/java/org/springframework/r2dbc/core/DefaultDatabaseClient.java b/spring-r2dbc/src/main/java/org/springframework/r2dbc/core/DefaultDatabaseClient.java index 7db53bcd280..dcfdbd33ee6 100644 --- a/spring-r2dbc/src/main/java/org/springframework/r2dbc/core/DefaultDatabaseClient.java +++ b/spring-r2dbc/src/main/java/org/springframework/r2dbc/core/DefaultDatabaseClient.java @@ -166,9 +166,8 @@ final class DefaultDatabaseClient implements DatabaseClient { * @return a {@link Publisher} that completes successfully when the connection is closed */ private Publisher closeConnection(Connection connection) { - return ConnectionFactoryUtils.currentConnectionFactory( - obtainConnectionFactory()).then().onErrorResume(Exception.class, - e -> Mono.from(connection.close())); + return ConnectionFactoryUtils.currentConnectionFactory(obtainConnectionFactory()).then() + .onErrorResume(Exception.class, ex -> Mono.from(connection.close())); } /**