From 49294c9d008ab63d3b33d708fc48b3f4321785db Mon Sep 17 00:00:00 2001
From: Juergen Hoeller <jhoeller@vmware.com>
Date: Wed, 26 Sep 2012 20:03:30 +0200
Subject: [PATCH] ClassUtils.getMostSpecificMethod uses Class.getMethod code
 path in case of a public method

This should be significantly faster than our standard algorithm, for a very common case. Motivated by SPR-9802, even if the fix there uses a different approach, with transaction name determination not calling getMostSpecificMethod at all anymore.

Issue: SPR-9802
---
 .../org/springframework/util/ClassUtils.java  | 26 +++++++++++++------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/spring-core/src/main/java/org/springframework/util/ClassUtils.java b/spring-core/src/main/java/org/springframework/util/ClassUtils.java
index e3212916204..6def0062324 100644
--- a/spring-core/src/main/java/org/springframework/util/ClassUtils.java
+++ b/spring-core/src/main/java/org/springframework/util/ClassUtils.java
@@ -724,7 +724,7 @@ public abstract class ClassUtils {
 	 * Call {@link org.springframework.core.BridgeMethodResolver#findBridgedMethod}
 	 * if bridge method resolution is desirable (e.g. for obtaining metadata from
 	 * the original method definition).
-	 * <p><b>NOTE:</b>Since Spring 3.1.1, if java security settings disallow reflective
+	 * <p><b>NOTE:</b> Since Spring 3.1.1, if Java security settings disallow reflective
 	 * access (e.g. calls to {@code Class#getDeclaredMethods} etc, this implementation
 	 * will fall back to returning the originally provided method.
 	 * @param method the method to be invoked, which may come from an interface
@@ -734,17 +734,28 @@ public abstract class ClassUtils {
 	 * <code>targetClass</code> doesn't implement it or is <code>null</code>
 	 */
 	public static Method getMostSpecificMethod(Method method, Class<?> targetClass) {
-		Method specificMethod = null;
 		if (method != null && isOverridable(method, targetClass) &&
 				targetClass != null && !targetClass.equals(method.getDeclaringClass())) {
 			try {
-				specificMethod = ReflectionUtils.findMethod(targetClass, method.getName(), method.getParameterTypes());
-			} catch (AccessControlException ex) {
-				// security settings are disallowing reflective access; leave
-				// 'specificMethod' null and fall back to 'method' below
+				if (Modifier.isPublic(method.getModifiers())) {
+					try {
+						return targetClass.getMethod(method.getName(), method.getParameterTypes());
+					}
+					catch (NoSuchMethodException ex) {
+						return method;
+					}
+				}
+				else {
+					Method specificMethod =
+							ReflectionUtils.findMethod(targetClass, method.getName(), method.getParameterTypes());
+					return (specificMethod != null ? specificMethod : method);
+				}
+			}
+			catch (AccessControlException ex) {
+				// Security settings are disallowing reflective access; fall back to 'method' below.
 			}
 		}
-		return (specificMethod != null ? specificMethod : method);
+		return method;
 	}
 
 	/**
@@ -1150,5 +1161,4 @@ public abstract class ClassUtils {
 		return (className != null && className.contains(CGLIB_CLASS_SEPARATOR));
 	}
 
-
 }