root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Avoid substring allocation in StringUtils.replace 

Closes gh-24023
This commit is contained in:
Juergen Hoeller 2019-11-19 14:53:30 +01:00
parent b4e1d48322
commit 4af6039359
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spring-core/src/main/java/org/springframework/util/StringUtils.java
View File

@ -420,14 +420,14 @@ public abstract class StringUtils {
int pos = 0; // our position in the old string int pos = 0; // our position in the old string
int patLen = oldPattern.length(); int patLen = oldPattern.length();
while (index >= 0) { while (index >= 0) {
sb.append(inString.substring(pos, index)); sb.append(inString, pos, index);
sb.append(newPattern); sb.append(newPattern);
pos = index + patLen; pos = index + patLen;
index = inString.indexOf(oldPattern, pos); index = inString.indexOf(oldPattern, pos);
} }
// append any characters to the right of a match // append any characters to the right of a match
sb.append(inString.substring(pos)); sb.append(inString, pos, inString.length());
return sb.toString(); return sb.toString();
} }