root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Return static DefaultApplicationStartup step 

This commit ensures that `DefaultApplicationStartup` returns a static
step for each call to avoid allocations.

Closes gh-26939
This commit is contained in:
Brian Clozel 2021-06-01 15:04:26 +02:00
parent e0690335fc
commit 5204d736f3
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
spring-core/src/main/java/org/springframework/core/metrics/DefaultApplicationStartup.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2020 the original author or authors. * Copyright 2002-2021 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -29,16 +29,16 @@ import java.util.function.Supplier;
*/ */
class DefaultApplicationStartup implements ApplicationStartup { class DefaultApplicationStartup implements ApplicationStartup {
private static final DefaultStartupStep DEFAULT_STARTUP_STEP = new DefaultStartupStep();
@Override @Override
public DefaultStartupStep start(String name) { public DefaultStartupStep start(String name) {
return new DefaultStartupStep(); return DEFAULT_STARTUP_STEP;
} }
static class DefaultStartupStep implements StartupStep { static class DefaultStartupStep implements StartupStep {
boolean recorded = false;
private final DefaultTags TAGS = new DefaultTags(); private final DefaultTags TAGS = new DefaultTags();
@Override @Override
@ -63,23 +63,17 @@ class DefaultApplicationStartup implements ApplicationStartup {
@Override @Override
public StartupStep tag(String key, String value) { public StartupStep tag(String key, String value) {
if (this.recorded) {
throw new IllegalArgumentException();
}
return this; return this;
} }
@Override @Override
public StartupStep tag(String key, Supplier<String> value) { public StartupStep tag(String key, Supplier<String> value) {
if (this.recorded) {
throw new IllegalArgumentException();
}
return this; return this;
} }
@Override @Override
public void end() { public void end() {
this.recorded = true;
} }