diff --git a/spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultExchangeStrategiesBuilder.java b/spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultExchangeStrategiesBuilder.java index 961f0b2caeb..e034dcc1cf4 100644 --- a/spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultExchangeStrategiesBuilder.java +++ b/spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultExchangeStrategiesBuilder.java @@ -22,7 +22,6 @@ import java.util.List; import java.util.function.Consumer; import org.springframework.http.codec.ClientCodecConfigurer; -import org.springframework.http.codec.CodecConfigurer; import org.springframework.http.codec.HttpMessageReader; import org.springframework.http.codec.HttpMessageWriter; import org.springframework.util.Assert; @@ -47,18 +46,9 @@ class DefaultExchangeStrategiesBuilder implements ExchangeStrategies.Builder { } @Override - public ExchangeStrategies.Builder defaultCodecs( - Consumer consumer) { + public ExchangeStrategies.Builder codecs(Consumer consumer) { Assert.notNull(consumer, "'consumer' must not be null"); - consumer.accept(this.codecConfigurer.defaultCodecs()); - return this; - } - - @Override - public ExchangeStrategies.Builder customCodecs( - Consumer consumer) { - Assert.notNull(consumer, "'consumer' must not be null"); - consumer.accept(this.codecConfigurer.customCodecs()); + consumer.accept(this.codecConfigurer); return this; } diff --git a/spring-webflux/src/main/java/org/springframework/web/reactive/function/client/ExchangeStrategies.java b/spring-webflux/src/main/java/org/springframework/web/reactive/function/client/ExchangeStrategies.java index d0bd9186712..4830d07b884 100644 --- a/spring-webflux/src/main/java/org/springframework/web/reactive/function/client/ExchangeStrategies.java +++ b/spring-webflux/src/main/java/org/springframework/web/reactive/function/client/ExchangeStrategies.java @@ -20,7 +20,6 @@ import java.util.List; import java.util.function.Consumer; import org.springframework.http.codec.ClientCodecConfigurer; -import org.springframework.http.codec.CodecConfigurer; import org.springframework.http.codec.HttpMessageReader; import org.springframework.http.codec.HttpMessageWriter; @@ -88,20 +87,11 @@ public interface ExchangeStrategies { interface Builder { /** - * Customize the list of default client-side HTTP message readers and writers. - * @param consumer the consumer to customize the default codecs + * Customize the list of client-side HTTP message readers and writers. + * @param consumer the consumer to customize the codecs * @return this builder - * @see #customCodecs(Consumer) */ - Builder defaultCodecs(Consumer consumer); - - /** - * Customize the list of custom client-side HTTP message readers and writers. - * @param consumer the consumer to customize the custom codecs - * @return this builder - * @see #defaultCodecs(Consumer) - */ - Builder customCodecs(Consumer consumer); + Builder codecs(Consumer consumer); /** * Builds the {@link ExchangeStrategies}. diff --git a/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultHandlerStrategiesBuilder.java b/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultHandlerStrategiesBuilder.java index 7b2b0926e02..f49e146a58f 100644 --- a/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultHandlerStrategiesBuilder.java +++ b/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultHandlerStrategiesBuilder.java @@ -21,17 +21,16 @@ import java.util.Collections; import java.util.List; import java.util.function.Consumer; -import org.springframework.http.codec.CodecConfigurer; import org.springframework.http.codec.HttpMessageReader; import org.springframework.http.codec.HttpMessageWriter; import org.springframework.http.codec.ServerCodecConfigurer; import org.springframework.util.Assert; import org.springframework.web.reactive.result.view.ViewResolver; -import org.springframework.web.server.i18n.LocaleContextResolver; import org.springframework.web.server.WebExceptionHandler; import org.springframework.web.server.WebFilter; import org.springframework.web.server.handler.ResponseStatusExceptionHandler; import org.springframework.web.server.i18n.AcceptHeaderLocaleContextResolver; +import org.springframework.web.server.i18n.LocaleContextResolver; /** * Default implementation of {@link HandlerStrategies.Builder}. @@ -63,18 +62,9 @@ class DefaultHandlerStrategiesBuilder implements HandlerStrategies.Builder { } @Override - public HandlerStrategies.Builder defaultCodecs( - Consumer consumer) { + public HandlerStrategies.Builder codecs(Consumer consumer) { Assert.notNull(consumer, "'consumer' must not be null"); - consumer.accept(this.codecConfigurer.defaultCodecs()); - return this; - } - - @Override - public HandlerStrategies.Builder customCodecs( - Consumer consumer) { - Assert.notNull(consumer, "'consumer' must not be null"); - consumer.accept(this.codecConfigurer.customCodecs()); + consumer.accept(this.codecConfigurer); return this; } diff --git a/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/HandlerStrategies.java b/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/HandlerStrategies.java index bbd3bcce6c9..dced104848f 100644 --- a/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/HandlerStrategies.java +++ b/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/HandlerStrategies.java @@ -19,14 +19,13 @@ package org.springframework.web.reactive.function.server; import java.util.List; import java.util.function.Consumer; -import org.springframework.http.codec.CodecConfigurer; import org.springframework.http.codec.HttpMessageReader; import org.springframework.http.codec.HttpMessageWriter; import org.springframework.http.codec.ServerCodecConfigurer; import org.springframework.web.reactive.result.view.ViewResolver; -import org.springframework.web.server.i18n.LocaleContextResolver; import org.springframework.web.server.WebExceptionHandler; import org.springframework.web.server.WebFilter; +import org.springframework.web.server.i18n.LocaleContextResolver; /** * Defines the strategies to be used for processing {@link HandlerFunction}s. An instance of @@ -118,20 +117,11 @@ public interface HandlerStrategies { interface Builder { /** - * Customize the list of default server-side HTTP message readers and writers. - * @param consumer the consumer to customize the default codecs + * Customize the list of server-side HTTP message readers and writers. + * @param consumer the consumer to customize the codecs * @return this builder - * @see #customCodecs(Consumer) */ - Builder defaultCodecs(Consumer consumer); - - /** - * Customize the list of custom server-side HTTP message readers and writers. - * @param consumer the consumer to customize the custom codecs - * @return this builder - * @see #defaultCodecs(Consumer) - */ - Builder customCodecs(Consumer consumer); + Builder codecs(Consumer consumer); /** * Add the given view resolver to this builder. diff --git a/spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultEntityResponseBuilderTests.java b/spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultEntityResponseBuilderTests.java index 13df33efcb7..50d33330f75 100644 --- a/spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultEntityResponseBuilderTests.java +++ b/spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultEntityResponseBuilderTests.java @@ -48,7 +48,8 @@ import org.springframework.web.reactive.function.BodyInserter; import org.springframework.web.reactive.result.view.ViewResolver; import static java.nio.charset.StandardCharsets.UTF_8; -import static org.junit.Assert.*; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertSame; /** * @author Arjen Poutsma @@ -203,10 +204,6 @@ public class DefaultEntityResponseBuilderTests { return Collections.emptyList(); } }; - HandlerStrategies strategies = HandlerStrategies.empty() - .customCodecs(configurer -> configurer.writer(new EncoderHttpMessageWriter<>(CharSequenceEncoder.allMimeTypes()))) - .build(); - StepVerifier.create(result) .consumeNextWith(response -> { StepVerifier.create(response.entity())